From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754386AbdJPRqg (ORCPT ); Mon, 16 Oct 2017 13:46:36 -0400 Received: from mail-dm3nam03on0079.outbound.protection.outlook.com ([104.47.41.79]:41455 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752477AbdJPRqe (ORCPT ); Mon, 16 Oct 2017 13:46:34 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, x86@kernel.org, Tom Lendacky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , linux-kernel@vger.kernel.org Subject: Re: [Part1 PATCH v6 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support To: Borislav Petkov References: <20171016153423.2980-1-brijesh.singh@amd.com> <20171016153423.2980-3-brijesh.singh@amd.com> <20171016162118.i2n34wrfiaqytr5v@pd.tnic> From: Brijesh Singh Message-ID: <792fdb90-3416-2f4e-59c1-a203b2ca9b5f@amd.com> Date: Mon, 16 Oct 2017 12:46:20 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171016162118.i2n34wrfiaqytr5v@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR2001CA0017.namprd20.prod.outlook.com (10.172.112.155) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b449fa92-3267-4773-eca2-08d514bdd6e4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;3:Z6mVMEjC+He1nT0LTdHTMWr7N7ACL4HpPEwVrjvZSbgd+3D2Ji+RA5MoQuygj5swcx8p8OscxBD4fdPgYR2dVng17tMFYyaeJZxpifKX1ELsKBblCbAaNlJ9lDhWdJvOKM/OmVo/8bc3TybwZOzmWa67hAi+HUKWL8MO1MEx1sEu7/2Cvo1ETrJ2RW17ihM3XWDCFXqeICvmokohy/cAh2ZA1WQtm79tXwn9KnsaSS1ldLv1gUE2sMJPrrgJ8pug;25:e6QegAyXWrLugE8KIePEwS8auZowHIN2hvtiRNQGDzSFSFMVgz02nUzPoJrNcht5i9PTpW0MNoLc0OGu8j22THL+japxlfnSl8Gcld5mBjvTPsthDR+yA6eWhP0TRNh+wilGkheGp+6xCIt0P590Y0wUx4rKI6MlmcpLigETagq+AkhCxhIwjeh53F4kFXN0ucQwQGa4FUe96+wP/QFVs3diddj0Ke+/PaLuc+h+DipRrXQgYE0196eLd5malIPFFxMJqJX6SSK/uu8SXlbZ0VsrQ0Zu0Eir4z3w2IaDVXnE2IlD6l3PPzB1LdK+z/IZjWNLZ+mzRDbz9ujaTXcoWg==;31:mO4vDm3vSiTttKaduG7bvkNAyuJvsF8fqxsmj6iTy+b1VG984HYhP4kI00XqD5Ee3GXHJGWdz100xI1QNi95KmaV8QS1gVhPqY+OENctWmyeX5smX59K+Txc14BA5TjxX0XQlbnWOAOvRdyG2dv3zgFJLntzuYy8vomH5b1hboV/wRnjaTqLB/CQAq3dgb9EekUP8eSU7eTdcH01y/qeJN7oAIm/0gOMs0eDgMZpFes= X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:7QGjmamal6zuwRq8QD04sfFmywJmjh8VEBiox8+yOTGzwhijb/D0t+iilecGyvXHd/Yy2AHa6pT5uSN36g4Wc5UzWjpoMwqBwT2GK4zgHJaRleL1nfgxKEXYQekj18spMGcl4wX+IySybLAMYmIQBCKZ99fEdccHTY2K1cGZaajQ1efV9Gei8ToKIjgZsSc8GtmcM3f750mdNHFeTEfs4gi3heIbJ0+KmwBjXwADdmxuQ3t5owcRLrj6FjpISIYwIV0v/gZTRHPqK1TUgYDVRAXvGrotNFIJRRLoATQ4cEkvWydRcGtQW2DQpVG0asYqQ89uVRcchT/k8cn1U8bdLhaPDKxv5iibBJmbbevFb/7oQg3fykosaKrUazFyCsIs9zVFgk7n6yUX0TfQ+Dqrrjn3ptoRCX0JIrGm7UzHlKTdI7rFpBFo7gkz/5bb9Agpt47xi9y4OBEYWQ28GHuq1mCBjxNIPNB+MIrKPqHg82VseZAc9FF6JDspAdgbTmIZ;4:UmFkwbZZrnA854Y9MJwI7pN5TysFyK3O3c23ApAWcnfhWg1WDb4Db2jetkip2AqRVwQduP8lB0aNMlUbEnUa9v60PVaXZ6Q1OiKBJbYhxZY+2VOFemAFiamipiOWIwahpqyJ1uuaNCTsGPg2fCA7pR5XpmK6Vixax+aOAeUuQpyDDKiBWbaf7NFEcAlIzCsxG2hjdP9g/fX5V9GDbDMUoI7S888JFXvNROEYOW+GpDS2RZRfHGja78M0IVpKvmLu X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0158;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0158; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(39860400002)(346002)(199003)(189002)(377454003)(24454002)(54906003)(316002)(5660300001)(58126008)(68736007)(53546010)(2906002)(4326008)(16526018)(7736002)(65956001)(47776003)(65806001)(305945005)(23676002)(31696002)(6666003)(31686004)(53936002)(86362001)(33646002)(2950100002)(6916009)(66066001)(189998001)(6246003)(83506001)(97736004)(76176999)(64126003)(106356001)(101416001)(53416004)(8676002)(54356999)(105586002)(6486002)(36756003)(3846002)(6116002)(229853002)(8936002)(81166006)(81156014)(65826007)(25786009)(230700001)(50986999)(50466002)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0158;H:wsp094129wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOlFQMFBlZ0twSkVNU3BIS1ZUYmdVREk1T1Vj?= =?utf-8?B?bjVrcklSYVRYZTlRT2FCT1p1TmRuUHRRdHErMEkvcWU2RkFqUGR0Mkpxd29N?= =?utf-8?B?V0JMYzlJeE5Od2VCZ2hkcGgyNHJscHdBYnlScmtVMHlybmo2cXh4SDVMWUFi?= =?utf-8?B?K2kzUFpvUjYzUi9Sb3JzcFRNbWpZVWlwTGVYd0dOQlhHcDZtUUpCZy92TUQ3?= =?utf-8?B?dmNaNmtUWDlVQ01jdkdHM0YyOHJ1NUFnSHYrVTFsSzdRWkpuVkt3ZW5vWmxr?= =?utf-8?B?OW1pbnJ6S0FwUUF3STd5YkJLVFBTLy80ZHQ4THIzTFJ3QjJ0c1kwajI0ejNY?= =?utf-8?B?NU5UcE5SKzVnV2xtQVI0MTcvS1M3WW5wV2hPZndpamFPV1NwbThSWHhGQTEr?= =?utf-8?B?WkVUS2NEbGxvek82R1MvaXU4ajRlMit0UHM2Yk02WDJDU1NmYVBXcEdNZU1D?= =?utf-8?B?Z05iazdRVmRyTHFobzNObzNFOTl0ZWVtQzVXN0pRQmZxVCtJNVJ5SVh3ZzRo?= =?utf-8?B?cVFqL2o3aHlkekVTWE1ZdGVjaTJSYmUvVmJUMGIxVkVGZy9RTSszZlBMVHRa?= =?utf-8?B?d0orRURzeE9ISk5MU252aXFBcnoxc3h0aEpua2VkWEVIbEdSb2VTS0t2NWpM?= =?utf-8?B?Uk9uRGVJQ21memxjd3BBR2JBRUExaS9Xait2TkhETFRiZnlkMFZJM1h4YVFV?= =?utf-8?B?Ynh6ZlB5YjEyMTVHLzFQOElLaEdaTFc1Wk02dW1WZlZHd2FJMmwyZ2xPR0tN?= =?utf-8?B?YlhRZ1UyU2xqVjMzbHhCam95aGZQdnU5Q3NoemJpME1zNVM0dS9zZ1dkVHBO?= =?utf-8?B?RFZxRmRMUGNDaFVIeWU1d1IxRnBTS0FrRHlhVFNYT29sUlhkbFFraW5YUWtW?= =?utf-8?B?MmpyaEVJazJEMTYrL0N5K0JlQ0g3RUgwZTF4eDFFWGNHeTQzUFlPemg4UDBZ?= =?utf-8?B?WGtSSnFFcGh1WUdUdnBNYlBQNkg3UndGWnVxY3pHMlBndU01M3MrMUtMam5G?= =?utf-8?B?SGpkUHNKRitNVmNpUHpubXN1NGw1cXRKajE5U1IvSnpFSU1kNm00SjY5OXRS?= =?utf-8?B?ZDJLUU45TjVxelVuei9TSUV1VkFLeENFT0lpWE5hNU9FL3FRejhIeFllTWRK?= =?utf-8?B?UEtCdTN3TW8rQUpCNjd2YWorekhYNnM4c2VMUmlYRjN2eFdaMWhjWEVwaGlZ?= =?utf-8?B?bjZNb0lBVmVlVFMyQ3JjbGJ4OVNyRFRkTTVwOG5HRXBvUVI4WGhub3FpQ3N2?= =?utf-8?B?dlA3SURJSVdwVk9lM2w3dllHWWhWeEdTRDI5bkhNbmk5N3hGRitrQXpmRllR?= =?utf-8?B?d3lvWVNUSUh5bWowMDZHQlNJcnpaRkU5dzEwNXF1cFhqSWk1Sm9UL2J3WmFG?= =?utf-8?B?dXl4VFZXODBKMnV5TEFjTHlVNGFuWlJBeVc4amZiTHB0dUQwaDViditKemJO?= =?utf-8?B?NEp4NHd3bjVpLytneEZYVTBVNnNQQVZHN2NxS1JZRTRRQ0JwSG9xVk8wU1Fw?= =?utf-8?B?YXZqd3lBWTRHZWlsd2M4NmhyNmxLR201aFlwbjFpMW1RZ2c3Rnk3ZFUwMTA4?= =?utf-8?B?MHlDN1dkcVRkMDUybXR3QjhJS3lhdy84cm5mVHVNc08yV1UvMDJhMWZ4UTRy?= =?utf-8?B?RzdXL0Z0b2FsdVJJcG00TTNnSXFvb3NrT0tHMXZGTlp5NmhHcUE2N01BWGY3?= =?utf-8?B?c3E5Vm5LaEJPK1d4UlZkRU8xdGV3WFJxYmZyaUVxQzFGa2JOUWVVVmpjUHVK?= =?utf-8?B?eThkNUlDV0FDS3NVa0RpcVB3VmYyVXpNY2hVUDVpQ2pzTEpRamx6Z0dIY042?= =?utf-8?B?VVpYK0JEb0V0V1lNbUNvU216RWt4V2d6NnRBbXVFYWZ3aXc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;6:Xc+mQXKMqF373DcBZx2Xf2hcKpe6Z2EspRVd3Al99WC1e1bZBVcaX/RqSjNix4sk2p9tDv08hPD1FVLYBfJ3UlmIhlflWMJKLXb2lIDMNBnUgOc053GW0szoKLkSEQRB7XNoc47g5L5tl/Le0sw2iDpc60SykVXDjDHnrFavV/Py0KG04ZZOf7t5jfKOHx/DdH6fDoUFoFfd4m7omOhCqFG6xTY2+avjC+BETHFwxQ2Ldf7yb1FJs69Rbounc43wMJ2dvp3MhsMeB+2mbH/Zd1bAoUwV5E+KDNSABDFj2+prxdYvc9dROHlGtDzqrfQiMecF/FdYviTxxZtnN5UEUw==;5:uTMAPhKn/RYJvm5OoLEGXZ4iMWZXBdr84Lm+mbumLtN36pYmSt9bqeD6VHqjC0rP2jSdqyi5554TCyZgw/nBCfGa2eNKziAjkhDCy1RKry4DqchmaCv9VM1mHhZlyjmD+hGR8uIiMC+CJMk4yycy9k159mbFeHL//a8SpUx52zc=;24:815DMEW2SDTSnZ5hvvFjHLiQUfYaLKKGDTflnqc81gHGN38/TUawaTgjTI3XDG/1+qu7SbQBoxG3tELmtxWJfD/rR8/zjl4IyvX+Dl/4WP4=;7:FxGrsjwgJqMCZzsMGWGSrxp5t6G6WXPHHzKg3AnwuO8R6Mgr2xiEFFVDs1QBaHOQnUrhwYYnz+JthHmr5CxO8JGas7UzKQq/v3zqEgPiGppqEh3kVJqwa7tPEwAahWkWHJpiCZm0NKWIgC/mitkh/guenDmAkkHkbxanv9iyKFH0zu4zY25zn3Ymap7OCQeTnh7duxR+0wrUJO9BdG5g9J4KuLaOBHVQEDSHvsH2DkI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:5T/0V/EAeAgHzLgJvnm22VE42k6SXw6MRYGq5OYcKxshsJGHzSFFG5qq9rfjCrlMge1aBYiF4OcLMzObMolCYfFyj0e03ITWTXwnaKb1pVL+WuqWxhdESC7IuHX9lwJaTEVhtVWml5tQAn4tznglDgGLTtI16djYaGZrqluV5hWUyHzr1ktWYHSMaR8/izDaC6sEj1DqcXBq2pwGjo0HMDeP9sOCMZTybc/1z7K2yOpjJCJwjkxGdrD7FKI7qbyZ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 17:46:31.2933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/17 11:21 AM, Borislav Petkov wrote: ... >> +static bool sev_enabled __section(.data) = false; > You need to run a patch through checkpatch everytime you change it - > sometimes the warning makes sense, like in this case: > > ERROR: do not initialise statics to false > #73: FILE: arch/x86/mm/mem_encrypt.c:45: > +static bool sev_enabled __section(.data) = false; sev_enabled lives in .data section and looking at the objdump it seems to initialized to zero. So, I think its safe to remove the initialization. Tom, Please let me know if you are okay with the changes. I will do a quick test run and update the patch.