From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id EC20AC4338F
	for <linux-kernel@archiver.kernel.org>; Mon, 23 Aug 2021 10:35:54 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id C57F46137B
	for <linux-kernel@archiver.kernel.org>; Mon, 23 Aug 2021 10:35:54 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235944AbhHWKgf (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 23 Aug 2021 06:36:35 -0400
Received: from smtprelay0216.hostedemail.com ([216.40.44.216]:42184 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S234457AbhHWKge (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Aug 2021 06:36:34 -0400
Received: from omf12.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
        by smtprelay07.hostedemail.com (Postfix) with ESMTP id B55E9181D303C;
        Mon, 23 Aug 2021 10:35:51 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id B05F5240236;
        Mon, 23 Aug 2021 10:35:50 +0000 (UTC)
Message-ID: <79330fbb1ac84c8c489c8495b4ff34cc5b446c0c.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Improve GIT_COMMIT_ID test
From:   Joe Perches <joe@perches.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Andy Whitcroft <apw@canonical.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Denis Efremov <efremov@linux.com>, linux-kernel@vger.kernel.org
Date:   Mon, 23 Aug 2021 03:35:48 -0700
In-Reply-To: <20210822150354.3c0dcb7d7e8fefaa856383e5@linux-foundation.org>
References: <976c6cdd680db4b55ae31b5fc2d1779da5c0dc66.camel@perches.com>
         <20210822150354.3c0dcb7d7e8fefaa856383e5@linux-foundation.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Rspamd-Server: rspamout01
X-Rspamd-Queue-Id: B05F5240236
X-Stat-Signature: hy3xswbcspexwypsop7p5tdc4gi53f4i
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX1+Y50qveyWsyKLkH9KfzT5LaPtuz4EwODQ=
X-HE-Tag: 1629714950-901393
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2021-08-22 at 15:03 -0700, Andrew Morton wrote:
> On Fri, 20 Aug 2021 14:46:51 -0700 Joe Perches <joe@perches.com> wrote:
> 
> > +		if ($perl_version_ok
> > +		    $in_commit_log && !$commit_log_possible_stack_dump &&
> 
> Needs &&.   Was the correct version sent?

Yes, but I stuffed up the && around the perl_version_ok test
I added at the last minute.

oops.