Re: [PATCH] platform/x86: bitland-mifs-wmi: Add Xiaomi Book Pro 14 platform profile values

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 9007 bytes --]

On Mon, 28 Sep 2026, Chris Taraszka wrote:

> Thanks, makes sense.
> 
> Matias, one thing I ran into when trying your generic part on the
> Xiaomi Book Pro 14: its values are sparse (0x02, 0x03, 0x04, 0x09,
> 0x0a) and 0x02 and 0x0a both mean low-power. With a profile array
> indexed by the firmware value, the unused slots read back as
> PLATFORM_PROFILE_LOW_POWER (0), and the reverse lookup for low-power
> finds index 0, which this firmware ignores.
> 
> So I'd suggest {value, profile} pairs for the shared part. I have that
> as a standalone patch on pdx86/for-next, with only the profile table
> in the quirk struct, so your response layout and AC check handling
> would go on top in your TM2107 patch. If that works for you I'll send
> it as v2 together with the Xiaomi entry, and you can base your v3 on
> it. If you'd rather own the generic patch, that's fine too, I'll
> rebase the Xiaomi part on yours.

Hi,

I've not seen v2 so far, has there been some progress with this?

(Not having the generalization seems a blocker adding many models.)

--
 i.

> On Mon, Sep 28, 2026 at 5:49 PM Ilpo Järvinen
> <ilpo.jarvinen@linux.intel.com> wrote:
> >
> > On Mon, 28 Sep 2026, Chris Taraszka wrote:
> >
> > > The Xiaomi Book Pro 14 firmware (BIOS XMAPT4B0P0909) implements
> > > SystemPerMode with its own values. Its WMAA SET handler only acts on
> > > 0x02-0x0a and silently ignores 0 and 1, and GET returns one of 0x02,
> > > 0x03, 0x04, 0x09 or 0x0a. With the generic values:
> > >
> > >  - balanced (0) and balanced-performance (1) are no-ops,
> > >  - performance (3) selects the firmware's balanced mode,
> > >  - reading the profile fails with -EINVAL whenever the firmware is in
> > >    0x04, 0x09 or 0x0a, which it often is after boot. The failed read also
> > >    makes bitland_mifs_wmi_suspend() abort system suspend.
> > >
> > > The values were identified from the WMAA method in the firmware's SSDT
> > > and by setting each one through WMAA on AC and reading the resulting
> > > sustained package power limit from intel-rapl-mmio:
> > >
> > >   0x02  18 W  (quiet)
> > >   0x03  37 W  (balanced)
> > >   0x09  45 W
> > >   0x04  58 W  (performance)
> > >   0x0a  18 W
> > >
> > > Map low-power, balanced, balanced-performance and performance to 0x02,
> > > 0x03, 0x09 and 0x04 on this model. The driver never sets 0x0a, which is
> > > only reached through the firmware's own mode cycling, so report it as
> > > low-power.
> > >
> > > Cc: Armin Wolf <W_Armin@gmx.de>
> > > Cc: Mingyou Chen <qby140326@gmail.com>
> > > Signed-off-by: Chris Taraszka <chris@miget.com>
> > > ---
> > >
> > > Notes:
> > >     Tested on the Xiaomi Book Pro 14 on AC with bitland-mifs-wmi from pdx86
> > >     for-next plus this patch, loaded on v7.3-rc5: all four profiles apply
> > >     through power-profiles-daemon and the firmware mode and PL1 follow
> > >     (0x03/37 W, 0x02/25 W, 0x04/56 W). The same mapping on v7.3-rc4/rc5
> > >     without the for-next changes was also tested on battery and across
> > >     s2idle suspend/resume, with the profile restored on resume.
> > >
> > >     This explains the -EINVAL behind my earlier "platform/x86:
> > >     bitland-mifs-wmi: Don't abort suspend when platform profile access
> > >     fails" (sent 2026-09-11): the profile read failed because of the unknown
> > >     mode values. That patch is still useful as a safety net.
> > >
> > >     Note that on for-next each profile change still reports -ENOMSG even
> > >     though the firmware applies it: this firmware's SET handlers leave the
> > >     function id in the response at 0, which 23cc56f6dea6 ("platform/x86:
> > >     bitland-mifs-wmi: Detect failed function calls") rejects. I'll send a
> > >     separate fix for that.
> > >
> > >  drivers/platform/x86/bitland-mifs-wmi.c | 56 +++++++++++++++++++++++--
> > >  1 file changed, 52 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c
> > > index dd1648b7de77..4a8e5b4e7853 100644
> > > --- a/drivers/platform/x86/bitland-mifs-wmi.c
> > > +++ b/drivers/platform/x86/bitland-mifs-wmi.c
> > > @@ -14,6 +14,7 @@
> > >  #include <linux/dev_printk.h>
> > >  #include <linux/device.h>
> > >  #include <linux/device/devres.h>
> > > +#include <linux/dmi.h>
> > >  #include <linux/err.h>
> > >  #include <linux/hwmon.h>
> > >  #include <linux/init.h>
> > > @@ -79,6 +80,29 @@ enum bitland_mifs_power_profile {
> > >       WMI_PP_FULL_SPEED       = 3,
> > >  };
> > >
> > > +/*
> > > + * The Xiaomi Book Pro 14 firmware uses its own SystemPerMode values and
> > > + * ignores the ones above. Sustained package power limits (PL1) measured
> > > + * on AC are noted next to each mode.
> > > + */
> > > +enum bitland_mifs_xiaomi_power_profile {
> > > +     WMI_PP_XIAOMI_QUIET             = 0x02, /* 18 W */
> > > +     WMI_PP_XIAOMI_BALANCED          = 0x03, /* 37 W */
> > > +     WMI_PP_XIAOMI_PERFORMANCE       = 0x04, /* 58 W */
> > > +     WMI_PP_XIAOMI_SMART             = 0x09, /* 45 W */
> > > +     WMI_PP_XIAOMI_QUIET_ALT         = 0x0a, /* 18 W */
> > > +};
> > > +
> > > +static const struct dmi_system_id bitland_mifs_xiaomi_pp_dmi_table[] = {
> > > +     {
> > > +             .matches = {
> > > +                     DMI_MATCH(DMI_SYS_VENDOR, "XIAOMI"),
> > > +                     DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14"),
> > > +             },
> > > +     },
> > > +     { }
> > > +};
> > > +
> > >  enum bitland_mifs_event_id {
> > >       WMI_EVENT_RESERVED_1            = 1,
> > >       WMI_EVENT_RESERVED_2            = 2,
> > > @@ -161,6 +185,7 @@ struct bitland_mifs_wmi_data {
> > >       struct device *hwmon_dev;
> > >       struct device *pp_dev;
> > >       enum platform_profile_option saved_profile;
> > > +     bool xiaomi_pp;
> > >  };
> > >
> > >  static int bitland_mifs_wmi_call(struct bitland_mifs_wmi_data *data,
> > > @@ -213,6 +238,27 @@ static int laptop_profile_get(struct device *dev,
> > >       if (ret)
> > >               return ret;
> > >
> > > +     if (data->xiaomi_pp) {
> > > +             switch (result.data[0]) {
> > > +             case WMI_PP_XIAOMI_QUIET:
> > > +             case WMI_PP_XIAOMI_QUIET_ALT:
> > > +                     *profile = PLATFORM_PROFILE_LOW_POWER;
> > > +                     break;
> > > +             case WMI_PP_XIAOMI_BALANCED:
> > > +                     *profile = PLATFORM_PROFILE_BALANCED;
> > > +                     break;
> > > +             case WMI_PP_XIAOMI_SMART:
> > > +                     *profile = PLATFORM_PROFILE_BALANCED_PERFORMANCE;
> > > +                     break;
> > > +             case WMI_PP_XIAOMI_PERFORMANCE:
> > > +                     *profile = PLATFORM_PROFILE_PERFORMANCE;
> > > +                     break;
> > > +             default:
> > > +                     return -EINVAL;
> > > +             }
> > > +             return 0;
> > > +     }
> > > +
> > >       switch (result.data[0]) {
> > >       case WMI_PP_BALANCED:
> > >               *profile = PLATFORM_PROFILE_BALANCED;
> > > @@ -272,22 +318,22 @@ static int laptop_profile_set(struct device *dev,
> > >
> > >       switch (profile) {
> > >       case PLATFORM_PROFILE_LOW_POWER:
> > > -             val = WMI_PP_QUIET;
> > > +             val = data->xiaomi_pp ? WMI_PP_XIAOMI_QUIET : WMI_PP_QUIET;
> > >               break;
> > >       case PLATFORM_PROFILE_BALANCED:
> > > -             val = WMI_PP_BALANCED;
> > > +             val = data->xiaomi_pp ? WMI_PP_XIAOMI_BALANCED : WMI_PP_BALANCED;
> > >               break;
> > >       case PLATFORM_PROFILE_BALANCED_PERFORMANCE:
> > >               ret = bitland_check_performance_capability(data);
> > >               if (ret)
> > >                       return ret;
> > > -             val = WMI_PP_PERFORMANCE;
> > > +             val = data->xiaomi_pp ? WMI_PP_XIAOMI_SMART : WMI_PP_PERFORMANCE;
> > >               break;
> > >       case PLATFORM_PROFILE_PERFORMANCE:
> > >               ret = bitland_check_performance_capability(data);
> > >               if (ret)
> > >                       return ret;
> > > -             val = WMI_PP_FULL_SPEED;
> > > +             val = data->xiaomi_pp ? WMI_PP_XIAOMI_PERFORMANCE : WMI_PP_FULL_SPEED;
> >
> >
> > Hi,
> >
> > Thanks for the patch but I won't accept device specific conditionals like
> > this done in the code. For a better approach, please see:
> >
> > bitland-mifs-wmi: Fix TM2107 profile handling
> >
> > You two could try to coordinate such that transition into the generic
> > approach is not worked by both independently.
> >
> > It might be best to extract the generalization part to own patch and both
> > then base their respective device specific patches adding new things on
> > top of that.
> >
> > --
> >  i.
> >
> 

-- 
 i.