From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0A535838C for ; Mon, 9 Mar 2026 08:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773043704; cv=none; b=R03o9vGDkIi1/glxZOJcqaJ+VHHWMX/pjV1VMRgGxKGp7JsfKePjkB7A4m+s5vXloaKBrMBfBFJgX99eMTOkdG+qz0F+ICYQD3Ut1u/U7yn9agGI5ALti6PjxLzii8Nqb6BuUYHlQr6LukZmCY1l0XM7bm0kHSAjPtOsystzzbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773043704; c=relaxed/simple; bh=ixQ+eE30o6EZuinsahz/N2oeZ8XJodVeA30phCWsMo8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ddi6H9iOH1LZ9SN+qSYQwxGh2Sm8snGCOQp9o7CcBG7pCLG2oypPNiLxPnK8//oYogohDP/u2ONb11Ag3ZfnpA5wKwYxKm+R6Aj41HUuG60bqNezkCNvMyYEaRtce0ml7wWX50n01i8P2KAYqT8Ro46pDKY3efyXCO29MIsB4dA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Wc5lckVq; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=e35VI6N6; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Wc5lckVq; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=e35VI6N6; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Wc5lckVq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="e35VI6N6"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Wc5lckVq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="e35VI6N6" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 76C775BE17; Mon, 9 Mar 2026 08:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773043701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ogb2IB1Q2p2DeUyYklDfAYMMP5kLmo+OtwtAWoKHnco=; b=Wc5lckVqF0ZbqzAaca4wFPEFVJye7bsAOfalIGPvRKZHAmfGFHWcTrIwrzkBNIHvpYT5dX yQ5MGpR7VMkf6aXZlyT0GrpsE0vZnMqCmmeerg2lhRZFbssIfEClnPGLyIdc8b+CO6+7r3 2FAlS/iHoqmc9Ev0khFtZcipB3CQltA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773043701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ogb2IB1Q2p2DeUyYklDfAYMMP5kLmo+OtwtAWoKHnco=; b=e35VI6N6lFaj38uqM+THxMUmDRZZ88QyrZahLVFKoC0P1ykQxj2CZLK4rtWTqES4RpLk2L daydCQkEBOKHqxCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Wc5lckVq; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=e35VI6N6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773043701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ogb2IB1Q2p2DeUyYklDfAYMMP5kLmo+OtwtAWoKHnco=; b=Wc5lckVqF0ZbqzAaca4wFPEFVJye7bsAOfalIGPvRKZHAmfGFHWcTrIwrzkBNIHvpYT5dX yQ5MGpR7VMkf6aXZlyT0GrpsE0vZnMqCmmeerg2lhRZFbssIfEClnPGLyIdc8b+CO6+7r3 2FAlS/iHoqmc9Ev0khFtZcipB3CQltA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773043701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ogb2IB1Q2p2DeUyYklDfAYMMP5kLmo+OtwtAWoKHnco=; b=e35VI6N6lFaj38uqM+THxMUmDRZZ88QyrZahLVFKoC0P1ykQxj2CZLK4rtWTqES4RpLk2L daydCQkEBOKHqxCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 38B7C3EDC8; Mon, 9 Mar 2026 08:08:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yPdpDPV/rmkzEQAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 08:08:21 +0000 Message-ID: <793a35dc-0f0a-4bf2-84cd-8a6f56ac2a66@suse.de> Date: Mon, 9 Mar 2026 09:08:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/loongson: use drm_gem_ttm_dumb_map_offset() To: Amin GATTOUT , Sui Jingfeng , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260308-master-v1-1-af32d71c8a1d@gmail.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260308-master-v1-1-af32d71c8a1d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[gmail.com,loongson.cn,linux.intel.com,kernel.org,ffwll.ch]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_RCPT(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,suse.com:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 76C775BE17 Hi, thanks for the patch., Am 08.03.26 um 11:15 schrieb Amin GATTOUT: > Replace the open-coded lsdc_dumb_map_offset() with the generic > drm_gem_ttm_dumb_map_offset() helper, which is functionally identical. > This removes unnecessary boilerplate and aligns with the DRM convention > for TTM-based drivers. > > Signed-off-by: Amin GATTOUT Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/loongson/lsdc_drv.c | 3 ++- > drivers/gpu/drm/loongson/lsdc_gem.c | 15 --------------- > drivers/gpu/drm/loongson/lsdc_gem.h | 4 ---- > 3 files changed, 2 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/loongson/lsdc_drv.c b/drivers/gpu/drm/loongson/lsdc_drv.c > index abf5bf68eec2..1ece1ea42f78 100644 > --- a/drivers/gpu/drm/loongson/lsdc_drv.c > +++ b/drivers/gpu/drm/loongson/lsdc_drv.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -45,7 +46,7 @@ static const struct drm_driver lsdc_drm_driver = { > > .debugfs_init = lsdc_debugfs_init, > .dumb_create = lsdc_dumb_create, > - .dumb_map_offset = lsdc_dumb_map_offset, > + .dumb_map_offset = drm_gem_ttm_dumb_map_offset, > .gem_prime_import_sg_table = lsdc_prime_import_sg_table, > DRM_FBDEV_TTM_DRIVER_OPS, > }; > diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson/lsdc_gem.c > index 6372db2d3093..2fb03487c983 100644 > --- a/drivers/gpu/drm/loongson/lsdc_gem.c > +++ b/drivers/gpu/drm/loongson/lsdc_gem.c > @@ -234,21 +234,6 @@ int lsdc_dumb_create(struct drm_file *file, struct drm_device *ddev, > return 0; > } > > -int lsdc_dumb_map_offset(struct drm_file *filp, struct drm_device *ddev, > - u32 handle, uint64_t *offset) > -{ > - struct drm_gem_object *gobj; > - > - gobj = drm_gem_object_lookup(filp, handle); > - if (!gobj) > - return -ENOENT; > - > - *offset = drm_vma_node_offset_addr(&gobj->vma_node); > - > - drm_gem_object_put(gobj); > - > - return 0; > -} > > void lsdc_gem_init(struct drm_device *ddev) > { > diff --git a/drivers/gpu/drm/loongson/lsdc_gem.h b/drivers/gpu/drm/loongson/lsdc_gem.h > index 92cbb10e6e13..96729b3eebec 100644 > --- a/drivers/gpu/drm/loongson/lsdc_gem.h > +++ b/drivers/gpu/drm/loongson/lsdc_gem.h > @@ -14,10 +14,6 @@ lsdc_prime_import_sg_table(struct drm_device *ddev, > struct dma_buf_attachment *attach, > struct sg_table *sg); > > -int lsdc_dumb_map_offset(struct drm_file *file, > - struct drm_device *dev, > - u32 handle, > - uint64_t *offset); > > int lsdc_dumb_create(struct drm_file *file, > struct drm_device *ddev, > > --- > base-commit: c23719abc3308df7ed3ad35650ad211fb2d2003d > change-id: 20260308-master-58f0cb492c5e > > Best regards, -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)