From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29F2F132111 for ; Tue, 7 Jan 2025 18:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736274688; cv=none; b=lvb63A+KHZSwrWZGu174rbPh9FQjDTgt9jcJ2jcEmReoRsidYRitYfAhOKJSibqRAPacWQfUVNzvG/MslcI/4l5seECfdjIh/yiLWlCwqcCSy22SIMgbJIa7ZVaE4Wp5x0K3C7vYwJ8PH///E6KkZAysQndRHKlNuKgs9V55lw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736274688; c=relaxed/simple; bh=xAwZKu9WLa+rI7IdUw+F6xiKiYLPFDR6xxH5P95xIQQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qzgwY+KLy7Vdplx5ubKP9LyTXRCBkNCj37lPV/zLU7L0u8CCc4R9Xl2ZzA8Px7A1E9sECGbiT1BOPAKA+wRGH9x9gSHArnFDsQZAuo/jOXzg5gHjHGpq6HhhJa0Y6xlyojMRRTQigAQx5hnJZGyICSytYKdd5fAvkr/iAJX/GDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=kAMqoCie; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="kAMqoCie" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 507I4CaO005017; Tue, 7 Jan 2025 18:30:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=A31BetjQEODZRhrYfLMp5lFHSZiD4MYOgqz/iQHRzxo=; b=kAMqoCie9NI4 9x+YxuAzKy44Ytx4mIzZSSjo4B36GkNYuNIeURf4QbWR/FwzDtsGhlS2fi6eicXw dQtYqXh4K4XDcFTtR4j7IkmiCh23iYs0xlCs8DC2fE1zAA3IYYgREcvedKEO1kFM UPaxFlFZzmuq5CJqHz1/YutubYkjQVZWiGUs4eBbPw/0Gsyc5/5WkeXzLCXY7g9l wc9ElEcpuYmsIsYvi3yi/bqx7Zk5jE1BkxH6Up8IjULFKB+3TXVTIWWj+rGXNZn2 4T1Kxc7L2/AOKqK2HRcjVLcNtyyzx5Kg3IE7Umi45QwxxIFsdl7uHQR6cclqi0N4 90jQp6Oeew== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 440sahmmu5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 18:30:25 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 507ITQg2027322; Tue, 7 Jan 2025 18:30:25 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 440sahmmu0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 18:30:25 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 507GQPe4008869; Tue, 7 Jan 2025 18:30:23 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43yfpyv0tk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 18:30:23 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 507IUMRX64487880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jan 2025 18:30:23 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D17F35805F; Tue, 7 Jan 2025 18:30:22 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 96E9F58056; Tue, 7 Jan 2025 18:30:17 +0000 (GMT) Received: from [9.43.76.251] (unknown [9.43.76.251]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Jan 2025 18:30:17 +0000 (GMT) Message-ID: <7941d5e5-e96a-4356-b5e7-8e61f89d2748@linux.ibm.com> Date: Wed, 8 Jan 2025 00:00:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] sched/fair: Ignore isolated cpus in update_numa_stat Content-Language: en-US To: Chuyi Zhou Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, longman@redhat.com, riel@surriel.com, chengming.zhou@linux.dev, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org, Madadi Vineeth Reddy References: <20250103065930.413464-1-zhouchuyi@bytedance.com> <20250103065930.413464-3-zhouchuyi@bytedance.com> <080a07db-eb8a-4148-9ca1-2e047cab2569@bytedance.com> From: Madadi Vineeth Reddy Reply-To: 080a07db-eb8a-4148-9ca1-2e047cab2569@bytedance.com In-Reply-To: <080a07db-eb8a-4148-9ca1-2e047cab2569@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: WSBc-L0BBAEMb_ZRgK7_CAmfFRp8Idzb X-Proofpoint-ORIG-GUID: i7CVk8z5mt0o7-4gNKk9qnCDOH6_0MRu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 spamscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501070153 On 07/01/25 18:46, Chuyi Zhou wrote: > Hello Madadi Vineeth Reddy, > > 在 2025/1/6 02:52, Madadi Vineeth Reddy 写道: >> On 03/01/25 12:29, Chuyi Zhou wrote: >>> Now update_numa_stats() iterates each cpu in a node to gather load >>> information for the node and attempts to find the idle cpu as a candidate >>> best_cpu within the node. >>> >>> In update_numa_stats() we should take into account the scheduling domain. >>> This is because the "isolcpus" kernel command line option and cpuset iso- >>> late partitions can remove CPUs from load balance. Similar to task wakeup >>> and periodic load balancing, we should not involve isolated CPUs in NUMA >>> balancing. When gathering load information for nodes, we need to ignore the >>> load of isolated CPUs. This change also avoids selecting an isolated CPU >>> as the idle_cpu. >> >> If possible, would you be able to share any performance metrics or benchmarks >> that demonstrate the impact of this patch on NUMA balancing or CPU migration >> efficiency? >> >> Thanks, >> Madadi Vineeth Reddy >> > > This change will not alter the default behavior of NUMA balancing unless we enables both NUMA balancing and isolated CPUs features. Therefore, under normal default conditions, there should be no performance regression. On the other hand, involving isolated CPUs in NUMA balancing or load balancing is inappropriate, and this is the issue that this patch aims to fix. > > It might be worth setting up a test scenario for cases where NUMA balancing and isolated CPUs are both enabled. Perhaps this testing will be done later on. Right, by benchmark, I meant the scenario where both NUMA balancing and isolated CPUs are involved. It would make for an interesting test case. Thanks, Madadi Vineeth Reddy > > Thanks.