From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB6F229BD89 for ; Tue, 2 Sep 2025 13:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756818645; cv=none; b=hfAhVo7oN2ld2eQ0EjTTUd1sKaS5T7uGLzwhisKs93crDYcHuGNLT68uB68cDkhHpodnCHIGKRhkkSuB96qPcNDX69W81x6gG2UKw4vGaQMayfAwkNazRp8KU+4+mhK1kKoHsNoj9p1K3AtIMp8A0AiU1XgxTq2BVvSgGo6NGAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756818645; c=relaxed/simple; bh=k6+dHn40QNMMOFNkt0GnZ5cvVVODfmPyn2V4WNddqrc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=is+v2lvv1ybK4g0Txrglo6pG4hGnN/GyWhpaI/aGfzn8mvEvjd1HSifHz/LNzHyrmiEzGG/xzGczrK0XZ771qRxz66kpIkcDk19jOBh26/QiEY22F9RKTXiz5LkQVhq2SJ6Ye231QCeB+Kd4jbBaud9OMcZCgGgERmt5I7PWLx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gHu0U1dm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gHu0U1dm" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 582AVe74032487 for ; Tue, 2 Sep 2025 13:10:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TCcA+aEJtftBpa2OufUrueWE59LMYXUTL4dnnFoQBO0=; b=gHu0U1dmKiKCTqBD u7J4gqMech7tkepGDJJo7quoIkhi5tuFLZzWHgNqeVdxqpwB7MN4xSEUAiNlOKc7 zAp2cZfmonRXoeUi4WwcjzV6GM6t3iA0YYsuMcO90XEqRz9IEPe14RAkSxSFhkKY 5g3W8poZghfkOR9HLBawJsZ2+k4F4gOo5vcCPctK21XIocKkein92K+6B2PjZiEY vf+ONokvRsl4/WIFpEVRgv4zzQGVhce7jQ/YDETpDnmeNqScZgPioZxNkX+tpBW0 S9nr6zkwMKDiJsm8y8fRyLT5+hsE+6G7wy15aYMHnp3sHiFF9aQXtw1ERqHsuIs1 a/+zBQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48wqvw9kna-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 13:10:42 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-24afab6d4a7so20864025ad.1 for ; Tue, 02 Sep 2025 06:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756818642; x=1757423442; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TCcA+aEJtftBpa2OufUrueWE59LMYXUTL4dnnFoQBO0=; b=s5ZQife9BnSBASHuFP/Y4gc5BOrh5vyrx+eQj335RsMExMS/VMCU2wdxotQcB2w7mU 8RUPZIW81iW9s+ytzeEWY0dk0WQjEkgKAx8t1+isqBT7T//ic4pi62vnXtktCdsH2Z3l xk5i3gxEXPmIHRgUIjPYVMrDj3FoMXbWt7L48+zYejfWgFvB8raWryE2YU+b233ZvKXt AlNhNAwUJTHSIxVJIl698APMs3gtlVtavBnOCIJOXKDBHRJ+D/mnuIZAkbRJ7wbkJm8Y PjtD15AHiIy728on7yePthiyw0mSIuykkiuMcvQ5QhIsjiyE51M7KulgotIXh2mOk2uf oNdQ== X-Forwarded-Encrypted: i=1; AJvYcCWwpnxFNSnOes3qEBVfQjCU8otHZ0oN+yvwhaJAv3ukSzy97SsPEtHrvnkLum+hqci7NGJQQT7cRY5hTsI=@vger.kernel.org X-Gm-Message-State: AOJu0YwOJGspzwepjF+Yh6/b7V3rJ5uJjqTb4TIuj1MziRpsEZ4JiEsd qyhfmlJI408mmF31XiCO1g1wp+fpXpj7cKTgNTTLLEniQy/dpw6tm4uH0aQQTXeLzcOIjcBJrpJ EczMuPZQ1ok5ky0jnDh/QYVvHEsI3BmeFqW08Kma79Sh2qGSH8XUT/+ESkYvPMjOl480= X-Gm-Gg: ASbGncuZQzlHmWKDig3O1e7CH9z7D7/9vxPeFBevnMnjRjZZi0EzkA3l18P0J22CoNC +YZKKTuZ4oqWcchX/kV9POqt/VfzrdTOaEYbPmFFxGDKSNNXFxP8/OWZYTOO/LQaSFrauXzswbB y/7Jx6EzZQyzRcBA0gkpOVdx/kqUz9JFnruplkcHVi2y4mbuUlK5VImGEUAtCqHR8MmBRNrVSaG kXCDyZ9OFyBgHtN4oX8hTiZH2URr4X5IOt6LY2Rp+Kay+X1xO7XfmzXOtsTf7WiGxkFG3WkDkr2 j08L+XEu1Xrr/6VpFq+aDpL8ZPtJulyIHzLoboKxj2HxuuoMi4EDczzWoWtj20HcYPcaLUDv X-Received: by 2002:a17:903:2383:b0:246:570:2d9a with SMTP id d9443c01a7336-24944b1fc6emr155608545ad.59.1756818641662; Tue, 02 Sep 2025 06:10:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+ZJLr+Tf5Vmoqn+FE9bXrBZCyCNL2ukTMmTiw09eW+UDgXgNsnXvoUOcF4YrOwiO7rbplQA== X-Received: by 2002:a17:903:2383:b0:246:570:2d9a with SMTP id d9443c01a7336-24944b1fc6emr155607855ad.59.1756818641095; Tue, 02 Sep 2025 06:10:41 -0700 (PDT) Received: from [10.216.7.97] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2490f755ebdsm128599375ad.26.2025.09.02.06.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 06:10:40 -0700 (PDT) Message-ID: <7941da77-06bb-a2d3-c2fa-ad2fba54b4a1@oss.qualcomm.com> Date: Tue, 2 Sep 2025 18:40:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v14 00/10] Implement vendor resets for PSCI SYSTEM_RESET2 To: Kathiravan Thirumoorthy , Bartosz Golaszewski , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Conor Dooley , Andy Yan , Mark Rutland , Lorenzo Pieralisi , Arnd Bergmann , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Vinod Koul , Catalin Marinas , Will Deacon , Florian Fainelli Cc: Dmitry Baryshkov , Mukesh Ojha , Stephen Boyd , Andre Draszik , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Elliot Berman , Srinivas Kandagatla , Elliot Berman , Konrad Dybcio References: <20250815-arm-psci-system_reset2-vendor-reboots-v14-0-37d29f59ac9a@oss.qualcomm.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAyMDAyNCBTYWx0ZWRfX/OPKzOC48IGO qzWlypzf60qGjIw2ohl5ZtdiscJDkji3tLh4EnAx/Md0qFQkVP2nRvBtIWG3fbBYtslbKH2k6sN NXkBXM8q8Xq7JtaokzAxWXEJWJypwFXDZFctVehH3afKFJOxIUAfijOeReP5LaehsJXxSTPj1Ab NVZJDPAXmJ/A6ANlsZVV4eTIEl1N0PklE2b9PAMq2MUam3C1zTLrBbSacERM9V6KnCWKZGkctND mONDTKYRKfvCcG7ayvLVuEwN58XVV/elSMapl7B4adBdq235gWyiI62qXzm9iCJDHwIwD+BbrdZ Ld20VIPKJW2SGSZ/1XjYJo7ARLmb2fmka5DbverETZhcgnx0XzzBpjh0ThrY97yVcz+Prsx45hu CW6mP0T/ X-Authority-Analysis: v=2.4 cv=WKh/XmsR c=1 sm=1 tr=0 ts=68b6ecd2 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=YbM9Y6cvHUstxk9peq8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: f5q46-cnboTWzyBW73AgtNnkIMZUvu9l X-Proofpoint-ORIG-GUID: f5q46-cnboTWzyBW73AgtNnkIMZUvu9l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_04,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509020024 On 8/28/2025 1:35 PM, Kathiravan Thirumoorthy wrote: > > On 8/15/2025 8:05 PM, Shivendra Pratap wrote: >> The PSCI SYSTEM_RESET2 call allows vendor firmware to define >> additional reset types which could be mapped to the reboot >> argument. >> >> User-space should be able to reboot a device into different >> operational boot-states supported by underlying bootloader and >> firmware. Generally, some HW registers need to be written, based >> on which the bootloader and firmware decide the next boot state >> of device, after the reset. For example, a requirement on >> Qualcomm platforms may state that reboot with "bootloader" >> command, should reboot the device into bootloader flashing mode >> and reboot with “edl” command, should reboot the device into an >> Emergency flashing mode.  Setting up such reboots on Qualcomm >> devices can be inconsistent across SoC platforms and may require >> setting different HW registers, where some of these registers may >> not be accessible to HLOS. These knobs evolve over product >> generations and require more drivers.  PSCI defines a >> vendor-specific reset in SYSTEM_RESET2 spec, which enables the >> firmware to take care of underlying setting for any such >> supported vendor-specific reboot. Qualcomm firmwares are >> beginning to support and expose PSCI SYSTEM_RESET2 >> vendor-specific reset types to simplify driver requirements from >> Linux. With such support added in the firmware, we now need a >> Linux interface which can make use of the firmware calls for PSCI >> vendor-specific resets. This will align such reboot requirement >> across platforms and vendors. >> >> The current psci driver supports two types of resets – >> SYSTEM_RESET2 Arch warm-reset and SYSTEM_RESET cold-reset. The >> patchset introduces the PSCI SYSTEM_RESET2 vendor-specific reset >> into the reset path of the psci driver and aligns it to work with >> reboot system call - LINUX_REBOOT_CMD_RESTART2, when used along >> with a supported string-based command in “*arg”. >> >> The patchset uses reboot-mode based commands, to define the >> supported vendor reset-types commands in psci device tree node >> and registers these commands with the reboot-mode framework. >> >> The PSCI vendor-specific reset takes two arguments, being, >> reset_type and cookie as defined by the spec. To accommodate this >> requirement, enhance the reboot-mode framework to support two >> 32-bit arguments by switching to 64-bit magic values. >> >> Along this line, the patchset also extends the reboot-mode >> framework to add a non-device-based registration function, which >> will allow drivers to register using device tree node, while >> keeping backward compatibility for existing users of reboot-mode. >> This will enable psci driver to register for reboot-mode and >> implement a write function, which will save the magic and then >> use it in psci reset path to make a vendor-specific reset call >> into the firmware. In addition, the patchset will expose a sysfs >> entry interface within reboot-mode which can be used by userspace >> to view the supported reboot-mode commands. >> >> The list of vendor-specific reset commands remains open due to >> divergent requirements across vendors, but this can be >> streamlined and standardized through dedicated device tree >> bindings. >> >> Currently three drivers register with reboot-mode framework - >> syscon-reboot-mode, nvmem-reboot-mode and qcom-pon. Consolidated >> list of commands currently added across various vendor DTs: >>   mode-loader >>   mode-normal >>   mode-bootloader >>   mode-charge >>   mode-fastboot >>   mode-reboot-ab-update >>   mode-recovery >>   mode-rescue >>   mode-shutdown-thermal >>   mode-shutdown-thermal-battery >> >> On gs101 we also pass kernel-generated modes from kernel_restart() >> or panic(), specifically DM verity's 'dm-verity device corrupted': >>     mode-dm-verity-device-corrupted = <0x50>; >> >> - thanks Andre' for providing this. >> >> Detailed list of commands being used by syscon-reboot-mode: >>      arm64/boot/dts/exynos/exynosautov9.dtsi: >>     mode-bootloader = ; >>     mode-fastboot = ; >>     mode-recovery = ; >> >>      arm64/boot/dts/exynos/google/gs101.dtsi: >>          mode-bootloader = <0xfc>; >>          mode-charge = <0x0a>; >>          mode-fastboot = <0xfa>; >>          mode-reboot-ab-update = <0x52>; >>          mode-recovery = <0xff>; >>          mode-rescue = <0xf9>; >>          mode-shutdown-thermal = <0x51>; >>          mode-shutdown-thermal-battery = <0x51>; >> >>      arm64/boot/dts/hisilicon/hi3660-hikey960.dts: >>          mode-normal = <0x77665501>; >>          mode-bootloader = <0x77665500>; >>          mode-recovery = <0x77665502>; >> >>      arm64/boot/dts/hisilicon/hi6220-hikey.dts: >>          mode-normal = <0x77665501>; >>          mode-bootloader = <0x77665500>; >>          mode-recovery = <0x77665502>; >> >>      arm64/boot/dts/rockchip/px30.dtsi: >>          mode-bootloader = ; >>          mode-fastboot = ; >>          mode-loader = ; >>          mode-normal = ; >>          mode-recovery = ; >> >>      arm64/boot/dts/rockchip/rk3308.dtsi: >>          mode-bootloader = ; >>          mode-loader = ; >>          mode-normal = ; >>          mode-recovery = ; >>          mode-fastboot = ; >> >>      arm64/boot/dts/rockchip/rk3566-lckfb-tspi.dts: >>          mode-normal = ; >>          mode-loader = ; >>             mode-recovery = ; >>             mode-bootloader = ; >> >> Detailed list of commands being used by nvmem-reboot-mode: >>      arm64/boot/dts/qcom/pmXXXX.dtsi:(multiple qcom DTs) >>             mode-recovery = <0x01>; >>             mode-bootloader = <0x02>; >> >> Previous discussions around SYSTEM_RESET2: >> -https://lore.kernel.org/lkml/20230724223057.1208122-2-quic_eberman@quicinc.com/T/ >> -https://lore.kernel.org/all/4a679542-b48d-7e11-f33a-63535a5c68cb@quicinc.com/ >> >> Signed-off-by: Elliot Berman >> Signed-off-by: Shivendra Pratap > > > With this series, 'edl' mode is working fine in QCOM's IPQ5424 SoC. So > > Tested-by: Kathiravan Thirumoorthy # IPQ5424-RDP466 > Thanks for giving time for testing this series for IPQ5424. So we have PSCI SYS reset2 support for IPQ5424 firmware? and did we make any extra changes in DT for edl mode? thanks, Shivendra