From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9310421D5AA for ; Fri, 26 Dec 2025 18:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766772033; cv=none; b=g6/8q2Ews70dwbS0Q9AfLQKscpRTCz+7I/t6QSOquAdJ10QCdY7uMMIHNhK55s1NbjEI2GVp5NmB0CIH4khxJkoFCoiJnvcaG0zui6lOmcFc7r+wce4hUa+FF+ICkY3MXASXvyHDha/BWnqSAyybUZu+FGKvfmYtUo12jHpmy6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766772033; c=relaxed/simple; bh=Tw0hpYujlg+lIGxFPAT+vDw7Mbm9lvuZ7L8uDeKIUek=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jj/ObLZ8rqhwZq5tmBvSi3R/DbSs9YE3jrWNSPLnH14PVhCjVITb+GbgmXvTDy1t7fl9urLV8fxrJBw+pjAVDyoewZzdSgiwrDsyI1p0kQwIiw404U9bbc0HGvCQZDc/ONNLDy4uEMX46HkLno6ca5lP+NM4KQRtInfED5wMsVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nH3IY2Pu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GEkDKG+l; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nH3IY2Pu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GEkDKG+l" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BQGI7aB2223156 for ; Fri, 26 Dec 2025 18:00:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tMuB0hXI/5B2GptpbNmP+iRFf5l17u1VGLcI/EUuwcQ=; b=nH3IY2PurkfMMKbt fH4fDw1dbuLFkvjZZf4bn9LlAEFebd8WY2/4zGVV0Yy33nSmjl4daGtDZ3A8cMGf 0u4l5vXVHsqKUai9o9AcMQr2ZZwQhOcIndgDGl89HlVfzS7oxTAANYmYzDrU5gOa O+WkQqgYbKeaPRgag1bExCo1Xl8UtPsgeuiHqC3EpeMzyLjBILRQ/A2/XEEWvdUZ iNfOyxdnAmu8/k6Y0G3b8LiITCb4suwZoDSC6f6MCIrOZ4+JICBe5z7FMVBkU/mT YrTbClRdes/t6VoWyKUzoOz2UiMLGfjr0uNu8GpKhqnp4FpFJ7lGk5/9XqyIaQn9 iZJLRw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b8p4945fx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 26 Dec 2025 18:00:30 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-29f13989cd3so226778625ad.1 for ; Fri, 26 Dec 2025 10:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766772029; x=1767376829; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tMuB0hXI/5B2GptpbNmP+iRFf5l17u1VGLcI/EUuwcQ=; b=GEkDKG+lUN02oWxttCIbAaJo3SRP5tDaONHOiTSo9lg0mnt5f5h+/41vtspgAdAw4s C6w65EGhS5iszwHfQbxzU6tom4xxqdpH9nBgxWxUluwwkVs7imTG/gD2LlvnUEzUebpk oGHorY7gRamJ/KrOA9nIKm+TvAQACb0RtcpSfk/o5oPVOkV+F8DnIHMeYBHO7otOerIF vBecJhzwVdBFGxr49zWofpGJnKbcncfbvLzHww5lqL1NFd4Lln0sTFEfgVNrLbEhmpPE 4ao4IlIAI9Bze+2jxtXnoAxpMC8Cwk1Kbfo+STAJXcsSiBYxDc35jbtCk0qUdz/1hLlp N1Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766772029; x=1767376829; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tMuB0hXI/5B2GptpbNmP+iRFf5l17u1VGLcI/EUuwcQ=; b=uWJzdbTD6Jra0C50WMvcqTOAVGRgAAVOwENy4CbpB+sm3VxMPoKHd0KnLNB8jh5g2p lnTbejUkMYI8urc1tospL1BgwrFPuQ6aP2Y3ShxLuvTPhZdvS+oE2A5M0Kn3r8XO8tC4 /WRrYi2YbOcS86VqO2/LXL0w8YWX56II8psm2w5nmd2VzClwoZfOcgiqwpT97vEjbgRo jDadeRfQlvY3psDxV/AaG/3Lwc9CrxlsTjdojJry6qjiLL7584SOfa2gEQM6WVc9RrvD c12eYHW19Qa+7TKfRnR+bSnzS9EWvUUTCEtjQT7v2AcP2gbPreNRyE1HBLDiBnC7qVhm ltAw== X-Forwarded-Encrypted: i=1; AJvYcCXfaDVwoP1wwEYT3Idu6qgowxJhtt38mgQ2VPVC2vPv5vEHib0jf0t0WCRCfBZZ57aRmsCUF89FPFbJ5OA=@vger.kernel.org X-Gm-Message-State: AOJu0YzpKsSHjaOKKMmFCYEoJ04p0uwOc8ekTVp3+KePfxUy6BETD2/e VlwrDVQPiY6HtqpWU5PNfoj4gWTnmBSj1RjHy08Xle/CqcgIf8NmGIi7Kke0GrghGZ+5s5puX8D yCSvprKIhpJaoX5o4499xx9wAZeQgGyGmupoDW/XjOahQPQ0/GjudLZH5YA44VxXPU4Y= X-Gm-Gg: AY/fxX71jIiPlAndeXSuue3c33FjVmsrYxtlLkhWzE4G4WbizRmS3df34GZd2nWX+N4 z5AQcUjffOGagRSECjpfXh6nOzHb4i9cLk7rMPrKzXGcukz7sdHNt1HX69hf4Boce1FMg3oz3QM cHpaBUQYl2MYTjbf2o57KReDIJKakDHQH4vkMBUhX1aWcs9a53PcUYzmZ+7ycI4h/e4zNTxJHga X0BL7NSDOzvFKgYmghrOzKkVUfHoMoZsdiI0nF6h/jf5Ym0pkGp9UbpxaMpGxQKnM9qYYb65Sgy 3Hc5hEJDnGAWlz+tVXBiT9QKbdAWqcep7kqznGkryNPIxPs71vfh+kaAD8H5mTT1LXdCyN8v/EF efmjEH0/wo+ROTbVVtyT+3a7FmqWiKmMqBpCOnQ== X-Received: by 2002:a17:902:e747:b0:2a0:b02b:2114 with SMTP id d9443c01a7336-2a2f220697cmr236097535ad.11.1766772029159; Fri, 26 Dec 2025 10:00:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTOcClec5lZYyKWh2iYi1rQ15hI+Z9TJS1BmbregQuUi4Yc4X2f6fvZg18gwi1aVYLsphQXQ== X-Received: by 2002:a17:902:e747:b0:2a0:b02b:2114 with SMTP id d9443c01a7336-2a2f220697cmr236097165ad.11.1766772028587; Fri, 26 Dec 2025 10:00:28 -0800 (PST) Received: from [192.168.0.195] ([49.204.27.144]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c8d10esm207575495ad.42.2025.12.26.10.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Dec 2025 10:00:28 -0800 (PST) Message-ID: <79483c95-c376-414a-947e-d7bf836c1e94@oss.qualcomm.com> Date: Fri, 26 Dec 2025 23:30:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: rcg2: compute 2d using duty fraction directly To: Stephen Boyd , Bjorn Andersson Cc: Michael Turquette , Taniya Das , Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251222-duty_cycle_precision-v1-1-b0da8e9fdab7@oss.qualcomm.com> <176661333774.4169.12534802903262524563@lazor> Content-Language: en-US From: Taniya Das In-Reply-To: <176661333774.4169.12534802903262524563@lazor> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 1Al_GYLdqwIAwWDV8hXO-POz1LSqDsQG X-Authority-Analysis: v=2.4 cv=esbSD4pX c=1 sm=1 tr=0 ts=694ecd3e cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=CGk/GHK3MkyyyFueakV4jQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=p2D3aUV_7dyrOLTwZK4A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI2MDE2OSBTYWx0ZWRfX77XHgK5WdznG vDYLLmFKMoAv8t8MiGZ4op5OOZje1PWj1snzcKJaRyk2bQzzE2SnOsmLaliDE6Tc0rQMNuBZIAe BPX14BoZDkvO7JCtQ2uQcX/zpPqnwT+Rrt1dSPo6CfetB5strR+s0p/fs0ufw1G/p+ZFd6wD6QN EPBSR3rj3qXMEUAd3LCV/bCEHsSPi2QDJhDDLw0vxR2d3TLK+vBB/aX1CkjMWhHInGAuy2tOezV 40IO3YIZpmDNn3ITD2ho5uF2KO+RyzaloSDnJQ/mdnR1J5UDzDNxacYaLa3p+Y/iAisCW9M1RC9 /GUsWRpbT+vtelR7OAwD+6H11VK1aKaY5qvLWiwri8HDSHpKqtnI2ZBGtyC3P1HWC0kc9RCFcvd UekvOAg6rjdjguwz1wY1LhiQK3RLIWxCOHziJbNCtd8lpiTd3DuUASDOb3h46Rivq5b+hPL3TWL QzAmFEPFY123GVtPWIQ== X-Proofpoint-GUID: 1Al_GYLdqwIAwWDV8hXO-POz1LSqDsQG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-26_05,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512260169 On 12/25/2025 3:25 AM, Stephen Boyd wrote: > Quoting Bjorn Andersson (2025-12-22 09:09:54) >> On Mon, Dec 22, 2025 at 10:38:14PM +0530, Taniya Das wrote: >>> @@ -774,10 +774,8 @@ static int clk_rcg2_set_duty_cycle(struct clk_hw *hw, struct clk_duty *duty) >>> >>> n = (~(notn_m) + m) & mask; >>> >>> - duty_per = (duty->num * 100) / duty->den; >>> - >>> /* Calculate 2d value */ >>> - d = DIV_ROUND_CLOSEST(n * duty_per * 2, 100); >>> + d = DIV_ROUND_CLOSEST(n * duty->num * 2, duty->den); >> >> This looks better/cleaner. But for my understanding, can you share some >> example numbers that shows the problem? >> > > Even better would be to add some KUnit tests for the qcom clk driver > functions like this so we know they're still working. Sure Stephen, let me take a look. -- Thanks, Taniya Das