From: Michal Marek <mmarek@suse.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: add %/built-in.o target in top Makefile
Date: Tue, 1 Nov 2016 17:27:34 +0100 [thread overview]
Message-ID: <794882b2-dfd1-ab76-11a9-8e5126247d23@suse.com> (raw)
In-Reply-To: <1477313111-25205-1-git-send-email-richard.weiyang@gmail.com>
On 2016-10-24 14:45, Wei Yang wrote:
> diff --git a/Makefile b/Makefile
> index addb235..546998e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1627,6 +1627,8 @@ endif
> $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
> %.symtypes: %.c prepare scripts FORCE
> $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
> +%/built-in.o: prepare scripts
> + $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
This rule gets in the way of
975 # The actual objects are generated when descending,
976 # make sure no implicit rule kicks in
977 $(sort $(vmlinux-deps)): $(vmlinux-dirs) ;
Quickly looking at the Makefile, it may be fine, but it needs to be
confirmed. This also explains why the current behavior with */built-in.o
is inconsistent.
Michal
next prev parent reply other threads:[~2016-11-01 16:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 12:45 Wei Yang
2016-11-01 15:53 ` Wei Yang
2016-11-01 16:27 ` Michal Marek [this message]
2016-11-01 22:59 ` Wei Yang
2016-11-06 22:18 ` [PATCH V2] " Wei Yang
2016-11-28 22:06 ` Wei Yang
2017-02-22 14:20 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=794882b2-dfd1-ab76-11a9-8e5126247d23@suse.com \
--to=mmarek@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®