From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8706277C9E for ; Tue, 23 Jun 2026 15:48:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782229688; cv=none; b=usbo2B+h4J/7hiZEPkbM4wfYCX9meDg0lXMujewEZzQwwKTe62CH5t3zMhcYcBt6TCrw/LIT4y4aEFoDvTXER6EunT6sJK9Y5wYCiEZV2N37Zx7wNWHL8RxjVLXw6JCdfgW2E5EJq48fkiqoj9PrJ9VFQIwHHmqvuSSk1w5w+4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782229688; c=relaxed/simple; bh=BpThCkBXjZBhx8M8F0BUDiZsLcu4WgQQ7DXbv1cN7R0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DuiqLhaAUHdm6PAbsgY2qC3FFJuEiPbMqPgu39qRNtdH6BrVrq4y+i24L8fL72gRB1kwL/g8yg0Mn0YgWQu/aLNtBEBr4JjD5n9dbvGN8sbVN4SQ6gbatJ73P28VnPd7nsvZ/ypyvjWiuQdaU9xfqdyM5RsKFw7yDxEHw4pHrvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SeFNXrTb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NddsDcRx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SeFNXrTb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NddsDcRx" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NDFpwA270639 for ; Tue, 23 Jun 2026 15:48:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lRAHD2dQC71qI+sdJjmGJW9ARXziUgn1C+t8q52zArg=; b=SeFNXrTbH/MryWh8 7ZbjwBZhpX94sgDqC6K8dVQO3Tcg4gUnhIaMAplEBMu6uttCQ1rVAZBNM3+F4n8D FJYGknl5lf2C3oLzNddSWAhJ46UMJAcGgFWAeZPRssd3jpsFaI1SmoGd/sb020bv cuwIrHeWL12AmJUrr01nSsVCYbNJoekzK25zhVBWh9KGGj3vKgqyJJchjg+Jz9KV H2BIlz9rSaAs8FN6Jn3h8HmzquIKYjQZaiuwPa0k6JY7zZQVkbcU1EMoRCD6xocC TUs4/INOc9/+1QoQnAEpqt4N0eWfOA8tZWI7A6+ps7yRSepV3onCYDevmIhJ/npH Ylesew== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eytvh0ptj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 15:48:05 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-966c8574759so54766241.1 for ; Tue, 23 Jun 2026 08:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782229685; x=1782834485; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lRAHD2dQC71qI+sdJjmGJW9ARXziUgn1C+t8q52zArg=; b=NddsDcRx4b+KWwuLTOmINm/2wjf3P7da/+gHnzncF9yfVFjbH9K/ekrmMeosxaHlX4 Dlji0gQPERZJUwRPKj1p6ROmok8WXcqEi8p7OeHdk5ssbkqHnyzTB9KytBvdZpSchlY1 BERNsZoYCudTxs/J9w1akJ6LJGOwY14yHxwr4lZyCRNgV2ukG4Gr54sg1xbKEO/Bqo9X 77/0STSL0Z8uzF+l3nBeXwFPvVI35NXsOLoyf5M2QUgIvtNzb0KdrnxWHtxMMWGl0mNl vJshxN/9nErax/YFKVJnrO/2ABUDWVLwSmKhOlKXNsDHtyb6zt5WO3UHDn+EmraCPwFf ZOsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782229685; x=1782834485; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lRAHD2dQC71qI+sdJjmGJW9ARXziUgn1C+t8q52zArg=; b=Fqu9aZDAxjWETniwPSL679ONx5lZX+NdPee1mQbshGlEbr1Gr8TUs7hCfmVMlzoD+g GT9tGdK8QgAlBggmivkusyafOCThi0wOCFOJvYoPHNCTrCj4ppk9d3pnxkYrIoT8VEj5 cL3sDGGdyN+b8mumYvSppWFRHxzIIMdhQz+BiE2HQHfQsnFuop4zaeovkXsnLbv2dEL7 p7YYJAz9EkNl778lQNBLv6Wv2yKh2J29wM4Nyb1Bjj/trM+/hAd/LS+Y9D1UtQqroMeG YOWk6chWPE0mJ1wK3eu8baO91jk9Ju1haNdax9Hbnrs4AvtR6ltLuJJ6lZTgbEzs+kBa wfeQ== X-Forwarded-Encrypted: i=1; AFNElJ+pJkxtn6klV5nH4++kaTeRaCIyjjE9AtCv2Fhy35S0HdzA2Zq6hy6Ot17V78U3Rb+eRNtTi7ZPa/hHuC8=@vger.kernel.org X-Gm-Message-State: AOJu0YwNUpH4F1JhxO7qEtV6eigixwt42mrF81ozyZfoS8nf4zedqiH2 2OgjJxSVZQWU7w533KqQ5fuUIqcypVcMH0NlDBrAHRm2Fds+74BVdmoM38Ll7JzZ4rPKnuyX4Bt tgKShKQ664VfjL+GWsqdKABDs5ewaG6OGZQ/V1+qs9w50X3M2dS6cHOsAmt2OsPuE3WU= X-Gm-Gg: AfdE7clDYiATZDgOb2QGr5f40Vpgc5Ypxq4gyHUE8NmHHBBT2l0efHyJftT2nfHZMZL g4rjCagOUFyoo6s0qGMCEc+fuXsEg/KnbtCylRjInf+YqNwxn4D2a02T07V3Gd+eejR7sR++qzp 5G2zBF7CZSuwKPD/JavKzQZRvpJ1pqgDLNOmMRAoltQ+Y17QS/qTh/OCAW+cLrMkAQuR+ANU3X2 VGSoScr/22XUCH3sgzSKSO6G/2bBloll7TdrRyzityC2LH47cKr18En5BVsGlX5QZs8vHq/gIvm gH8r/AIXgFRsHsySSWdEcaImT99rV6aGLl5IzA3IjmEm2jBlecRnsoaibZSB9G0LCGXxzhHLnOy rvxdFp+wcagQxrABAvQBrzP+T71iEkeAPrZo= X-Received: by 2002:a05:6102:5246:b0:729:5cd5:8cc4 with SMTP id ada2fe7eead31-72b161702acmr3691520137.4.1782229685162; Tue, 23 Jun 2026 08:48:05 -0700 (PDT) X-Received: by 2002:a05:6102:5246:b0:729:5cd5:8cc4 with SMTP id ada2fe7eead31-72b161702acmr3691503137.4.1782229684724; Tue, 23 Jun 2026 08:48:04 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977be32083sm5011680a12.14.2026.06.23.08.48.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 08:48:03 -0700 (PDT) Message-ID: <7948feb4-9eca-48f2-944e-ec982b6823dd@oss.qualcomm.com> Date: Tue, 23 Jun 2026 17:48:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/13] dt-bindings: sound: Add Qualcomm QAIF binding To: Harendra Gautam Cc: Srinivas Kandagatla , Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260605103739.3557573-1-harendra.gautam@oss.qualcomm.com> <20260605103739.3557573-3-harendra.gautam@oss.qualcomm.com> <3da8b668-1504-450e-bde2-b383d63090a8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEyOSBTYWx0ZWRfX1U6GFx8vOhYk Ei8XSdUq7C1bu0hzei4Zz0N44LjKtMF99yiFO1yz9zMUIlou3k7Afw8Bb/5Jj3PX3N3NgWyap1s a/Ec9Z3MIpgrwQgimAew8GtRlalPCy2oIyiFCwmgxWzEicb8AhLAF7/uAyPrVfPJ6Z1FsaDfn+e yx/KVjKPGuAJEyIYpS6cTppMKqRsKQETOkSlsjFJrHKGH+nEvCXdfzwpvB835JTIuStbab+vpOo VlIOSZLzMBGVvBnWN8iYxLbrhfM59RMiwdh9eYJ6SR8zwgCa+CbDSppdEeuQXf4AfNYyhkf69U8 mLFUaFGfkCO4ko6zv8gzJWCohMD4NEZfxGn4qCmENCN+r9Z5SGGEmIwCLSczW84CuL4jkWN1HVh IaDpeN2joym5GdbcvWKDKAGAUSVKHjnDWiutZ6bg+qtXL0hr8y3K3C4WNLzZh9PdZsgBHFlFVke dDmeb7fHOjmNNoVPiWw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEyOSBTYWx0ZWRfX0AL4jBlsydR/ HxMLuILJ2pDM4eCbVTVs8NDh/KLTX0hxTJw+5tcNCSwS6PypUqitExOBo2heuxdIDZalCPfrEPt VjD4XUrjFg1OQ/JXHRj9kFSVIwkk0EM= X-Proofpoint-GUID: XOeg59pH0GDRu4WPW6-IL0fNfM0ZsRen X-Authority-Analysis: v=2.4 cv=AJDhMgPs c=1 sm=1 tr=0 ts=6a3aaab5 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=J2pCh71u1A4b4KVnFjsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-ORIG-GUID: XOeg59pH0GDRu4WPW6-IL0fNfM0ZsRen X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 clxscore=1015 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230129 On 6/23/26 2:26 PM, Harendra Gautam wrote: > On Tue, Jun 9, 2026 at 3:27 PM Konrad Dybcio > wrote: >> >> On 6/5/26 12:37 PM, Harendra Gautam wrote: >>> Add a Devicetree binding for the Qualcomm Audio Interface (QAIF) CPU DAI >>> controller used on the Shikra audio platform. >>> >>> QAIF moves PCM data between system memory and external serial audio >>> interfaces through the AIF path, and between memory and the internal Bolero >>> digital codec through the CIF path. The controller needs a binding so >>> platform Devicetree files can describe its MMIO region, DMA IOMMU stream, >>> clocks, interrupt, DAI cells and per-interface AIF configuration. >>> >>> Describe the single register region, one EE interrupt, the required GCC >>> LPASS and audio core clocks, the DMA IOMMU mapping, and 'aif-interface@N' >>> child nodes used for static PCM, TDM or MI2S configuration. >>> >>> Signed-off-by: Harendra Gautam >>> --- >> >> [...] >> >>> + clock-names: >>> + items: >>> + - const: lpass_config_clk >>> + - const: lpass_core_axim_clk >>> + - const: aud_dma_clk >>> + - const: aud_dma_mem_clk >>> + - const: bus_clk >>> + - const: aif_if0_ebit_clk >>> + - const: aif_if0_ibit_clk >>> + - const: aif_if1_ebit_clk >>> + - const: aif_if1_ibit_clk >>> + - const: aif_if2_ebit_clk >>> + - const: aif_if2_ibit_clk >>> + - const: aif_if3_ebit_clk >>> + - const: aif_if3_ibit_clk >>> + - const: ext_mclka_clk >>> + - const: ext_mclkb_clk >> >> Drop the _clk suffix, we already know they are clocks, as they are >> listed under the clocks property > Okay, will correct. >> >> [...] >> >>> + qcom,qaif-aif-sync-mode: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: >>> + Sync mode. Use QAIF_AIF_SYNC_MODE_SHORT (0) for short (pulse) >>> + sync or QAIF_AIF_SYNC_MODE_LONG (1) for long (level) sync. >>> + qcom,qaif-aif-sync-src: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: >>> + Sync source. Use QAIF_AIF_SYNC_SRC_SLAVE (0) for slave mode >>> + or QAIF_AIF_SYNC_SRC_MASTER (1) for master mode. >> >> Should these be boolean flags then? > It should not be, the intention is to define explicitly, for better > readability I can rename these flags as EXTERNAL/INTERNAL, Please > suggest. Are all 4 combinations of them being present/absent valid on shikra? Konrad