mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com,
	Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
	Rakesh Kota <rakesh.kota@oss.qualcomm.com>
Subject: Re: [PATCH] arm64: dts: qcom: lemans: pmic: enable rtc
Date: Fri, 17 Oct 2025 11:26:26 +0800	[thread overview]
Message-ID: <794c77bb-db9b-4b34-b632-62ea56616213@oss.qualcomm.com> (raw)
In-Reply-To: <0dd6a528-d204-4073-a4b6-76356e71c5fc@oss.qualcomm.com>


On 9/25/2025 7:34 PM, Konrad Dybcio wrote:
> On 9/25/25 9:48 AM, Tingguo Cheng wrote:
>> Add RTC node, the RTC is controlled by PMIC device via spmi bus.
> subject: "arm64: dts: qcom: lemans-pmics: foo"
>
> (following the style for the directory)
Posted v2 to modify this.
>> Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/lemans-pmics.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
>> index 1369c3d43f866de9d8cd5cd4985241b99c0a0454..9e0d05c1b39ce229d5d4310ea1df1bf02e689178 100644
>> --- a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
>> @@ -132,6 +132,13 @@ pmm8654au_0_pon_resin: resin {
>>   			};
>>   		};
>>   
>> +		pmm8654au_0_rtc: rtc@6100 {
>> +			compatible = "qcom,pmk8350-rtc";
>> +			reg = <0x6100>, <0x6200>;
>> +			reg-names = "rtc", "alarm";
> 1 reg and name a line, please
Posted v2 for this: 
https://lore.kernel.org/all/20251017-add-rtc-for-lemans-v2-1-0aaf174b25b9@oss.qualcomm.com/
 >> +			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
> Do we not need "qcom,no-alarm" on lemans?

No, it's not needed on lemans. "no-alarm" is only needed on compute 
targets where windows TAD feature will support it.

>
> Konrad

      reply	other threads:[~2025-10-17  3:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  7:48 Tingguo Cheng
2025-09-25 11:34 ` Konrad Dybcio
2025-10-17  3:26   ` Tingguo Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=794c77bb-db9b-4b34-b632-62ea56616213@oss.qualcomm.com \
    --to=tingguo.cheng@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=kernel@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rakesh.kota@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®