From: Joe Perches <joe@perches.com>
To: Sebastian Fricke <sebastian.fricke@posteo.net>,
linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] base: power: runtime.c: Remove a unnecessary space
Date: Sun, 18 Apr 2021 00:09:38 -0700 [thread overview]
Message-ID: <794c957472f826b0f2860aecd365376266e2253a.camel@perches.com> (raw)
In-Reply-To: <20210418060800.8833-1-sebastian.fricke@posteo.net>
On Sun, 2021-04-18 at 06:08 +0000, Sebastian Fricke wrote:
> Remove a redundant space to improve the quality of the comment.
I think this patch is not useful.
It's not redundant.
Two spaces after a period is commonly used to separate sentences.
It's especially common when used with fixed pitch fonts.
A trivial grep seems to show it's used about 50K times in comments.
Though single space after period may be used about twice as often.
$ git grep '^\s*\*.*\. [A-Z]' | wc -l
54439
$ git grep '^\s*\*.*\. [A-Z]' | wc -l
110003
For drivers/base/power/runtime.c, that 2 space after period style is used
dozens of times and changing a single instance of it isn't very useful.
> ---
> Side-note:
> I found this while reading the code, I don't believe it is important but
> I thought it doesn't hurt to fix it.
> ---
> drivers/base/power/runtime.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index 18b82427d0cb..499434b84171 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -786,7 +786,7 @@ static int rpm_resume(struct device *dev, int rpmflags)
> }
>
>
> /*
> - * See if we can skip waking up the parent. This is safe only if
> + * See if we can skip waking up the parent. This is safe only if
> * power.no_callbacks is set, because otherwise we don't know whether
> * the resume will actually succeed.
> */
next prev parent reply other threads:[~2021-04-18 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 6:08 Sebastian Fricke
2021-04-18 7:09 ` Joe Perches [this message]
2021-04-18 9:11 ` Sebastian Fricke
2021-04-18 9:18 ` Pavel Machek
2021-04-18 9:22 ` Joe Perches
2021-04-19 15:16 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=794c957472f826b0f2860aecd365376266e2253a.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sebastian.fricke@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®