From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E8AD2E7179 for ; Thu, 28 May 2026 16:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779986492; cv=none; b=i6IsSGr8O9TSDmOiCpjFIUjPLCEOrAUU5eTZ7koM+R/rSxs6n/NpKMYFzFkdAq1eTEYqoKTmVXvbnBGFqk8djSdMyVNIXZQoiqlHx4FfIepobLpG9f630p8Nlne765msaWVNtCgP2kxHGonIaOMTNjdNVJ2xYSHTsq7XKhKJgFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779986492; c=relaxed/simple; bh=XBGoB0L6+rOVHYnTM/R3c8pY5d+eoM/ES6oiySPeke4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=BegUbQz3z2B3Htv0wlqlJyIMAN42q1dVmLtcic5HooRi1Y0Hul6RvvfsKGiLfu5qhFSpBHvkCQ4dxMa8WwPDWjfI6MwI+pSpK1dmw4X5J+3JFBt0nZu/mEStOfLxAuH+CW1inOQ8Omf/8hY1ApvuUqy9141UhWI8NOPE3fLNezY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YxinWkQv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=J9HHzCQf; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YxinWkQv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="J9HHzCQf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779986489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XBGoB0L6+rOVHYnTM/R3c8pY5d+eoM/ES6oiySPeke4=; b=YxinWkQv+ASOm+NJUtnK0jWdGN+Wl553TfkpxfxmR5771CMLlCS70llTxBoJzsmS3ySQVL 5n8XYYtsACil2WfcKIT7+t2QkIGso7pTBNEt/DjphRmSzgeOvxAE64rN4Rsx/OGaKy8daM Z1Ao+qcIPCIqX5hBdcsvHqP/f3qA5H0= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-XjrZSM16PGCY2aYSmwzYzw-1; Thu, 28 May 2026 12:41:27 -0400 X-MC-Unique: XjrZSM16PGCY2aYSmwzYzw-1 X-Mimecast-MFC-AGG-ID: XjrZSM16PGCY2aYSmwzYzw_1779986487 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-90cbd806004so2670723485a.0 for ; Thu, 28 May 2026 09:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779986487; x=1780591287; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=XBGoB0L6+rOVHYnTM/R3c8pY5d+eoM/ES6oiySPeke4=; b=J9HHzCQfnasbpyv/raiqyYJ4UX/H7fCKYF00B9FZIBKM7ZYHM8Ecgt78rtveFW/OE5 mBoyqw+5bLu4U2eq9tC9A7bViGeB5wyKmQaOk+d6aRPIsvcfM178L6Oq79JthD32RoDR YKpbAvIeRwnpjTRpBgkIJ1wOHG1S5NUNkw/PnvrEDF6lmtBboml/nwnb2xHDrlfzZ+R7 qwjIdHBGikKO6Sl5SWV82TqFUKG2eEtjmqGsfugZNqIT4psOwh2p7n7ueb4z2dJ39jMG VFwTpuN2b0GAxPlHB5BWC1ozEXAIiaiPxzLbm36Le2Nb0MDHtd+CYnSlVAEH1ssiZKPW sR4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779986487; x=1780591287; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XBGoB0L6+rOVHYnTM/R3c8pY5d+eoM/ES6oiySPeke4=; b=bV1vXgOJJvWcb5PjaDNwjaJmcrEzVRxg8IANEY+Yuui9ZnNrkTc+W0HjuGekbzvhjJ EXHlJGYii2aD6OIKT5glULekuDBPl6dQ5QWBco9oi6QBA1OBWMi/nlLIBl5o4M5twvS8 v5EQUzpvFif0ObvAQrjNrVGONLKCEoXShOz04AKC8plYGEzuZ8iC0tIOfcZuTGuIFSKF yCKaeZk/BUVxJ8ztI+GSx86dbJNnVVaJplAFg5Z+lQYWq/QN0Ju0eRUiWv27xXpAPmUu Z4ooIpDUshdBunvrLsWyeYEfBdmrj3D2I+nyrrg90wJxtKxYTv4mXoZm8T3+i0zplgzf oOUQ== X-Forwarded-Encrypted: i=1; AFNElJ//qcRCvRkBjOTLE9YEiJ6ENfhPs4tbOayN7PmyyYi/geHqWON9Kl1wFg7N3ieX3d7cElruaaxoUqsDYLo=@vger.kernel.org X-Gm-Message-State: AOJu0YyG/16MXix6QvxuZIWmOBvzHF7ZcK0wGi+4Iw2LIAb36TE+gnvf yHiJpqvaJzVrsma6RMGE4PLgBwkCiqvVnR1oAWI5CkBYYCP8/6wzzHTRAED1zP8aC4Qcji2HatE aL+j1wiKLgqcqaKgXDF05+HjNylsgM/QKNCxM0cnzUol9FzndguF1/Hxw0hUfBoYRp0LT1FgxBw == X-Gm-Gg: Acq92OG7TFsz3i/lOdsV7BlYEWh66ckHqyD6INHV4Mu/bwCd8wkqqSdq3OON72sd/EX GL5zs4ZBHwZ1BmgSs27VJe9eevcbmTOGebLzr54ggsJUvGRq6CIYKYMGj/+5fnizM3zvebW+tc2 Mf97tCVjyAkaAYE9zYv//2ERVDBvOq53fqJXX78pyDQAnLYHVwZDvoA5FDYw8DbEdJf3LUB4Dxt ZzxaRNo4cd9S7KTgMkYq0F+AalDtaMdMMIw9MBOohQwF4Mj4SsgUSay8ibXIobxMgxQd1Z9IBg1 UUgBPCsfQKddMiBcPZRH+61ZIq1WSRDSwH9FtN1Tr6G3OlbjKtqYTTSFGdXePIyP/MTvpAcn10I zSbWs++F/i6nBw5hVao1vxXRAcSLF X-Received: by 2002:a05:620a:414c:b0:8cb:9975:cba8 with SMTP id af79cd13be357-914b49e13d7mr3947690985a.62.1779986487050; Thu, 28 May 2026 09:41:27 -0700 (PDT) X-Received: by 2002:a05:620a:414c:b0:8cb:9975:cba8 with SMTP id af79cd13be357-914b49e13d7mr3947687185a.62.1779986486633; Thu, 28 May 2026 09:41:26 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f86e9bf5sm862446485a.8.2026.05.28.09.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 09:41:26 -0700 (PDT) Message-ID: <794dbd35fd81f03478cdd3238d3d506d0d800187.camel@redhat.com> Subject: Re: [PATCH 0/5] nouveau/gsp: Cleanup IS_ERR_OR_NULL() usage From: lyude@redhat.com To: Hongling Zeng , dakr@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, airlied@redhat.com, ttabi@nvidia.com, bskeggs@nvidia.com, dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhongling0719@126.com Date: Thu, 28 May 2026 12:41:25 -0400 In-Reply-To: <20260528062451.54107-1-zenghongling@kylinos.cn> References: <20260528062451.54107-1-zenghongling@kylinos.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reviewed-by: Lyude Paul Will push them to drm-misc in just a moment On Thu, 2026-05-28 at 14:24 +0800, Hongling Zeng wrote: > This patch series cleans up redundant IS_ERR_OR_NULL() checks in the > nouveau GSP-RM code. >=20 > The core GSP-RM functions already return error pointers via IS_ERR() > checks. Using IS_ERR_OR_NULL() is redundant and adds unnecessary NULL > checks. >=20 > This series is organized as follows: > - Patch 1: Cleanup IS_ERR_OR_NULL in nvkm_gsp_rm_alloc_get/alloc > - Patch 2: Cleanup IS_ERR_OR_NULL in nvkm_gsp_rpc_rd > - Patch 3: Cleanup IS_ERR_OR_NULL in core implementation > - Patch 4: Cleanup WARN_ON(IS_ERR_OR_NULL) across multiple files > - Patch 5: Cleanup remaining IS_ERR_OR_NULL usage >=20 > After this cleanup: > - Error handling is consistent with the rest of the kernel > - Code is simpler and more maintainable > - The intent is clearer (checking for error pointers, not NULL) >=20 > Hongling Zeng (5): > =C2=A0 nouveau/gsp: cleanup IS_ERR_OR_NULL in rm_alloc functions > =C2=A0 nouveau/gsp: cleanup IS_ERR_OR_NULL in rpc_rd > =C2=A0 nouveau/gsp/rm: cleanup IS_ERR_OR_NULL in core implementation > =C2=A0 nouveau/gsp/rm: cleanup WARN_ON(IS_ERR_OR_NULL) > =C2=A0 nouveau/gsp/rm: cleanup remaining IS_ERR_OR_NULL usage >=20 > =C2=A0drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h=C2=A0=C2=A0=C2=A0= | 4 ++-- > =C2=A0.../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/alloc.c=C2=A0 | 4 ++-- > =C2=A0.../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/bar.c=C2=A0=C2=A0 | 2 += - > =C2=A0.../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/ctrl.c=C2=A0 | 2 +- > =C2=A0.../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/nvenc.c | 2 +- > =C2=A0.../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/ofa.c=C2=A0=C2=A0 | 2 += - > =C2=A0.../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/rpc.c=C2=A0=C2=A0 | 8 += +++---- > =C2=A07 files changed, 14 insertions(+), 14 deletions(-) >=20 > -- > 2.25.1