From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA4263126D7 for ; Mon, 22 Jun 2026 17:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782148567; cv=none; b=ojZxnbRMywuCUt8PYtAxFoOb96MnN1XiedzuuqzCCayaaSVnOBg4fAK0DTz2TcyL3eY+bNOxOc3QpLCQlKrWXHOGVHo5l2QBsykSXMXr0M5jOWwg6Pyus+7jg4cHEknbJPw8ehD11H2EvohIJqDgchohKP5Rufk4yRjplxResg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782148567; c=relaxed/simple; bh=72L/mPDdlWA4TZSfpT2xRG8P8v2mi58khmTS2oj76q4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BEixi0iKMcs8E2YYjDdXOc0TjweYBV/IX/HA3pw14bno+YAB5fMUHiUy8JRcF8OcZZHNb/+XFW3XDT4H7AnPttyNFJWk+lcj78ECSXn7wHLaT9a3YDXgYGHC1AaZ00pdhikny6empxjinQ0WVmiHKjh1u70RyEX7tB8qbUrJAec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Os2trBkI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G9Ia20+W; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Os2trBkI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G9Ia20+W" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MFXKOx1571249 for ; Mon, 22 Jun 2026 17:16:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ReRUa+UsU9G9mReMcV2Z7heBlBD3bMPzdoBkYCqwmeA=; b=Os2trBkIs+z/uag3 mytEcE292w5b0C2HTOJnEjOsksZCj1ecs1EyE7ltvvYK+vLaeNASPWxtzMtl1z+B EgBkKsT0nNjL0CR78my3q+TSsDV2oLiIe+DVUd3Mp3qavq9O/7Ki4wikFXCnwADY vLZT7VnRMRPqIfToHmxlUDb7UJRK9Xo3Y3aM5JC+hNvF70e8vQiSQ5i3n3gmJwco sOIbgUkG9qGpIu73p+Vjad9XAQ8gCjh67UxlW4CX8jFArApDKDgAe7XJIv6AFIsE fGXOh7NPuu7RzIyAit2VS18fQciIkfGmk72jriXdmQ45rpOPPFu46ybW2lvJ64CC yuHrGw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey3eb9fbk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 17:16:04 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c6bf305403so42348665ad.2 for ; Mon, 22 Jun 2026 10:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782148563; x=1782753363; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ReRUa+UsU9G9mReMcV2Z7heBlBD3bMPzdoBkYCqwmeA=; b=G9Ia20+WNE8V3GCNh1ctEHGd/N5Xz8ARJWtRCTN591audtzIsXu7e03zWb3TXiIzIA GuyUIQh8zkYCeGgLHlEZEThDO3mRXzlvYxFwLBww8VCZlHTlyc40t3yqbtj87olqR/VB YgPBZeNEaJx3hrWhIyvjQ8UvLNOa6/1UW1UcHvOOdoEnawgLIH0BFjHfKkdqTd0Pc99K 7GcP62RDm3g7EW8sq+Qqwac2uOueBx2HWGrJeTMeaZxaJm+ZnsoAmGbW6ESSIZMXmidz n7jAaQcTwEcmNd2OemFJpRgExV57JelR2KjkRmXn6hE6MofSDZ0qpBBhpH/a5LiY/4ne tLIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782148563; x=1782753363; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ReRUa+UsU9G9mReMcV2Z7heBlBD3bMPzdoBkYCqwmeA=; b=JdW0PHUrES6tZ0NWbBpNfcai3ZVqia1TuEWePfe7xX5ACNr4HSejmeod2TxoTPWllI HBEcbrwFen0GRJFRlxAq2BCSsrFJnsWa6yKi89mw03/hcAzdJGBCpqyR6s5tVi8JnQxX QFWFHwvuAAa0VdMJDzxCv5msunhZ6307uCOsHjWNq2ynLULvtdVd8VzeJ6pjM2aWc6Su MH//DVbsBJ2ou8b4Myct1C9mPWq46FPZqW/xXV5CEEK5LhCsa0UHmgysQnLDNVHGoHfi 6cLeHtUoFQOBJICWhv9ZgnNsu52WhOdRW+V0nFgzQzS1VCm/YGlLZpiohCjkoHjtk10/ RvOw== X-Forwarded-Encrypted: i=1; AHgh+RoB8/Lz/QA8NRzhsGV0yLaiCRa0B8db8/J1mDWbdya46k1yjVNdul7MVX3L+1IyokZQHBD/R9nK/J7/ZDY=@vger.kernel.org X-Gm-Message-State: AOJu0YxTS+KkqbOs0xeuFiVwQqclUOaL5lYKc+8mBeIOxG+p/1K3jWSG vfjdKQKQrY6qaN9ovgViYGNBetvC01jMPmt/4aQfsHp9aedbHRjEMWsq1vklwQWOwF7LTX4PDdL VzGCs882AsZ7sAxujPQTWXZFHKlGsaLfEAu4v7IqebJFKwker3ZtltQL5ifdiFeAyyxs= X-Gm-Gg: AfdE7cmTn1ndN9/uVn4syBCJrCRmbwRnWJe1dWxmcb1r4G2wSketU3wmOLrglE7Muux rx1dbHxZG3n/jhJzVwbnW0VK6k6cDIVw2vpCYe5nNFvX6jVtMiTX4GQV0tz+k7NE+Jclb6kPmqb +VbZhN1CRpiMezG8p0BODO+yYsN7T2lWQeKehHjTSzhUZk5TQabosZHvN/K0xbDwjARiny/7NHg Iz0zPxnEia3Bzu0/r633fLCZiSW5H4v43ZmzlG12rURRLJ7jNyzx+RpIcLJuNQYoDYELZ6d6wsy 8wffiojMNhAVtjK8gj+5ju49F7Br4D/QILZNdnDF9S/2gTWr6mPaTr062+UcGjcDhNO8UF4UbQS VRZLWMPHx59LWqG8KtQkx8BgRpMBHrTvuFqpUy9kmCkl75cs= X-Received: by 2002:a17:902:da8a:b0:2bf:77b2:8b2d with SMTP id d9443c01a7336-2c725d70645mr152178625ad.30.1782148563492; Mon, 22 Jun 2026 10:16:03 -0700 (PDT) X-Received: by 2002:a17:902:da8a:b0:2bf:77b2:8b2d with SMTP id d9443c01a7336-2c725d70645mr152178015ad.30.1782148562656; Mon, 22 Jun 2026 10:16:02 -0700 (PDT) Received: from [192.168.1.19] ([106.222.233.117]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c743bfdc97sm101691915ad.65.2026.06.22.10.16.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 10:16:02 -0700 (PDT) Message-ID: <79520895-f584-47e1-8206-3b7c06b759d4@oss.qualcomm.com> Date: Mon, 22 Jun 2026 22:45:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260522-qup-se-increase-ram-cnt-v1-1-71854d0b2ef0@oss.qualcomm.com> <09fb9e91-2585-4cb5-8bfb-92df304e9d6c@oss.qualcomm.com> <5363525f-9440-49bd-83db-242a7ed4e15d@oss.qualcomm.com> <9e57f91b-8f80-41d4-b50f-31c900cb0fd0@oss.qualcomm.com> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <9e57f91b-8f80-41d4-b50f-31c900cb0fd0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDE2OCBTYWx0ZWRfX7tv8cralEYBW J3iEGDU9ZFebdmPURpHhSFxXL26Jn+FJH8ojE1kOwfpLBTzR6SLWFQb6iSYBOAqeKfhCUppCuvO AOUBDiKiIqYboIOFeFfCNHEGeb+u+Vo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDE2OCBTYWx0ZWRfX6bGlO0nuiN3A Xh+087n/IUoPMy8FuaX3q38k/vGMKXmsy1FHWskWJsv8estfBRcf6jPj82gjRNgcHDeucMJb7jp XwoEJnAztCYYwdReb6yCF9K+t6W5jRlvemaye4E5GzuCytGEkK5FjmSvD3refsV3GUGZM03tn7v d9QvxUdmLRMO5NcMj1OAA/Du3siDKFwrKPhIoapDzh23rNicv7TuWap2kPzSoCSMMSwctTKcOZW hNe0OvyUOKF2Zk+R5nQh4cYDYND/s8GgK0wTiLL/LBEEev7Ezii8dq+kTTgDcAMRKs3UpZ/wSet qjB1V7Av/1n25mGM+MrHjU/Qzyptvd0hL7G/zwCHBoZS0RH7SLWBhQEzG4ZpEg4L8Hd9U14FJik YdIQ7jrFGFN27PUaqVsbPca8rN0ojM8e9suMP2GP6T4ni5LMDihlYSklc0Yk0jStooTjLwxMmvE VxQo0JWmVFtcoiPs43A== X-Authority-Analysis: v=2.4 cv=ILIyzAvG c=1 sm=1 tr=0 ts=6a396dd4 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=HXD670HYuRgJgDrgkXnM1A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=3Itzvz1JomGL4-STCREA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: 3G1TqCIEHzu1QgXaauJF9DY5omX1Zi8h X-Proofpoint-ORIG-GUID: 3G1TqCIEHzu1QgXaauJF9DY5omX1Zi8h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_03,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1011 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220168 On 6/15/2026 5:30 PM, Konrad Dybcio wrote: > On 6/15/26 2:00 PM, Konrad Dybcio wrote: >> On 6/15/26 7:28 AM, Viken Dadhaniya wrote: >>> >>> >>> On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >>>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>>>> entries, causing incorrect bounds checking and preventing firmware >>>>> loading on those targets. >>>>> >>>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>>>> limit and ensure correct handling of configuration RAM regions across >>>>> GENI-based SE blocks. >>>>> >>>>> Signed-off-by: Viken Dadhaniya >>>>> --- >>>>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>>>> index cd1779b6a91a..d0810960f3da 100644 >>>>> --- a/drivers/soc/qcom/qcom-geni-se.c >>>>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>>>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>>>> /*Magic numbers*/ >>>>> #define SE_MAGIC_NUM 0x57464553 >>>>> >>>>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>>>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >>>> >>>> Is there any SoC where this could overflow the register space >>>> (you say "certain Qualcomm SoCs")? >>> >>> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM >>> entries, so the previous limit could overflow. >> >> What I'm asking is whether the size of the RAM on any of the SoCs >> is less than 455 (the previous limit) > > *Less than 1020 (the new limit), of course.. > > Konrad Yes, some SoCs like kodiak, monaco and lemans have CFG RAM smaller than 455. But MAX_GENI_CFG_RAMn_CNT is only a firmware ceiling; the actual programmed size comes from the firmware header. Talos needs ~650 items, so the old 455 limit rejects valid firmware. Raising it to 1020 fixes that without changing programming behavior. Regards, Viken