mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Igor Belwon <igor.belwon@mentallysanemainliners.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] Add Exynos990 pinctrl and chipid drivers
Date: Wed, 16 Oct 2024 09:19:58 +0200	[thread overview]
Message-ID: <795657e1-5232-494c-9ac5-a62455b0f6f9@kernel.org> (raw)
In-Reply-To: <m7sxqsmaczjufn2jqjmo5xribsihwy4s4w7nsybub2ji62klrm@ecwv57qogd73>

On 16/10/2024 09:06, Krzysztof Kozlowski wrote:
> On Tue, Oct 15, 2024 at 11:04:45PM +0200, Igor Belwon wrote:
>> Hi folks,
>>
>> This series adds support for the drivers for the Exynos 990 SoC. It
>> consists of the pinctrl driver and the chipid driver. The product ID
>> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
>> same as in the Exynos 850 chip.
>>
>> Changes in v2:
>>  - Moved bindings from SoC bringup commit
>>  - Moved device tree changes from SoC bringup commit
>>  - Ordered pinctrl nodes by unit address in SoC DT
>>  - Moved the exynos990-wakeup-eint binding to the correct if.
> 
> Moved? That's not what I asked for. Are you sure you have this warning
> free? That's a requirement for Samsung (see maintainer profile).

Ah, I see now what you did - you removed the interrupt. That's
surprising. I don't understand why.

Best regards,
Krzysztof


  reply	other threads:[~2024-10-16  7:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 21:04 Igor Belwon
2024-10-15 21:04 ` [PATCH v2 1/5] dt-bindings: pinctrl: samsung: Add exynos990-pinctrl compatible Igor Belwon
2024-10-15 21:04 ` [PATCH v2 2/5] dt-bindings: pinctrl: samsung: add exynos990-wakeup-eint compatible Igor Belwon
2024-10-16  7:20   ` Krzysztof Kozlowski
2024-10-15 21:04 ` [PATCH v2 3/5] pinctrl: samsung: Add Exynos 990 SoC pinctrl configuration Igor Belwon
2024-10-15 21:04 ` [PATCH v2 4/5] arm64: dts: exynos: Add Exynos 990 pinctrl nodes Igor Belwon
2024-10-15 21:04 ` [PATCH v2 5/5] arm64: dts: exynos: Add button support for c1s Igor Belwon
2024-10-16  7:04   ` Krzysztof Kozlowski
2024-10-15 22:03 ` [PATCH v2 0/5] Add Exynos990 pinctrl and chipid drivers Linus Walleij
2024-10-16  7:06 ` Krzysztof Kozlowski
2024-10-16  7:19   ` Krzysztof Kozlowski [this message]
2024-10-16 14:41     ` Igor Belwon
2024-10-16 14:49       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=795657e1-5232-494c-9ac5-a62455b0f6f9@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=igor.belwon@mentallysanemainliners.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®