From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755447AbZBXJZw (ORCPT ); Tue, 24 Feb 2009 04:25:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754170AbZBXJZl (ORCPT ); Tue, 24 Feb 2009 04:25:41 -0500 Received: from phoenix.slamd64.com ([217.10.145.2]:57321 "EHLO phoenix.slamd64.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754124AbZBXJZk (ORCPT ); Tue, 24 Feb 2009 04:25:40 -0500 Message-ID: <7959.194.201.210.214.1235467509.squirrel@phoenix.slamd64.com> In-Reply-To: <1235454078-3069-1-git-send-email-mspang@csclub.uwaterloo.ca> References: <1235454078-3069-1-git-send-email-mspang@csclub.uwaterloo.ca> Date: Tue, 24 Feb 2009 09:25:09 -0000 (UTC) Subject: Re: [PATCH] acer-wmi: Fix regression in backlight detection From: "Carlos Corbacho" To: "Michael Spang" Cc: "Carlos Corbacho" , "Thomas Renninger" , "Andi Kleen" , "Len Brown" , "Linus Torvalds" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, lenb@kernel.org User-Agent: SquirrelMail/1.4.13 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (phoenix.slamd64.com [0.0.0.0]); Tue, 24 Feb 2009 09:25:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Adding Len Brown & linux-acpi to CC] > Currently we disable the Acer WMI backlight device if there is no ACPI > backlight device. As a result, we end up with no backlight device at > all. We should instead disable it if there is an ACPI device, as the > other laptop drivers do. This regression was introduced in febf2d9. An identical patch has already been submitted, I'm just waiting on Len to apply it: http://patchwork.kernel.org/patch/7223/ > Signed-off-by: Michael Spang > --- > drivers/platform/x86/acer-wmi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > Each laptop driver with backlight support got a similar change around > febf2d9. The changes to the other drivers look correct; see e.g. a598c82f > for a similar but correct change. The regression is also in 2.6.28. This won't apply cleanly to 2.6.28 due to the move of acer-wmi from drivers/misc to drivers/platform/x86, so we'd probably need another patch for stable. However, that can't happen until the original patch gets merged upstream. -Carlos > diff --git a/drivers/platform/x86/acer-wmi.c > b/drivers/platform/x86/acer-wmi.c > index 94c9f91..6bcca61 100644 > --- a/drivers/platform/x86/acer-wmi.c > +++ b/drivers/platform/x86/acer-wmi.c > @@ -1297,7 +1297,7 @@ static int __init acer_wmi_init(void) > > set_quirks(); > > - if (!acpi_video_backlight_support() && has_cap(ACER_CAP_BRIGHTNESS)) { > + if (acpi_video_backlight_support() && has_cap(ACER_CAP_BRIGHTNESS)) { > interface->capability &= ~ACER_CAP_BRIGHTNESS; > printk(ACER_INFO "Brightness must be controlled by " > "generic video driver\n"); > -- > 1.6.0.6 > > -- E-Mail: carlos@strangeworlds.co.uk Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D