From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Brian Norris <briannorris@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Kalle Valo <kvalo@codeaurora.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Yan-Hsuan Chuang <yhchuang@realtek.com>
Subject: Re: [PATCH] net: rtw88: fix an issue about leak system resources
Date: Mon, 4 May 2020 15:51:57 +0200 [thread overview]
Message-ID: <79591cab-fe3e-0597-3126-c251d41d492b@web.de> (raw)
> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.
How do you think about a wording variant like the following?
Subject:
[PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping()
Change description:
A call of the function “pci_request_regions” can fail here.
The corresponding system resources were not released then.
Thus add a call of the function “pci_release_regions”.
Regards,
Markus
next reply other threads:[~2020-05-04 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 13:51 Markus Elfring [this message]
[not found] ` <20200504144206.GA5409@nuc8i5>
2020-05-04 15:00 ` Markus Elfring
2020-05-04 17:03 ` Brian Norris
2020-05-04 17:19 ` Markus Elfring
2020-05-04 17:19 ` Markus Elfring
2020-05-05 0:59 ` [PATCH] " Dejin Zheng
2020-05-05 6:15 ` Markus Elfring
2020-05-05 8:52 ` [PATCH] " Andy Shevchenko
2020-05-05 9:03 ` net: rtw88: Fix an issue about leaking " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79591cab-fe3e-0597-3126-c251d41d492b@web.de \
--to=markus.elfring@web.de \
--cc=andy.shevchenko@gmail.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=yhchuang@realtek.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®