mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Walmsley <pjw@kernel.org>
To: Zongmin Zhou <min_halo@163.com>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	alex@ghiti.fr,  linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Zongmin Zhou <zhouzongmin@kylinos.cn>
Subject: Re: [PATCH] riscv: hwprobe: use _BITULL() rather than BIT() in MIPS vendor uapi header
Date: Fri, 18 Sep 2026 18:47:02 -0600 (MDT)	[thread overview]
Message-ID: <795bd810-d382-3b80-bd3b-041b6742fe93@kernel.org> (raw)
In-Reply-To: <20260917062306.46978-1-min_halo@163.com>

On Thu, 17 Sep 2026, Zongmin Zhou wrote:

> From: Zongmin Zhou <zhouzongmin@kylinos.cn>
> 
> BIT() is a kernel-internal macro that is not available to userspace, but
> the MIPS vendor extension uapi header uses it without defining or
> including it. Any userspace program that includes this header and uses
> RISCV_HWPROBE_VENDOR_EXT_XMIPSEXECTL fails to build.
> 
> Use _BITULL(0) from linux/const.h instead, which keeps the value at 1,
> so there is no ABI change.
> 
> Fixes: bb4b0f8a1bcb ("riscv: hwprobe: Add MIPS vendor extension probing")
> Signed-off-by: Zongmin Zhou <zhouzongmin@kylinos.cn>

Thanks, queued for v7.3-rc.


- Paul

      parent reply	other threads:[~2026-09-19  0:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  6:23 Zongmin Zhou
2026-09-17 13:00 ` Jesse Taube
2026-09-18  7:36   ` [PATCH v2] " Zongmin Zhou
2026-09-19  0:47 ` Paul Walmsley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=795bd810-d382-3b80-bd3b-041b6742fe93@kernel.org \
    --to=pjw@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=min_halo@163.com \
    --cc=palmer@dabbelt.com \
    --cc=zhouzongmin@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®