From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933429AbdEXSPV (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 May 2017 14:15:21 -0400
Received: from mout.web.de ([212.227.15.4]:53439 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933130AbdEXSPU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 May 2017 14:15:20 -0400
Subject: Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed
 memory allocation in alchemy_pci_probe()
To: Manuel Lauss <manuel.lauss@gmail.com>, linux-mips@linux-mips.org
Cc: Paul Burton <paul.burton@imgtec.com>,
        =?UTF-8?Q?Ralf_B=c3=a4chle?= <ralf@linux-mips.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <6ebb5193-239f-5c34-c5f6-2be8a2fa79a5@users.sourceforge.net>
 <CAOLZvyHq-7q0XxiBsyX3q0g0J3kjfFv4SU7amX1hpjRDyK+feQ@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <796029e7-60a3-a94b-8b5c-4686a0656560@users.sourceforge.net>
Date: Wed, 24 May 2017 20:15:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CAOLZvyHq-7q0XxiBsyX3q0g0J3kjfFv4SU7amX1hpjRDyK+feQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:7vUIFUogHlKlcL3HavEsYY84s0F/yusWsTzkC8TbXw+2V9RUSDI
 IdXb5ostoS7bgzTXOR9UllT1PvRX5KPwVjVzDoNctFJ5N93InubQoo4+hhscmjtCofGEeIW
 UQU2q/46uu2PC32jE7+g9tRPSm9JvY/SDQZoGnd2rh/YXuNBszAWqcnOdZb/nZfU4ZZVFxV
 C10nQTerwOo+lwsyaJ2dw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ipMlkQtXuzE=:ZVZPUYX2PwsyVWv6kZqhCw
 KW/LfmKsOJnQjM7Yhq3UEDn2LKT7leuik5PwyyOTbQeNuO5FQEX8iHgJ4YCk6OAg+BIQfmSZN
 Swo/c/qWPFopMutEMIe1VP3Wrb7CFEhosNajVzyccz7qYL31G8a8rVgoe7RNe9F5jqg0B96E6
 KtYPp2ruXBLdwrMz4b3E/d689M4sJFyznKf6ZrBtdmizfLrPATbk7yT+NgzhER3qVKQbdi2Me
 V9/AukC35BSTkTRXBlIWg4VFm6tlchLRyY9p6M8wpIrh3kzLIy399KOo3Cm44KJ10jhyDKnfU
 gpIyDEdATZvL0W16AJjpEsWLTl34GYu4bhDS2ieKT1DUD+DbFyA7hu3xEFySuSYpLDnuGvWgF
 sh7gHPFBGDWQ57dVnveTisoEpj5Vj0kPrCo+zrV2CiESPa7tUXUQB5OGddop18uwJA41/5cs1
 iTO5yR/Tx5fqWBse+fW+W1pTp8r0aa1TGtDjSHlcZxZAyw+MpF3y+QwyJjmfV1z+AVX2kkFB/
 RVY//5zpI93WZcZuHP/oH60LPO9JBjYbXRZmCrISwAm/P9GaIDDViQcBpK5U/UVmC+/Obkni1
 s+9hgJxYwn6bsV5ywViUzhjCdFH/NerzVJ4PUIubZuLzc6Jp35Lr4SAluGtI8CP9KMzZ4WsUx
 /3i8kpqzWAuueEMGcTYqYOm26rGqI7UXuDLZM9nSp95X98spquS0PvKcvzsa+ghyBuzMyWPYl
 7IvmTZEP8x4jHMzCl6tdafq5BaE6fqI0VXI6QVFEu/Egx4DUcwr/ThKma5fyLMq5sXWMELeoR
 uuF51KW
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +++ b/arch/mips/pci/pci-alchemy.c
>> @@ -377,7 +377,6 @@ static int alchemy_pci_probe(struct platform_device *pdev)
>>
>>         ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>>         if (!ctx) {
>> -               dev_err(&pdev->dev, "no memory for pcictl context\n");
>>                 ret = -ENOMEM;
>>                 goto out;
>>         }
>> --
>> 2.13.0
> 
> Why are you removing just this one dev_err()?

How do you think about to achieve a small code reduction also for this software module?


> What issue are you trying to address?

Do you find information from a Linux allocation failure report sufficient
for such a function implementation?

Regards,
Markus