From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753063AbdJFJSR (ORCPT ); Fri, 6 Oct 2017 05:18:17 -0400 Received: from mail-db5eur01on0114.outbound.protection.outlook.com ([104.47.2.114]:63584 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752929AbdJFJR7 (ORCPT ); Fri, 6 Oct 2017 05:17:59 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH] lightnvm: pblk: remove spinlock when freeing line metadata To: Hans Holmberg , Matias Bjorling Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Gonzales , Hans Holmberg References: <1507192546-12156-1-git-send-email-hans.ml.holmberg@owltronix.com> From: Andrey Ryabinin Message-ID: <7960b012-1154-fdad-0c45-c952357f13f5@virtuozzo.com> Date: Fri, 6 Oct 2017 12:20:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507192546-12156-1-git-send-email-hans.ml.holmberg@owltronix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: AM5PR0502CA0006.eurprd05.prod.outlook.com (2603:10a6:203:91::16) To HE1PR08MB2826.eurprd08.prod.outlook.com (2603:10a6:7:2e::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5828a439-f821-407b-cbc1-08d50c9b2160 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:HE1PR08MB2826; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB2826;3:zWYPdQYulPtjgwQqnrrigtwYYVC9yibe5s/sbCnWhKToC9WONygozNNs0IDspCaP75NOOUfrX80tpqJ5YZ7f0RZ8StqiwBzNaTWkMCRYLPdnRfmDmAjF7MyZl0aIjyb5X/ooFePigpdlQ9mlG6gZiNRWssNhHWE969hp0j7eB91oFBz/L0e5xHaHUwYGvHccCHL2US+LJ7r6srTYdBgbne4zChQeZ4dm2qJkAy526PBAfbcQBHqFL6GxTq0qCzK/;25:UIXPh0iUyKsqOIcCpm+xISXrkM9sWVPyJ0Q/wP01my2OU3iJ2R2uN3AIbKq8NrEJA72yVTwYpIb2wtj13nqNuGLq0d+vatxPhlShyNa+EwSg4gXxPRPn6mCMUF01gP08AMpsBA3q8K0+cmf02RdujIb9o3MafN41WLseFKLdpwEX/KPvs1Q7wTmj1TOldHL5u1uB46Nev+OvMlnFG0EqrSMsFJD7J1w713NU1hNNDyZFqBQf1Hq0cr6s7Q8WaKDIG1QG9sjdKqmsxr6RYKz0AEUo00yGMPLHzIzxa7x0aga7GMy6Z8oAJtS3sh6fBDIyjjqWbs3vVZ/Hz7Wj5vwQXA==;31:Blb+07iXCJ6HYyJ9GX6MWLaT2T2taOznvumBa9Ws30t1llnMEzqI9OgL0zIqT0mCX7nmAMsCnuCukmq77CBYXdSoeUjM/Exp89NWVmcBCPGt9KYCQmXnInvhZWwmgFklOqRt7kvtnm+qMQdcNuOvX7pXwx+IAJ69k34Xk6tKiyP4NuMpiTWXHnqI3nYTei6jk4TQmmPE5LwhlOURpSN//v2wrpC+0Q10M/krG7G/olM= X-MS-TrafficTypeDiagnostic: HE1PR08MB2826: X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB2826;20:heculk9hOmHxRTA2DgFGDkR1vS/eEa3fWKfDm2RBPx6ZhEm7LnqtoYIaURcIw6FSMM7OkKWf0D24JhdE+bdPLzfTlDDLmf66/Em4l3/RT0EPM8jc21DaLNdyMiUDgv23xz/lhFUc94qLQQOTzCvbM0h3q02EtGTHpGedT9z7Bcw9CGU2aQoVZ4XC7hvBOrqyyTk4tTM04QVrgNh3Sv7zoSXrP79Ewlytf0LyEMslNx12GpiW5AB4zE8PVQNyuwJK590+MZoxtxUUvg2EoBFGS6OJKbU0u+ZV0c3jDEO5bKUjqN/ERAku4KJhO/XBxypZpWgwFNEJidqTNdsD3WdymRBKOlEGw3QHHZ9mF7S9eTJfsHqlMfd3zQMTNPxvWLKdT6figXGZZ6AelhwHqGMTBTiG4Aic3jYvtxE457iUyJs=;4:opilXNg8AxJI7Xor7a3lpypcJcEOj2/beGgTffOUc89pyf3635BtI9O+Xt87L3ZH0GFdQBFqF5DRtRi9RTgb2Jc2FhmYM+z/LZJGh4vCP7OLhEMwNR5URXvlIATYGIb2jpGUjJw0V8fNKU5gTBDALvHDSUpgFHhodjW8XdkxIFDborDxukjZ4/pxbXfzEPMmLrd07AVCEgcDFGZ/McGfVdNyrEcR5POlzcHQqt1rE5tiiay4LwhISt7soeyzXmctAha5bdQGwMu5iZ7N3tdiNtxOJbTyi+6XW2DBcdFHgc4= X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR08MB2826;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR08MB2826; X-Forefront-PRVS: 0452022BE1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(346002)(376002)(199003)(189002)(377454003)(24454002)(8676002)(6246003)(8936002)(5660300001)(230700001)(316002)(83506001)(47776003)(305945005)(66066001)(7736002)(25786009)(16576012)(97736004)(65826007)(68736007)(76176999)(50986999)(53546010)(2950100002)(3846002)(54356999)(53936002)(189998001)(2906002)(31686004)(6486002)(65956001)(31696002)(4326008)(50466002)(101416001)(77096006)(6306002)(110136005)(58126008)(36756003)(86362001)(65806001)(81166006)(478600001)(81156014)(6116002)(966005)(16526018)(105586002)(229853002)(64126003)(23676002)(106356001)(33646002)(54906003);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR08MB2826;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4TUIyODI2OzIzOndyeVgzSXc5ZzVBbDFMNXBxalh1MGtlL2xE?= =?utf-8?B?M01XZHppWCs2ckR6endoK2xNQjdHRXhjdW44ZEZHQXp3Wmk1bjZicVJPRklL?= =?utf-8?B?SEdiRjlpbG5vTW5IWXBtWmxTT2dFa2JXNThxNzFwaDZpdG5tVUYxdkZuVGRs?= =?utf-8?B?RnphOGdOSEVsMFBqQU5vSFNqbnpEZUVJcFV5WGlCZGVPVERUdjkrMVhIUTNx?= =?utf-8?B?Zk0rYy9FSWpnT0llZTAvZWJpcW9KbHZMMDZadTErWFBnSkpjK0F2SWhJclZ4?= =?utf-8?B?UVluK3llbTJNTjBEV1lxSnMrTUVjRHk2S0Y3RUEvemZsbUQ4OGJSNHlWcmps?= =?utf-8?B?dEdoVU8rcWFKZllNOUhBWFE3WmFTSUgzZ1d2dTBVU3JtUUNOTnNBQnlxOHo5?= =?utf-8?B?elFObDlyZDY2Z1VYK0JsdDBPWUVTaytUTkJMZGp4UVNITGtOSzlYVVptUzFz?= =?utf-8?B?RldoRng1ckh2ckZXWFhSZVUxS0JDSDJZQVdOamhpN0pwU21OcUgzT0NOR1hC?= =?utf-8?B?WHp5UVQ1NUpXTWlxK3I1SDFtdVpod1ZNL0dHb0phWXA1MUVpWWphOXpNUit6?= =?utf-8?B?cXJ5QkJJNDFvZXNVejZaTzlWRVBCMUcweEV2ckEzUzN6cWc1Q21oNEMxUkNV?= =?utf-8?B?dGRSWkViMFRLTUNmU3hwNjZCZW5KV2dzWFN2RWx3Y0NwWHhQWHBOc2xJQ3Vo?= =?utf-8?B?ODJkUzlHanppWjN6ZWFzRG9LUElPaU85STFJTk5JeEhNTGs3VmVxV1RCOUNT?= =?utf-8?B?T3lqaDBPOTJOUE81dU82dFIyOGRyVW1JMVkzUDVKeE9xTUxnWk5FcXFtNVJ4?= =?utf-8?B?U3dndlFaS2E1eXp2dmhacDJTUzVkRGY4UitvWjdGTU82d2wwWEZiK1dhYUJV?= =?utf-8?B?WnVIdDlvd0p4MXVQbjd1dXJYQWtzYmVnc3QrRG01SThWdCtxZ3JKb1ZadHMy?= =?utf-8?B?VmdpaWFmcHV0YmwwaGQ3a2NXQ0RMZHE1SGUvZkVOZVBlenZjd3hlR01YaFRq?= =?utf-8?B?bzUweEUvdW0yN1pRRUgxZjdpM2tvU1p1azJGWUN0LzBxRjBZY3M5dDBacjdG?= =?utf-8?B?YkJoZXA0NFhzdHlZalY2bmR4dFhURW1COXVTby9jY0hzdktPbnFQeXlVblU4?= =?utf-8?B?aVgxcjlXTzNrWHk2RUQxYUVEZWszVDVSSnVpaG10aWlacVRSWkJTSW01Mklh?= =?utf-8?B?c05KbjRUZTA0dmVLZkRyYWcvVitvK0JCUHhLMEZWZVZuYVJSQ1VUdXRubi9D?= =?utf-8?B?Rys5OW5YdDdJNnlWR2x6TS9DRURHcXVxU1lYUElsY0h3aWtSSTlOOExEZkJ2?= =?utf-8?B?R3lTRTlraVpQUlJEdjdQZTRXVXlJSS9ieGhPbWR1TnRRbkg4TUUwcUJXaEpR?= =?utf-8?B?K29qUDNCSW15aGxnODFEZ05UUmM5QVBWWFR4cGIyb0NJRmQ2TE94cmZWRXNQ?= =?utf-8?B?bm5UQjhaeEhGdnRzVjM0ZnlTaVhiNFlIMS9HTUFuVnlQTys0UTQrc1JHVnRQ?= =?utf-8?B?V0RiWUxIRVRLNmhncXdUc0NnVElVMnI0dXEwa2NsNFh0bEo4VWdPdEJLUyty?= =?utf-8?B?ZVBtcnNOQTFKa0dJd1A0N2dGb2pMZkJtSklqanpkRGJCRmhuZm10Q0l2U2lR?= =?utf-8?B?blNUZGJCNCs2NEJBb3pidENhUGUwbjhXdnN4ZTIxTnlqalJNNlM0VUQ3U3Ur?= =?utf-8?B?SFNjM2pQZ0pWSzJIeGN6TUJXQ3I2MUdKQnpXNzkzTktHOUV2a25UYURnbUpD?= =?utf-8?B?THV0V1VBUWNiUkw4MjlJNmV6Q2JLUEJhUk9wTEl1dE5JWnR2QUw2M05hMnJk?= =?utf-8?B?RHlBSjh6ZnZxWW00N3U4bitmbFkzN0JnZENVdGZidVFhRmZvSDlpZHU2Vktk?= =?utf-8?Q?gI5+91ttc/0=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB2826;6:gtzKulDAmRZPmWxJdYeNN+Yo724uhF6FJjWA19oMi8MMgzSB/BSDFBbK69ownmAaPHXS6eeFuJxSWzqPZFVY8nA5UbyfVISlpY/7hiQa27vOKqiTNwCi6Yr5nEz2bGxCY+hT/r6OFyvaMwW127MBW81QWQynNVWl8/vHze1GHghCpZNEbbAkiTUo6f3nkaZwiMM6rgIiYH+pQxiOPmbjOLzeGC7D93Di+Pqt7D7DS0XChAR/rnDpjKGCv+mwEc0zu3lS5mH5nwnAOxUg1ZyG2q8pOH7KJdDxXlj7uZa3xIdfIO9cvQBno2XFPZc3H314poKiw3lVUCqulyEORBGIvQ==;5:Tt1m2HNNyr7Jh+Wqovjnm2lDQ3f+NsaTnFCRLv+NBD093uZlvAkIgGF+Ft0XdVquZN2kPcy/lKwZr4NDpm5iNTtv4U8FAKwd8vYbeLb6rXXqkD1tjlT64Djynm+9KD/h5DD86uZX7fhwB+fr7hL+YQ==;24:czAc7wSYKjhDJnFD3IJ5IghP9cBNQSMmnNA+3ZON8gOVhbRT+kYRcjOwTflZOpExHOQNrg18H8D9nXH8pno6j/Y+aTejXxjOwJHmPmRKwGE=;7:/x0l7SIKVA+V/0SumdxGhtvYWGJLrN7DDVaS/BjniOzZFYdsFIGO7uHRYRU+JEgyaOpXiOsOcd5u93GHC1WYIVz8Kxi50LpYNPM33q17ysllk92+cX2C+v30pItzjJBySw63RkavKWRgrGW78e38jmIMssOfXbJ3fxbMLAFQ67bMuqXy+54QrlI8/0lfvtmtEWPA4/H+H7UjZwpKDnCdD946VOGSMEA+VpoZPVrZFNw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB2826;20:hdA0jHt0KW1+vSqH5RPpNcsjCCS4tYo2MRzicjAzFaUF9mdSDMEof43GJR4ktAtkgBnvGwMDMKZq6q+W2/MdC8yW9/pEGIvbnr4M5ZeUrYxxQ219ACO55gzufKEepEHTm/yhJN7AXy6e3CtiiBmbs+wVIG27z3plR/1/BcOamQQ= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2017 09:17:55.5999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2826 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2017 11:35 AM, Hans Holmberg wrote: > From: Hans Holmberg > > Lockdep complains about being in atomic context while freeing line > metadata - and rightly so as we take a spinlock and end up calling > vfree that might sleep(in pblk_mfree). > > There is no need for holding the line manager free_lock while > freeing line metadata, so remove the lock. > > Signed-off-by: Hans Holmberg Reviewed-by: Andrey Ryabinin I guess this also deserves stable tag. The bug was introduced in 4.13 by commit 588726d3ec68 ("lightnvm: pblk: fail gracefully on irrec. error"). > --- > This patch is for: > https://github.com/OpenChannelSSD/linux branch for-4.15/pblk > > drivers/lightnvm/pblk-init.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c > index c452478..a645117 100644 > --- a/drivers/lightnvm/pblk-init.c > +++ b/drivers/lightnvm/pblk-init.c > @@ -393,13 +393,11 @@ static void pblk_line_meta_free(struct pblk *pblk) > kfree(l_mg->bb_aux); > kfree(l_mg->vsc_list); > > - spin_lock(&l_mg->free_lock); > for (i = 0; i < PBLK_DATA_LINES; i++) { > kfree(l_mg->sline_meta[i]); > pblk_mfree(l_mg->eline_meta[i]->buf, l_mg->emeta_alloc_type); > kfree(l_mg->eline_meta[i]); > } > - spin_unlock(&l_mg->free_lock); > > kfree(pblk->lines); > } >