From: Lukasz Luba <lukasz.luba@arm.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal: core: thermal_core.h: fix all kernel-doc warnings
Date: Wed, 28 Jan 2026 10:09:41 +0000 [thread overview]
Message-ID: <79619479-8d59-4894-90a5-b83cd24fc987@arm.com> (raw)
In-Reply-To: <20260128062446.402175-1-rdunlap@infradead.org>
On 1/28/26 06:24, Randy Dunlap wrote:
> Resolve all kernel-doc warnings in thermal_core.h:
>
> Warning: drivers/thermal/thermal_core.h:99 bad line: trip point.
> Warning: drivers/thermal/thermal_core.h:101 bad line: passive trip point.
> Warning: drivers/thermal/thermal_core.h:152 struct member 'trips_attribute_group' not described in 'thermal_zone_device'
> Warning: drivers/thermal/thermal_core.h:152 struct member 'debugfs' not described in 'thermal_zone_device'
> Warning: drivers/thermal/thermal_core.h:152 struct member 'user_thresholds' not described in 'thermal_zone_device'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Lukasz Luba <lukasz.luba@arm.com>
> Cc: linux-pm@vger.kernel.org
>
> drivers/thermal/thermal_core.h | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> --- linux-next-20260126.orig/drivers/thermal/thermal_core.h
> +++ linux-next-20260126/drivers/thermal/thermal_core.h
> @@ -77,6 +77,7 @@ struct thermal_governor {
> * @device: &struct device for this thermal zone
> * @removal: removal completion
> * @resume: resume completion
> + * @trips_attribute_group: trip point sysfs attributes
> * @trips_high: trips above the current zone temperature
> * @trips_reached: trips below or at the current zone temperature
> * @trips_invalid: trips with invalid temperature
> @@ -97,9 +98,9 @@ struct thermal_governor {
> * @emul_temperature: emulated temperature when using CONFIG_THERMAL_EMULATION
> * @passive: 1 if you've crossed a passive trip point, 0 otherwise.
> * @prev_low_trip: the low current temperature if you've crossed a passive
> - trip point.
> + * trip point.
> * @prev_high_trip: the above current temperature if you've crossed a
> - passive trip point.
> + * passive trip point.
> * @ops: operations this &thermal_zone_device supports
> * @tzp: thermal zone parameters
> * @governor: pointer to the governor for this thermal zone
> @@ -111,6 +112,8 @@ struct thermal_governor {
> * @poll_queue: delayed work for polling
> * @notify_event: Last notification event
> * @state: current state of the thermal zone
> + * @debugfs: this thermal zone device's thermal zone debug info
> + * @user_thresholds: list of userspace thresholds for temp. limit notifications
> * @trips: array of struct thermal_trip objects
> */
> struct thermal_zone_device {
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
next prev parent reply other threads:[~2026-01-28 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 6:24 Randy Dunlap
2026-01-28 10:09 ` Lukasz Luba [this message]
2026-01-28 21:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79619479-8d59-4894-90a5-b83cd24fc987@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®