From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756976AbcIUXWp (ORCPT ); Wed, 21 Sep 2016 19:22:45 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:25458 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753281AbcIUXWo (ORCPT ); Wed, 21 Sep 2016 19:22:44 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; b=BkXSgPasMW+TVH+gybYWr03ZNWpZO4TFm1zhbHr3rgazhXOy4n+BYl09d7UMOC7qK9RbYCVGO0zQ QMVNXVpz8n8WqFRa7NvRKyLbtENBwmn33XDUuUvYhED3wAwzYUVT Subject: Re: [PATCH 2/5] mm/vmalloc.c: simplify /proc/vmallocinfo implementation To: David Rientjes References: <57E20BE0.6040104@zoho.com> Cc: zijun_hu@htc.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, tj@kernel.org, mingo@kernel.org, iamjoonsoo.kim@lge.com, mgorman@techsingularity.net From: zijun_hu Message-ID: <7961c13d-639a-25d7-ac0d-3dac2ebd7524@zoho.com> Date: Thu, 22 Sep 2016 07:22:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/22 5:16, David Rientjes wrote: > On Wed, 21 Sep 2016, zijun_hu wrote: > >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index cc6ecd6..a125ae8 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -2576,32 +2576,13 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) >> static void *s_start(struct seq_file *m, loff_t *pos) >> __acquires(&vmap_area_lock) >> { >> - loff_t n = *pos; >> - struct vmap_area *va; >> - >> spin_lock(&vmap_area_lock); >> - va = list_first_entry(&vmap_area_list, typeof(*va), list); >> - while (n > 0 && &va->list != &vmap_area_list) { >> - n--; >> - va = list_next_entry(va, list); >> - } >> - if (!n && &va->list != &vmap_area_list) >> - return va; >> - >> - return NULL; >> - >> + return seq_list_start(&vmap_area_list, *pos); >> } >> >> static void *s_next(struct seq_file *m, void *p, loff_t *pos) >> { >> - struct vmap_area *va = p, *next; >> - >> - ++*pos; >> - next = list_next_entry(va, list); >> - if (&next->list != &vmap_area_list) >> - return next; >> - >> - return NULL; >> + return seq_list_next(p, &vmap_area_list, pos); >> } >> >> static void s_stop(struct seq_file *m, void *p) >> @@ -2636,9 +2617,11 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v) >> >> static int s_show(struct seq_file *m, void *p) >> { >> - struct vmap_area *va = p; >> + struct vmap_area *va; >> struct vm_struct *v; >> >> + va = list_entry((struct list_head *)p, struct vmap_area, list); > > Looks good other than no cast is neccessary above. you are right, it will correct it i refer to show_timer()@fs/proc/base.c plainly and ignore that redundant cast > > The patches in this series seem to be unrelated to each other, they > shouldn't be numbered in order since there's no dependence. Just > individual patches are fine. > you are right, i will provide a individual patch finnally