From: David Howells <dhowells@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: dhowells@redhat.com, torvalds@linux-foundation.org,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] afs: Don't unlock fetched data pages until the op completes successfully
Date: Sun, 17 May 2020 23:36:57 +0100 [thread overview]
Message-ID: <796667.1589755017@warthog.procyon.org.uk> (raw)
In-Reply-To: <20200517210811.GQ16070@bombadil.infradead.org>
Matthew Wilcox <willy@infradead.org> wrote:
> > + if (req->page_done)
> > + for (req->index = 0; req->index < req->nr_pages; req->index++)
> > + req->page_done(req);
> > +
>
> I'd suggest doing one call rather than N and putting the page iteration
> inside the callback. But this patch is appropriate for this late in
> the -rc series, just something to consider for the future.
My rewrite of the fscache stuff changes this bit of the code anyway, and makes
it one call which may start a write out to the cache.
David
prev parent reply other threads:[~2020-05-17 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 20:21 David Howells
2020-05-17 21:08 ` Matthew Wilcox
2020-05-17 22:36 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=796667.1589755017@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®