From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752288Ab1BFKtT (ORCPT ); Sun, 6 Feb 2011 05:49:19 -0500 Received: from mail-px0-f174.google.com ([209.85.212.174]:57520 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147Ab1BFKtQ (ORCPT ); Sun, 6 Feb 2011 05:49:16 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=H8qVbVxhYEmK99ZeSJRvBtjanBcjbjnoOE8x0ii06BCM26mu9NGRQ28ZWoZqKbI52H TbiLOs34TNUXVytrgxbFzKryITtPnQwRPwElMRQoKVWDoc+cpr/RMFBr9IlwvFHiasvh cLMMjDBpkHTEZqPFKNZpwJbdB16YXDeW3k0ZA= From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , KAMEZAWA Hiroyuki , Hugh Dickins , Mel Gorman , KOSAKI Motohiro , Johannes Weiner , Minchan Kim , Dan Magenheimer , Andi Kleen , Nick Piggin , Al Viro Subject: [PATCH v4 4/6] truncate: Change remove_from_page_cache Date: Sun, 6 Feb 2011 19:48:03 +0900 Message-Id: <796768739e844f442a0b61a2d6199c84932f456b.1296987110.git.minchan.kim@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series changes remove_from_page_cache's page ref counting rule. Page cache ref count is decreased in delete_from_page_cache. So we don't need decreasing page reference by caller. Cc: Dan Magenheimer Cc: Andi Kleen Cc: Nick Piggin Cc: Al Viro Acked-by: Hugh Dickins Acked-by: Mel Gorman Reviewed-by: KAMEZAWA Hiroyuki Reviewed-by: Johannes Weiner Reviewed-by: KOSAKI Motohiro Signed-off-by: Minchan Kim --- mm/truncate.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/truncate.c b/mm/truncate.c index 4d415b3..faf65a5 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -108,13 +108,12 @@ truncate_complete_page(struct address_space *mapping, struct page *page) cancel_dirty_page(page, PAGE_CACHE_SIZE); clear_page_mlock(page); - remove_from_page_cache(page); + delete_from_page_cache(page); ClearPageMappedToDisk(page); - /* this must be after the remove_from_page_cache which + /* this must be after the delete_from_page_cache which * calls cleancache_put_page (and note page->mapping is now NULL) */ cleancache_flush_page(mapping, page); - page_cache_release(page); /* pagecache ref */ return 0; } -- 1.7.1