From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45B88387363 for ; Wed, 1 Apr 2026 09:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035577; cv=none; b=uXEjXYhL/gYG/dQBQroqp3N5eIxtrNGrxAe+Id3VWuc6fd12v9jGhaIoXPkai91kuPfSq/sG2Oonog0/UubKjbCfwzxvGhGOiulKENxhmunXCJnYlhiH5+55RLQPv2EK1B8DTmSWlgOEUMrSxuig+tbw6wGdW+2/P0ab4amSZfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035577; c=relaxed/simple; bh=N1UOi/5tFrC/OAvc2rlvDo0JIbGDld11JWi2OuSY+JU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uv6TAJuaJin6x9NNo5V5Y7NI/jI5NW/L1ddqtjPFGdUI6XteJlKLse6jsdt/kyGn5UTq0IyCfl5zD46W7e3mwfAaavp2wwuAtF9eKFB6GJtxsMVLWKbTBGGXeFSeCrQyF/SH2Sppeo7h1s8QJh3CFlHl+LZ8fxULsdQ7j6DpGI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UFMHORrG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bHlmUZ04; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UFMHORrG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bHlmUZ04" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6317EqLW4106747 for ; Wed, 1 Apr 2026 09:26:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KUS25DIIXUeo2vJxXPnbHMjNRhI9FjvXA7aN0RaY8ug=; b=UFMHORrGOpJ0IpdZ 6+ps6JZYUmmFJ9n5FRLGMoRQ77vwWU3IppzGHqmNZH6INn9r84wNrEOiR1rVGlSF JUIV9rPrxs7c8luVaIFIuOCmauIIdFXUaLu72gkHONaLoTqmrc5ffayyhxah1tpM +IvUTXYqD/Dx2aRB8msfJNYEsy8kcXuvBrqiyIxCxNCHOhH2sdsh3YX8JGPkOPPD 2AKW8jgDCgQXRrZxcqcAVZ7uk4bSUybDMG30K7d04rOlFf/2CE7+KiIxHNi0CRpu MYoAzozxzEztk3Si9MpkHKykvfn/hajHWOa51C2uWRDuoNDO6NquQYWmdwcrWpQq J1Xqvw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8xt90jnq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 09:26:15 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89f3e41fc17so18140836d6.2 for ; Wed, 01 Apr 2026 02:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775035574; x=1775640374; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KUS25DIIXUeo2vJxXPnbHMjNRhI9FjvXA7aN0RaY8ug=; b=bHlmUZ043OHK85iMOCw8KY23XW9Bg+fupi152XjjszRpy2PjioXfEiFnoYTNd+M8fM amaQRq6s6dF7VSYnK3y8dDksPnYtmfYOaY0M0IsTEp6vQRBAltCv9iUtz8X6CAH6auWc oOiKIFS5XYrDZSbHceJpFyiS0NxSGkfSln6ZDx2Lk938F3ADzIu39S/MenIahzKNrjeE rUqTenyZoh9wQlCwlNiMlAYLjnO3TXe/I/+YTaxRU3rR0+lwrylFn4odpYsU0EZPKkPi gcrZUqO9KnVkpoZyR5bH78HSbflvzNiievlTf2HR/2+IMP7AzuT6FBpl4rRaqbSt9zeY la3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775035574; x=1775640374; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KUS25DIIXUeo2vJxXPnbHMjNRhI9FjvXA7aN0RaY8ug=; b=jJb3yCyZBkReWBlsm8OHC9gwEvqNdP1/q1X0WoTa58HjBzABc2BkX1YK1frOL1Z8b4 wfLpEa4z0/TmwFngZ0w4OWzkxZWJi6Kgo78WxTZOnw6VsoyfO9vaw26aAL38z3HORcL8 kmowxlJQrQUY6ueKUr+CdFPXeGWzicAiMKs2lyNct1rJm7rxbI/r18HHkSr9YxAbKhcV aAeKBKvQroREy7Nbymyn9KGIbVYagfyXW1mEVkbyh2i8B21IpXheN8LIl1y7hLsL+ZRG Ne7Uy1cf1Eg8zChgWSy3swyDUN06tIxf48i8dCyK+S0PxbxER6GGdwGA37YSVDEY9PVB 9Yxg== X-Forwarded-Encrypted: i=1; AJvYcCVCz8v78eTLaagPCSA8B+3iAUh/4Mn+DK3BQmWy0VWIafU+DyvmkQ6iYkxGcSGnWrR18T8snL8k11bd2jY=@vger.kernel.org X-Gm-Message-State: AOJu0YxFXRht4UYJVPsUraY7kLw16OKBlMZ8qL/6zdP6Ax1wjMSxW0mR /5lMtV05jBL2rCUk3RGsoXZFt5l2y9fARsbkH4mYpI5XUV+sJ0yGF6fr6QqeLr724c3Vakag/78 ysBwlGC8j5G5dBNmZUHYGWZ0mtrayRnmFFIREwHqTpkGt0myIsMlBNiwJRj2js4X+ucI= X-Gm-Gg: ATEYQzyClZQAn6tKV7nMk/AhU7RccNIGY4tI25VBMGpZzMvFtHf1wPYE4Kx4hqEKRYZ YC8BXNIQ1iNvlzQ/uMQNJTLy8s37mvQdWfXlu0whbZIyLho6R7M2+PjAeoW1lz/tHWOLWb5vT9D nr+sookrjpIXjDZoW0gR7yH/0mXYVlA9h74q1Y9Ho3OHc9toYo3IgQqcxma1FvoBxLzXSFiW0g8 ZFDpDzS/GB7zf5NGu5ygUEDJCs/rin+06pcTk5doY7JZJRd5NwUsUleBXBib77UjkAo5QauVjoC 7bhA9+f8a6mDiZzZXJ4DXHRKpLT+HOCaasP3DFMCCKU6m6lb+OQONd3GiYeSNl9+83ckMJYezQu W2qqV48h7/uADtpi0zvTPA8KllQnnYMVk5fYqATC8IhxjV+FWnNr3pC0ovCzFbW+0W7yeSJ7oTV Og0/Q= X-Received: by 2002:ad4:5ae9:0:b0:89a:595c:b805 with SMTP id 6a1803df08f44-8a43a84f421mr30800796d6.6.1775035574626; Wed, 01 Apr 2026 02:26:14 -0700 (PDT) X-Received: by 2002:ad4:5ae9:0:b0:89a:595c:b805 with SMTP id 6a1803df08f44-8a43a84f421mr30800586d6.6.1775035574130; Wed, 01 Apr 2026 02:26:14 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7b1e472dsm500780566b.50.2026.04.01.02.26.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 02:26:13 -0700 (PDT) Message-ID: <796991b9-6f97-486e-8c38-3a9696c04032@oss.qualcomm.com> Date: Wed, 1 Apr 2026 11:26:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] ARM: dts: qcom: msm8960: Add GSBI5 I2C controller To: guptarud@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260401-expressatt_fuel_guage-v2-0-947922834df1@gmail.com> <20260401-expressatt_fuel_guage-v2-2-947922834df1@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260401-expressatt_fuel_guage-v2-2-947922834df1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: JlqGMwriTQ_IdF1Ju2tmF94blULF_wBK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA4MiBTYWx0ZWRfX8nz5ll6VZA+P lkrAeSbOefRkR1JiP40bCqWxcJNmkEM9K6Jk48EjAsHPx3EqapsC/dWZkvnw3DfLdzlxgngtKXn ZgDygxsSi/B/94cKPJ215iq7Ddpyr4NtYCsI24cEV6oA6qCKPQ1WM47gGIjiub88mCcp2OSumnO C9Asa60+E6TVlqmM0sQbqfc+GTuZuxZgCUsWvJmYen/s7nafr3TwrkoyqURKql0Fkud6xjHu+sK j2Es8APV4plnbyKC3d1MdzBD23Q/EeFWd9SB9GL5BtTmv5Z77IIowLa4raATjS0IK3VUyHiOkzW zLrSMX57bkf+Gjoth0Y/ugAl1TcyFaRsrPnARGTU5tKV+hjQvZS+RLTo57tT+Jg7e9K7UhVLieI N7UJjOXYontAoghUvAjh8abrVGLbINybMlsj1nJyua8/PT/kRFcFYT+/HoUW6aPodBV/PJzL+Xs J6kSs2TV6E09FcwcDqg== X-Proofpoint-ORIG-GUID: JlqGMwriTQ_IdF1Ju2tmF94blULF_wBK X-Authority-Analysis: v=2.4 cv=PoGergM3 c=1 sm=1 tr=0 ts=69cce4b7 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=Apu4DP7LmR_xVQy10KIA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010082 On 4/1/26 10:28 AM, Rudraksha Gupta via B4 Relay wrote: > From: Rudraksha Gupta > > Add the I2C controller node for GSBI5 (gpio24/gpio25) alongside > its pinctrl default and sleep states. > > Assisted-by: Claude:claude-opus-4.6 > Signed-off-by: Rudraksha Gupta > --- > arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 35 ++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > index fd28401cebb5..2088baef6c30 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > @@ -185,6 +185,24 @@ i2c3-pins { > }; > }; > > + i2c5_default_state: i2c5-default-state { > + i2c5-pins { You can drop this inner layer (i2c5-pins {}) and store the properties directly under the -state {} node Reviewed-by: Konrad Dybcio Konrad