mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 RESEND] usb: dwc3: core: configure TX/RX threshold for DWC3_IP
Date: Tue, 8 Aug 2023 02:14:46 +0000	[thread overview]
Message-ID: <796aa899992e4301a341a95f74d6f988@realtek.com> (raw)
In-Reply-To: <20230807233538.4vnycx5dej3nw2ak@synopsys.com>

Hi Thinh,

> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
> > f6689b731718..a0a54e5c4ad9 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -1262,6 +1262,39 @@ static int dwc3_core_init(struct dwc3 *dwc)
> >               }
> >       }
> >
> > +     if (DWC3_IP_IS(DWC3)) {
> > +             u8 rx_thr_num = dwc->rx_thr_num_pkt_prd;
> > +             u8 rx_maxburst = dwc->rx_max_burst_prd;
> > +             u8 tx_thr_num = dwc->tx_thr_num_pkt_prd;
> > +             u8 tx_maxburst = dwc->tx_max_burst_prd;
> 
> These are meant for periodic settings. You're overloading them for
> non-periodic settings.
> 
I will add new property for non-periodic settings.

Thanks,
Stanley

      reply	other threads:[~2023-08-08  2:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07  7:41 Stanley Chang
2023-08-07 23:36 ` Thinh Nguyen
2023-08-08  2:14   ` Stanley Chang[昌育德] [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=796aa899992e4301a341a95f74d6f988@realtek.com \
    --to=stanley_chang@realtek.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®