From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A72ECAAD4 for ; Wed, 31 Aug 2022 15:01:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231429AbiHaPB0 (ORCPT ); Wed, 31 Aug 2022 11:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231373AbiHaPBW (ORCPT ); Wed, 31 Aug 2022 11:01:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E414844D7 for ; Wed, 31 Aug 2022 08:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661958080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QihsBjiZvNOELw0Rtm2S0fzDvkyeBUo3nxHPcuLxME0=; b=EYvuux4Nt4lW4btKhMT41ATNrI921dKwSs8RmVQLKIUVCdvq14/lne8QDjnCBKPX2l0pN9 xMFlIwSK7OvUOPzJH4QiE/tyQSQwWZbck0k33Ng4UWpS38l/DxsvhSMPNysAGFg22EvMT7 nSvoPoLpEOY71/9NIAPL09WCp45x54w= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-rsAfYAwUOH212GukbWNnIg-1; Wed, 31 Aug 2022 11:01:16 -0400 X-MC-Unique: rsAfYAwUOH212GukbWNnIg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 910051C01B34; Wed, 31 Aug 2022 15:01:15 +0000 (UTC) Received: from [10.39.208.41] (unknown [10.39.208.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37F82403344; Wed, 31 Aug 2022 15:01:13 +0000 (UTC) Message-ID: <796c9d73-30a0-2401-e499-724aeb0f8dc6@redhat.com> Date: Wed, 31 Aug 2022 17:01:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2] vduse: prevent uninitialized memory accesses Content-Language: en-US To: jasowang@redhat.com, Greg KH Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, elic@nvidia.com, guanjun@linux.alibaba.com, parav@nvidia.com, gautam.dawar@xilinx.com, dan.carpenter@oracle.com, xieyongji@bytedance.com, mst@redhat.com, stable@vger.kernel.org References: <20220829073424.5677-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/22 09:48, Greg KH wrote: > On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote: >> If the VDUSE application provides a smaller config space >> than the driver expects, the driver may use uninitialized >> memory from the stack. >> >> This patch prevents it by initializing the buffer passed by >> the driver to store the config value. >> >> This fix addresses CVE-2022-2308. >> >> Cc: xieyongji@bytedance.com >> Cc: stable@vger.kernel.org # v5.15+ >> Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace") >> >> Acked-by: Jason Wang >> Signed-off-by: Maxime Coquelin > > Please no blank line above the Acked-by: line here if possible. Sure. Jason, do you prefer I post a new revision with this single change or you will handle it while applying? Either way is fine to me. Thanks, Maxime > thanks, > > greg k-h >