From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2459439E165 for ; Tue, 24 Feb 2026 13:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771940086; cv=none; b=gBbXjjAEg4H70ABJA0l0SWSHSeHp5LOAGcP2Ah840+nvxImPhY23QU42+tTBG2CYh3waOEWKrfGmRvzL16R9AdPJTmPRxfQ4m/HegkzS6bxaP9gOfVuZpNpy6Uy1UGfmW4uPjWaakn1Yr+MXOi9H1ogOT9E7bGDN5c7DybTkNlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771940086; c=relaxed/simple; bh=AoKNz6ZMF4uqd8jH65LmJoW0Cct5iI9B729m/0BS4KI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t7pbZ4eqbq05134hacRqv0wzJCAvi2PjdNzh26VX7wZnToaiQcVYwfY+kyRZt5xEHafqRR6VGB//rlmwvlnp5xbuazXL7wmihxLeiCsX6hpfKHDCNc3Maetu1FF/hK1ADADVeXo/IPMD2xhwHr+q5qA0RXlPl6q4GabxluxLyqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BXLbNvcl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AL3qXLqU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BXLbNvcl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AL3qXLqU" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61OAFQSm3570192 for ; Tue, 24 Feb 2026 13:34:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LIYFAK1vBrOWs+P/Ex9WJyjscDsM+5gNK2j9yi2D2vQ=; b=BXLbNvclhuVyOJ6y Vsb06lGg9u4cZc1h6wBMiI4zlEszaJxy+phIUKOwpIKK8cYDMzMrZ8RKsOhQst80 3C8SUc6CMihcmrpECFt/cgLf+qWBO4bOLa0mRy9ZzHPTOjnB5osT3cyaKrLQPxAH dWIGdYdgE2yQEvlJ8/GTvaC7mY5skKhouD8KFIAifnAXfE1WwxixUUow39K8isQe 61AbPAz/k7DTqJubC49qP6JVPvHFT0K7t9XK8P0twgUmdr3CGG4b0ZPC9rq6KV2Z 8WNWagwIJEDydPrM2OrUSjh8T0Lv9m9TxnK0lMs7AlcIiSHSxPDFm0DB/VQjATXs ZhqnxQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgn8rccma-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 13:34:44 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb399597fbso427004785a.3 for ; Tue, 24 Feb 2026 05:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771940083; x=1772544883; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LIYFAK1vBrOWs+P/Ex9WJyjscDsM+5gNK2j9yi2D2vQ=; b=AL3qXLqUpLUr5OingwEEIgpJmdxGnp16h1KEiuYIhb15FlXtinyds5BiGWXzMXVlkt TALHDzWW4rrXai4MHK5rhgxtCbgLQGk/kBUUUDI/sqAkUqlNLV8Eg8PBHiSYWtZm7kf9 QlpGpPSkfqIYPX/lsLINic8+d1iB2TLk9WIzYfPDgXO/2m78wkJ83db1MejWO1Bzg31P yuECc/k3XEraE7BwIOBT1t8+iEIUUm4nqhvLdE8KcfKaGlMkLn6uoXhm8x2+gLrjgB9x gT4sSW2TLnKuS3e7k5PxqpdoptdTOEB4d4ZIY1lTGvX1gHGd+/F7CgYym9FMHiBMccWi EfAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771940083; x=1772544883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LIYFAK1vBrOWs+P/Ex9WJyjscDsM+5gNK2j9yi2D2vQ=; b=iboyxgyIunT6BCMCf89pjXh08Uz5DwoUZtQrJjThEigCxCecpxVtEORisivzY11Pm5 58uB4Mwc6at/51a+bK3QHLvZr1X8kJ2qaPwVXs7x8LZJYutGOX7AawK/R1mp2F6i0Hbo h1FkWfeGgBdcrBR1IU3xf843LZ2eh28ebbsB4JhLP/z8+gHKYRPaaHjcNRLgNVRndqbS uAjtAncWQSAXvwlOG+hj7YD0KScyfNIn9myHMisR/7jEmncqD+8zH00cxL9c69yEfc2A 8FM9AgJENSAi30oy7pOIJoTHohQapCykXLtfH0/Ysw0XOy0J3qSVJsFj+6u/KpCwIdAk PCtA== X-Forwarded-Encrypted: i=1; AJvYcCX1soVsa3wTzW0toAxkOYd1Tu0coMFMPDhOg3ju+gOXceQeWwAATeDquvCs9lQYyWxkglqHVfqeD7skd1E=@vger.kernel.org X-Gm-Message-State: AOJu0Yym+BNke5SU3n4DUunNwilAS8h90vMwEkq7WUpM6oMzGcTmnFYt SyeEo9FaEOQz6MIiToG5AXmbPGrTaE547OqzPAdIhiXOcTcVflqIrLHV9xDFHOZ7T3qptk0OavD SNKAs9XBScqGkP8iez4P5OR0ZMifN/SeBaRouO7pLOnoNIBP5Lnx5SNQAcrcxviDIsDg= X-Gm-Gg: AZuq6aIa9+TgbfGwQOO0dzQV3lzf0HTy+nwXqv+Xxnpryg7wNc3b/+zNNt4PqNHNGRw ASI8m3T8IeRQG59Dd3tr+T6MGKVI6H+WEfEvBpVqJnOnw+HYrQ//FjOSnj+NGeaF3veCA9O6z75 8NZ6hQE1sWAjuEM0NuRYamKtWy4VGZp6jzTJF6aXK94qKBNJNJswyaUNTjoYBo1gIfKXa2QW81j ZsuOYQxYRc2mosxWmV2D5ltMKfaA05Xhzi5hi4H8CDUeEH54RnSIHm3Zx377WHRczjn3RXs0ecG exXvHFj+5pMQeSRLjYBNCy1s46+V3O7weLeoMZQJ92/l3nzb04a1LweX4q7adY95j2u+mKRBtCS tiedJLQa6Umw0FUJzgukM6dkW1kmLOMimsFEIKzKS8ohiJEt2RBo41mVXDjwfytuic8SQAEOSHL mQuBA= X-Received: by 2002:a05:620a:2a12:b0:8c9:fefa:89d5 with SMTP id af79cd13be357-8cb8cae5751mr1131816085a.10.1771940083364; Tue, 24 Feb 2026 05:34:43 -0800 (PST) X-Received: by 2002:a05:620a:2a12:b0:8c9:fefa:89d5 with SMTP id af79cd13be357-8cb8cae5751mr1131812985a.10.1771940082920; Tue, 24 Feb 2026 05:34:42 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084f03911sm420951266b.65.2026.02.24.05.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 05:34:41 -0800 (PST) Message-ID: <796de18d-83a0-4e26-bd9d-38f580ced9d8@oss.qualcomm.com> Date: Tue, 24 Feb 2026 14:34:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride To: "Wei Zhang (Stone)" , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260122053624.4068718-1-wei.zhang@oss.qualcomm.com> <46d0bc58-2c85-4293-a8ee-480282b80161@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: _djq8aEghtKIdLvpXbrg0NCCttZXzzoD X-Authority-Analysis: v=2.4 cv=V7twEOni c=1 sm=1 tr=0 ts=699da8f4 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=7RpJI5Hy-tzw3XJetusA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDEwOCBTYWx0ZWRfX/inus4RyBOah shcX5MPxMHZ5MSlf+yMny+WOlwt1Qu7H3XiOzZWbp5P5cB9wxJaneWbmTbFVzs5z1AquV/PZsSf G+no2SKnL8zwSmDKRDrdv0IEBAiQ9ToaPyxulG7XahFTz1oZArQ10vredRDZzlcFUyb5CHbAs2k HU6/vDkKYR3kABd8CgiiONNMsLESQfj3ecpBCmBA4U6zTmLs9XEiRLRyG5VPgEy+UOA3Ct9GdhG UNkIj+lOWgsY6EPNyBRy8d45guYKYF+4ijTAQDEv6YlC76I1CXFp99ioxfCbNFbXa35iFVFRCeC StLOlXB+2XeXGUIrrHFl0EQNJW55xMZFeDYHAWUs8KJlJnC0JLi/czypDT/hgdKnOLSFkmfsKEm CMTSIOZr+71lupLIDSF2EGpHx4UNplZlQoZMjARBv1u8UY3KFhkZf3iXmdjxppn/nia+mCsbSO1 Q/H2ZqPV7UbnhFzXD5w== X-Proofpoint-GUID: _djq8aEghtKIdLvpXbrg0NCCttZXzzoD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_02,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240108 On 2/23/26 6:51 AM, Wei Zhang (Stone) wrote: > > On 2/5/2026 5:28 PM, Konrad Dybcio wrote: >> On 1/22/26 6:36 AM, Wei Zhang wrote: >>> Enable WLAN on qcs8300-ride by adding a node for the PMU module >>> of the WCN6855 and assigning its LDO power outputs to the existing >>> WiFi module. >>> >>> On the qcs8300-ride platform, the corresponding firmware and BDF >>> are QCA6698AQ instead of WCN6855, which have been added in the >>> 20250211 release. >>> >>> Signed-off-by: Wei Zhang >>> --- >> [...] >> >>> +    wlan_en_state: wlan-en-state { >>> +        pins = "gpio54"; >>> +        function = "gpio"; >>> +        bias-pull-up; >>> +    }; >> pull-up sounds odd for an active-high pin > Good point. > GPIO54 is the active‑high WLAN_EN for WCN6855. The pull‑up is intentional to > keep the line stable during early boot and to reduce the risk of a low‑to‑high glitch before the PMU driver takes control. > WLAN enable/disable is still explicitly handled by the wcn6855‑pmu driver via wlan-enable-gpios. > I can switch this if a different default is preferred. Would such a glitch be problematic? This is an *enable* GPIO, not a reset one I would expect the WLAN is going to be off before Linux boots (unless that's not the case here?) Konrad