From: Reinette Chatre <reinette.chatre@intel.com>
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghuay@nvidia.com>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
Peter Newman <peternewman@google.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
Drew Fustini <dfustini@baylibre.com>,
Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<patches@lists.linux.dev>
Subject: Re: [PATCH v15 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters
Date: Tue, 9 Dec 2025 11:38:22 -0800 [thread overview]
Message-ID: <7974688a-7d12-4c59-be05-c5f4dff580f3@intel.com> (raw)
In-Reply-To: <20251204205404.12763-8-tony.luck@intel.com>
Hi Tony,
On 12/4/25 12:53 PM, Tony Luck wrote:
> Convert the whole call sequence from mon_event_read() to resctrl_arch_rmid_read()
> to pass resource independent struct rdt_domain_hdr instead of an L3 specific
> domain structure to prepare for monitoring events in other resources.
Please add a snippet to inform reader about the additional change that splits the
event counting flow. Here is a draft of the idea to start:
This additional layer of indirection obscures which aspects of event counting depend
on a valid domain. Event initialization, support for assignable counters, and normal
event counting implicitly depend on a valid domain while summing of domains does not.
Split summing domains from the core event counting handling to make their respective
dependencies obvious.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
| Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2025-12-09 19:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 20:53 [PATCH v15 00/32] x86,fs/resctrl telemetry monitoring Tony Luck
2025-12-04 20:53 ` [PATCH v15 01/32] x86,fs/resctrl: Improve domain type checking Tony Luck
2025-12-04 20:53 ` [PATCH v15 02/32] x86/resctrl: Move L3 initialization into new helper function Tony Luck
2025-12-04 20:53 ` [PATCH v15 03/32] x86/resctrl: Refactor domain_remove_cpu_mon() ready for new domain types Tony Luck
2025-12-04 20:53 ` [PATCH v15 04/32] x86/resctrl: Clean up domain_remove_cpu_ctrl() Tony Luck
2025-12-04 20:53 ` [PATCH v15 05/32] x86,fs/resctrl: Refactor domain create/remove using struct rdt_domain_hdr Tony Luck
2025-12-04 20:53 ` [PATCH v15 06/32] fs/resctrl: Split L3 dependent parts out of __mon_event_count() Tony Luck
2025-12-04 20:53 ` [PATCH v15 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters Tony Luck
2025-12-09 19:38 ` Reinette Chatre [this message]
2025-12-04 20:53 ` [PATCH v15 08/32] x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon_domain Tony Luck
2025-12-09 19:38 ` Reinette Chatre
2025-12-04 20:53 ` [PATCH v15 09/32] x86,fs/resctrl: Rename some L3 specific functions Tony Luck
2025-12-04 20:53 ` [PATCH v15 10/32] fs/resctrl: Make event details accessible to functions when reading events Tony Luck
2025-12-04 20:53 ` [PATCH v15 11/32] x86,fs/resctrl: Handle events that can be read from any CPU Tony Luck
2025-12-09 19:39 ` Reinette Chatre
2025-12-09 20:37 ` Luck, Tony
2025-12-09 21:31 ` Reinette Chatre
2025-12-04 20:53 ` [PATCH v15 12/32] x86,fs/resctrl: Support binary fixed point event counters Tony Luck
2025-12-04 20:53 ` [PATCH v15 13/32] x86,fs/resctrl: Add an architectural hook called for each mount Tony Luck
2025-12-04 20:53 ` [PATCH v15 14/32] x86,fs/resctrl: Add and initialize a resource for package scope monitoring Tony Luck
2025-12-09 19:40 ` Reinette Chatre
2025-12-04 20:53 ` [PATCH v15 15/32] fs/resctrl: Emphasize that L3 monitoring resource is required for summing domains Tony Luck
2025-12-04 20:53 ` [PATCH v15 16/32] x86/resctrl: Discover hardware telemetry events Tony Luck
2025-12-09 19:41 ` Reinette Chatre
2025-12-04 20:53 ` [PATCH v15 17/32] x86,fs/resctrl: Fill in details of events for guid 0x26696143 and 0x26557651 Tony Luck
2025-12-09 19:41 ` Reinette Chatre
2025-12-04 20:53 ` [PATCH v15 18/32] x86,fs/resctrl: Add architectural event pointer Tony Luck
2025-12-04 20:53 ` [PATCH v15 19/32] x86/resctrl: Find and enable usable telemetry events Tony Luck
2025-12-09 19:41 ` Reinette Chatre
2025-12-04 20:53 ` [PATCH v15 20/32] x86/resctrl: Read " Tony Luck
2025-12-04 20:53 ` [PATCH v15 21/32] fs/resctrl: Refactor mkdir_mondata_subdir() Tony Luck
2025-12-04 20:53 ` [PATCH v15 22/32] fs/resctrl: Refactor rmdir_mondata_subdir_allrdtgrp() Tony Luck
2025-12-04 20:53 ` [PATCH v15 23/32] x86,fs/resctrl: Handle domain creation/deletion for RDT_RESOURCE_PERF_PKG Tony Luck
2025-12-04 20:53 ` [PATCH v15 24/32] x86/resctrl: Add energy/perf choices to rdt boot option Tony Luck
2025-12-09 19:42 ` Reinette Chatre
2025-12-04 20:53 ` [PATCH v15 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG Tony Luck
2025-12-09 19:43 ` Reinette Chatre
2025-12-04 20:53 ` [PATCH v15 26/32] fs/resctrl: Move allocation/free of closid_num_dirty_rmid[] Tony Luck
2025-12-04 20:53 ` [PATCH v15 27/32] x86,fs/resctrl: Compute number of RMIDs as minimum across resources Tony Luck
2025-12-04 20:53 ` [PATCH v15 28/32] fs/resctrl: Move RMID initialization to first mount Tony Luck
2025-12-04 20:53 ` [PATCH v15 29/32] x86/resctrl: Enable RDT_RESOURCE_PERF_PKG Tony Luck
2025-12-04 20:54 ` [PATCH v15 30/32] fs/resctrl: Provide interface to create architecture specific debugfs area Tony Luck
2025-12-04 20:54 ` [PATCH v15 31/32] x86/resctrl: Add debugfs files to show telemetry aggregator status Tony Luck
2025-12-04 20:54 ` [PATCH v15 32/32] x86,fs/resctrl: Update documentation for telemetry events Tony Luck
2025-12-09 19:43 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7974688a-7d12-4c59-be05-c5f4dff580f3@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®