mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2 0/6] fixes for debugfs/wireless locking issue
Date: Tue, 28 Nov 2023 07:48:13 -0800	[thread overview]
Message-ID: <7979003a-6aa2-9af7-a3cf-d946c8e47a15@candelatech.com> (raw)
In-Reply-To: <20231124162522.16344-7-johannes@sipsolutions.net>

On 11/24/23 08:25, Johannes Berg wrote:
> There's a locking issue in wireless where it takes a lock inside
> a debugfs file handler that's also taken around the removal of
> the debugfs file, and this causes a deadlock due to the proxy
> object use. Fixing the debugfs removal is tricky because some
> of the objects represented there fundamentally are deleted with
> the lock held. Not taking the lock in the debugfs file is also
> not really the right thing to do. Therefore, right now, the only
> way to fix this would be to not have the debugfs files entirely,
> but that isn't really helpful either.

I have been running the RFC series and haven't noticed problems, so you
can add:

Tested-by: Ben Greear <greearb@candelatech.com>

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com



      parent reply	other threads:[~2023-11-28 15:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-24 16:25 Johannes Berg
2023-11-24 16:25 ` [PATCH v2 1/6] debugfs: fix automount d_fsdata usage Johannes Berg
2023-11-25 14:48   ` Greg Kroah-Hartman
2023-11-25 18:31     ` Johannes Berg
2023-11-25 19:29       ` Greg Kroah-Hartman
2023-11-24 16:25 ` [PATCH v2 2/6] debugfs: annotate debugfs handlers vs. removal with lockdep Johannes Berg
2023-11-25 14:48   ` Greg Kroah-Hartman
2023-11-24 16:25 ` [PATCH v2 3/6] debugfs: add API to allow debugfs operations cancellation Johannes Berg
2023-11-25 14:48   ` Greg Kroah-Hartman
2023-11-24 16:25 ` [PATCH v2 4/6] wifi: cfg80211: add locked debugfs wrappers Johannes Berg
2023-11-24 16:25 ` [PATCH v2 5/6] wifi: mac80211: use wiphy locked debugfs helpers for agg_status Johannes Berg
2023-11-24 16:25 ` [PATCH v2 6/6] wifi: mac80211: use wiphy locked debugfs for sdata/link Johannes Berg
2023-11-28 15:48 ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7979003a-6aa2-9af7-a3cf-d946c8e47a15@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®