From: John Garry <john.garry@huawei.com>
To: Luis Tanica <luis.f.tanica@seagate.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<linux-fpga@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: LPC Bus Driver
Date: Tue, 3 Mar 2020 10:13:36 +0000 [thread overview]
Message-ID: <797cec65-5504-ee85-3fe4-fe2b4c90991f@huawei.com> (raw)
In-Reply-To: <6daf1bb266a24c239aed34d8661fc5eaMW2PR20MB210660F6B17CB90ACD0B6E7CA0E70@MW2PR20MB2106.namprd20.prod.outlook.com>
+ add fpga list and Greg+Arnd for misc drivers
Hi Luis,
>
> We have this board with our own SoC, which is connected to an external CPLD (FPGA) via LPC (low pin count) bus.
> I've been doing some research to see what the best way of designing the drivers for it would be, and came across the Hisilicon LPC driver stuff (which I believe you're the maintainer for).
>
> Just a little background. Let's say our host (ARM) has a custom LPC controller. The LPC controller let's us perform reads/writes of CPLD registers via LPC bus. This CPLD is the only slave device attached to that bus and we only use it for reading/writing certain
> registers (e.g., we use it to access some system information and for resetting the ARM during reboot).
>
> I was looking at the regmap framework and that seemed a good way to go.
I thought that regmap only allows mapping in MMIO regions for
multiplexing access from multiple drivers or accessing registers outside
the device HW registers, but you seem to need to manually generate the
LPC bus accesses to access registers on the slave device.
If this FPGA is the only device which will ever be on this LPC bus, then
could you encode the LPC accesses directly in the FPGA driver?
> But then I saw the logic_pio stuff as well and now I'm not sure what
the best approach would be anymore
Logic PIO is for IO Port accesses. It could serve your purpose, but you
would need to use IO port accesses for your slave driver, like inb and outb.
As another alternative, it might be worth considering writing an I2C
controller driver for your LPC host, i.e. model as an I2C bus, and have
an I2C client driver for the LPC slave (FPGA). I think that there are
examples of this in the kernel.
All the best,
john
next prev parent reply other threads:[~2020-03-03 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 22:44 Luis Tanica
2020-03-03 10:13 ` John Garry [this message]
2020-03-03 15:45 ` Xu Yilun
2020-03-03 16:24 ` Arnd Bergmann
2020-03-03 18:07 ` Luis Tanica
2020-03-04 9:51 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797cec65-5504-ee85-3fe4-fe2b4c90991f@huawei.com \
--to=john.garry@huawei.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.f.tanica@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®