From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C510336EA80 for ; Sun, 12 Jul 2026 05:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783834108; cv=none; b=ReX2X7n46GvtDOtO23bnF/4Sz3NSKEoS6Lg5ByMc/uUE2KzQtwzMKY4QUefh8VRvbcGK8l8lNtzZGnfF6zMeUGVsouojKvxtDNu47qjpUxZelv7PcB91l7lhmXuyI7IkUo2afJ4NtYwzOqSNVypfm5HXrWj+khxLBwrgbmMGtBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783834108; c=relaxed/simple; bh=nOEmK3XB/2Nv0UqKvH+Vxs5Hqf/h1+tTy8igs7+ETwU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KvJNIgNJyeObo5lveEhSN55fw7I689+q2x6/ZaoohxjgeQrnI0Ds3yolU0ZjnGCS7om5MYqLVVVO8xoiocNkOOfltvW2ocHG5kXIisybotqAazyHGnZoQZt8kA1BWS6E/PTdqKREl1CWGmSu/Qay0ZnjaRW1iT6MdlCqEV+mDNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=aDiCM6Fp; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="aDiCM6Fp" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493c19bad03so18512405e9.2 for ; Sat, 11 Jul 2026 22:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783834104; x=1784438904; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Q8PFErrnCxf8I5BwHWz04TLQefkdEzOrr9DLWjdlF1M=; b=aDiCM6Fpteflo+eLwqRNvPduxN60BFxuSCtuckULf4Ya/9b7d0hVFJV0JIJFmcQ4DC d0Nx+aQNtMMn4UO4o2U40S1mq5gd815LnaU/OT2zM0yxPVrTZorsYnpcMiaphq8xhsfV uBoha/chj/JQkUx5DeuuX3oS760mu76sPD7hAXIffLpreeF4CxwhncQrvtSKCPhEvyeg tU0VjV+rBoksvyZCPyvTLHTGqIsNwJ0PAdxQ/Mo0ytlKWkzF2+aVr2VzSmp7ZfuEQ/Bg NH/Cr8YWBN1zJFVlZo7LdsMuzwq8/P9RF7rrGRkOUEOFEAmuPfrm3muVGaLIPv4ivM7S buLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783834104; x=1784438904; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Q8PFErrnCxf8I5BwHWz04TLQefkdEzOrr9DLWjdlF1M=; b=NAc9DeJn2JIWPzz/6qH2XY6ZiSo5iFp8EU2dAPJwwd4Mm94N+w3KzvJbnyN23/VMVJ FrJPrLUN8DWLdQyL1FWUGVRV1WbpzTAqOOYsBjf/dQrzA/ELB5RN7Wxa4YSfflo+WfQC eY/GnomA/eScSJ2kZqjRHSk7urCNTdhBc4kr/XhpczzqoPQ9git7THPgzyOHLqI23u7O Itt+542Z77Zn8+FSyAb5l3k6O3vkXboKU3AG6UJdOsHB/hqBYZqDdvkqRHNT627N3lQl F0BX8xfsBrMQWN1dYv+THCMsJYiQDtRCPp+xJXXgNZvir24sesWhOsGImpOGkEhafhZ4 jREg== X-Forwarded-Encrypted: i=1; AHgh+RobSd9yxWSgl45vv0VE1tnk7Ry+RNrytURh11C3nMIzDLfaI+g7Y5GHrZ04UWSgre1ekaneeOnnsRCPBsg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1oMzeVAZFdOoI0kimwmUFbEPgOqChko8fNDwQVaUN9xhXSvkn sRqFCu8Zy+ZSGiFLFQ+SIDzWyDB8QMez8xM+ip5jr3qqPcd/UIuHDLI+cdQHvTR3gd0= X-Gm-Gg: AfdE7ckifIzOmToQIhaBKw+e7MZ7DdxbE2bY7JHX+mE65yZ/0Noiz62Cw8Wl1OOnJ66 oSkl2yGukEzm4Z3xhC+iA05JIUNawaNiXNOXHa4zODl8lyx4tQMhXTArE9h7rv4KPCwBUh/NPoO TfCIkRbODbuEOpSxwVO7yphJF0CKnr4522T9AduGiiqRZLuTvg488j69JcCAxmIz/sKebsuOI8P L2Gf4rRv7MmVD00OaKKcP9u08NRJyo3bf0jA8UHA7yUvfaZ5T7DCHT0HYdXQdzGKiFhLTdIA639 ps7xm5pzeaMwvZsDIFGWHLQrjDLyl5baUDDoKagttq2j6KYTXrGIKiPcrUJEoajR90KPXdbd11v x5vq/gLiBc7wHJoyCH4fWKKvQguLsqwS1sotykUWbV8D+fzz1NmtzW/wE6y4UV2Ln1+229vx8IJ WYDc2qMQ== X-Received: by 2002:a05:600c:6216:b0:493:f6f0:d66b with SMTP id 5b1f17b1804b1-4940033a949mr2317865e9.1.1783834104165; Sat, 11 Jul 2026 22:28:24 -0700 (PDT) Received: from [172.16.0.229] ([159.196.52.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a55557f25sm4847558a91.5.2026.07.11.22.28.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2026 22:28:23 -0700 (PDT) Message-ID: <79875d25-0476-4330-b6f5-51d213cf6270@suse.com> Date: Sun, 12 Jul 2026 14:58:17 +0930 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] btrfs: free mapping node on duplicate reloc root insert To: Guanghui Yang <3497809730@qq.com>, Chris Mason , David Sterba Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/7/12 12:47, Guanghui Yang 写道: > __add_reloc_root() allocates a mapping_node before inserting it into > rc->reloc_root_tree. If rb_simple_insert() finds an existing entry, it > returns the existing rb_node and leaves the newly allocated node unlinked. > > The error path then returns -EEXIST without freeing the new node. Since > the node was never inserted into reloc_root_tree, the later cleanup in > put_reloc_control() cannot find it either. > > Free the newly allocated node before returning -EEXIST. > > The callers currently assert that -EEXIST should not happen, so this is a > defensive cleanup for an unexpected duplicate insert path. If the path is > ever reached, the local allocation should still be released. > > Fixes: 57a304cfd43b ("btrfs: do not panic in __add_reloc_root") > Signed-off-by: Guanghui Yang <3497809730@qq.com> Reviewed-by: Qu Wenruo > --- > Changes in v2: > - Add Fixes tag as requested by Qu Wenruo. > > fs/btrfs/relocation.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c > index fb85bc8b345c..7e451e587726 100644 > --- a/fs/btrfs/relocation.c > +++ b/fs/btrfs/relocation.c > @@ -588,6 +588,7 @@ static int __add_reloc_root(struct btrfs_root *root, struct reloc_control *rc) > btrfs_err(fs_info, > "Duplicate root found for start=%llu while inserting into relocation tree", > node->bytenr); > + kfree(node); > return -EEXIST; > } >