From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jonathan Derrick <jonathan.derrick@linux.dev>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: sed-opal: Don't include <linux/kernel.h>
Date: Mon, 5 Dec 2022 20:09:04 +0100 [thread overview]
Message-ID: <798ce9ef-fb5e-012f-a016-8f39589e4e10@wanadoo.fr> (raw)
In-Reply-To: <Y42ZV/AwSqUlDnas@infradead.org>
Le 05/12/2022 à 08:10, Christoph Hellwig a écrit :
> On Sat, Dec 03, 2022 at 01:18:49PM +0100, Christophe JAILLET wrote:
>> #include <uapi/linux/sed-opal.h>
>> -#include <linux/kernel.h>
>> +
>> +#include <linux/compiler_types.h> /* for __user */
>
> Not sure we really need the comment here, we don't comment on the
> other includes either. Also why the added empty line?
>
Ok for the comment, I'll remove it.
In header files, sometimes, when not obvious, we find such comments.
Sometimes we don't.
For the empty line, it was mostly a matter of taste. My goal was to
explicitly show that one was <uapi/linux, and the other one only <linux/
I'll remove it as well.
My main point, was only to remove kernel.h.
CJ
prev parent reply other threads:[~2022-12-05 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 12:18 Christophe JAILLET
2022-12-05 7:10 ` Christoph Hellwig
2022-12-05 19:09 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=798ce9ef-fb5e-012f-a016-8f39589e4e10@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=hch@infradead.org \
--cc=jonathan.derrick@linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®