From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E639343C05B for ; Tue, 30 Jun 2026 14:37:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782830239; cv=none; b=LxwtCoGyxPrlTXjYrW4zR+fPZOkwO06OrV1z4nlUPcflT+Mm0y0mHcfGE/Ne3+bdrB3csFAqO5k65imOtuOwGEHCFnJSH0NU5v1uTXdX3Uhu6BwnQk5Uf+Uw2WJpzminKC3zTbSUhSesE4Z715HeQ7EDtWnKZAcA3ndwjb0VP98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782830239; c=relaxed/simple; bh=VJkPOlo31BaH5cqVAnma8Jzets8wHIHf0hQnL3y1Yls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I7DNYbEnwKQZ8CiXkmY8cGwStK1/ch4mkr6DbygNdxQhPcZ3jo4LXtgBzqIbVGoX8oBv/b3HgswkNoOa8nX1+oLJLTc9WO/YculSV3UZM99DaopnUIPo8oyMGsGNkfEUfRvHt0SmQlmOjsJ+fyTFYTkNeHDD4rYRARNMvmapE1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lVMMHtM8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K/Vg4rS1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lVMMHtM8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K/Vg4rS1" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UEDXmB2116531 for ; Tue, 30 Jun 2026 14:37:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Bh8SlCTfNpOE7sOPuwSI5J0e39QVe4ueR4PAofbIuas=; b=lVMMHtM8FRGe+Laf ihUgoub3OjXSvAFK4payLgH0Gz8MVxGvsr6yhg5s6f+Q0Duf0GHLSCBm9k4Fle4+ 7WRrwJDo9cKtNt7rPQ+75uu08Js5kDQ2NjUxMgKIVM54ew8Ig6ZpEx+wTr4BUxjK /AfG4RbWuJeWm/J3Ve6GfFtEzXlohIHJpR33bdfPgWRhP6JHZ9Ojo/04yXhe7l61 1fMFbW9sx51LqubHB0lwD6nkqRqoQGeygQpX/AgWy6EyNII+2fKSXR80RoSY9hb8 Ls3T12v8NREsVzDoDHyRkAjkckNBxxj63/z1j19Qg9FdE557dpyx1WqXxlkmUe42 +N3Ntg== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3y9j42a1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 14:37:17 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5bdcdbc954eso8525e0c.1 for ; Tue, 30 Jun 2026 07:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782830236; x=1783435036; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Bh8SlCTfNpOE7sOPuwSI5J0e39QVe4ueR4PAofbIuas=; b=K/Vg4rS1BMSLb+7PH6EjqWnoDV4IavjU+pqlJj65rUDs8SNL8Lf6kPXzQgLGYiIOc1 3MNtAB/l8wVU5Zam6fSLIQWo/WG9Es+YZstJPmbkPQT62vSLiYcQk6Tui4cNi1Xq0vFQ cWbCKG7g9RE8jqbFDdMzGVyaca82NBEueadZo6VYYw2RE9ie9Fp0wqWRy9+9Xbq1QcGv ynTiP4DCEwMZgKxdsJ+ADiJz8M9WZ/NndZtZ28D92FvQ7Z4HBdw8EgvobK65Gkyy1uw1 IKC2evKojCe3NnvgZ2wJ3HbOuhD9rIIrYuzOQwyYjAnXz21f8lT81RMwV1VW+I3ptqFi TrSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782830236; x=1783435036; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Bh8SlCTfNpOE7sOPuwSI5J0e39QVe4ueR4PAofbIuas=; b=olxWpHC3vLdyYiP+GzrJdw7XI2rusrZUIBYNcSpv73U3+WvbUvU7o2FxemVm0FeCFk KwG55gplfb46hj85Ym6ztZPDsApXmFruPU0HX1V9b35k4NMZ+vUCnt+cCALkEx+TJJTe N2wcViJi0tTPqnsaVYXUK5O44yrpvp6DKOTIRZKD3/FmDe5sx9yn0PIgrWdSXNN76qSI VPuWYIMsNS32eNw7wINtwOVmfAX6XW4lI7gNVnKUmC9s28VeFYAk6KazaxEFTRDyFzdO 1mxZ8sR2eDwBV3h8kLrrnn/YY3Qf6U0Lcv4+2sBumWyXinm6aM1tAsC/qKnyBWtPcvyj xzog== X-Forwarded-Encrypted: i=1; AHgh+RrT6krMEeO1HWy/dEvinQWvsiQEQDbpegmEudlTPlelMOkPzwZSK1tNQlNo/KamfUT7QE+/RzFm1GjlNKE=@vger.kernel.org X-Gm-Message-State: AOJu0YxEqY2qExVkXiQDLzr0ea/hJkxGIT3ImPkkd/iG/TiITxbuup9O 8gcce5ZQYv9mne9xIX8eCN1jBqNcxtnhvhcqMC1yca6K0nkNlfmlGMT37JccdvFvLHePglHKxPz NC07Kz2PXHYW2CqINEjINiK7t72P7MLRDTegx7gpL/fQXCNJH/TdxgUSdwcPWVAte82I= X-Gm-Gg: AfdE7ckrHcqjkV4ax3soN1rFLyFi3YRr3m8tHcW3IKa6IJ9Y84MrYpM1FUtlcyoeD9e 8gldJo48H0kkpZU3Os2eHm/ecTazkhVPJO9qoMcHxXueKoG7iY5qgIFhZXB1LKo2IMlsdxyUdXk THqR/kaWJ6R+WWonVhB8+oNQ7uagVTpsb0nodsa3e1yDM08ne/a4Fr2X63I8HCD53DlAicoPNWB fosO7Rns7xi9t0aOBw5FYTerLLUPqfMobS2uut6Q3P2spwiE0c6ieyisBptq9UhlWnc1bhnBrNj VCEJjxNRbGAZsej38G5c0EGa6WMjDqsR5BiYeKtPMznnXv+Va0lmGiTx0Do21sPT5IaPVsGS0DH s/KxpOGJTZkU0tAwuRw7QEiVHvOmTo2viz9w= X-Received: by 2002:a05:6102:6448:b0:737:9003:ac52 with SMTP id ada2fe7eead31-73a333d61b9mr637531137.0.1782830236068; Tue, 30 Jun 2026 07:37:16 -0700 (PDT) X-Received: by 2002:a05:6102:6448:b0:737:9003:ac52 with SMTP id ada2fe7eead31-73a333d61b9mr637518137.0.1782830235630; Tue, 30 Jun 2026 07:37:15 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6987c93cbf8sm1373390a12.17.2026.06.30.07.37.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 07:37:14 -0700 (PDT) Message-ID: <798d2516-0772-4f98-8fad-959a1daf71bc@oss.qualcomm.com> Date: Tue, 30 Jun 2026 16:37:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: dispcc-sc8280xp: remove CLK_SET_RATE_PARENT from byte_div_clk_src dividers To: Brian Masney Cc: Pengyu Luo , Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, White Lewis , Maxime Ripard References: <20260303115550.9279-1-mitltlatltl@gmail.com> <22a469ef-0a25-48f6-bdc7-95ae5541e834@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: A4rmL3MNUpwH3Db0QSXxr5qi9dJoZ6nH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDEzNyBTYWx0ZWRfXwz4bTpv/mIcm E/QeovB8XtO/pKWh2xOMrot7xHTcs1h5yR0hyGSRz6vukDmWgIt8bdZJ2Y/++Zbi0t3rcv0kwDj pcwWyJbYysFfZ2QKVBAJ/KmApyGWsfN6s93laXn8ibjpU6otiCvx/bPwiwz4vq1LTwoDYfP0/UW u/Nlon8SBHlhUCaz87BwZiQi709nRHth6gdKCK05fCbnywCiMoDS43X9Y/teTa4/LRoxTb9tu/Y F5hgSRWwxm0ckhpykum4969HhnRdeIRwJORWbvkdEFzEE6b/JFGMd+Mr0+qC95KkjmCOBuP9noL 8gCxv6iUeqQ0e1KwQymvtKEn7DaJpPDdZpY2B9InuE+5jSFtX1J6HhkS05oJ+xo685qJxQy4RTw Eg5HfvX9D0s5UguTBNtBTJKL1gWPBc1uTO5XdHFos66xFzEocUyQYjz/EgZSHxwHZh35Sz2CjrV +FPNRFp3KdC0Ol11ifg== X-Proofpoint-GUID: A4rmL3MNUpwH3Db0QSXxr5qi9dJoZ6nH X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDEzNyBTYWx0ZWRfX4MZ42OZZgpt6 QcfRhW25cxiH0XWjR6gXUFYJDMSIPar56FGErGufda26WL05SXR7C4tt4vGRBCQ0AVY1FcW9ZCJ xfWP8pocVDz0tAGfvUKEusL9s03iuCU= X-Authority-Analysis: v=2.4 cv=SINykuvH c=1 sm=1 tr=0 ts=6a43d49d cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=20KFwNOVAAAA:8 a=vTfNKC5RNyR7SVgzpBIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_04,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300137 On 3/23/26 5:07 PM, Brian Masney wrote: > Hi Konrad, > > On Mon, Mar 23, 2026 at 8:48 AM Konrad Dybcio > wrote: >> On 3/13/26 5:54 PM, Brian Masney wrote: >>> On Fri, Mar 06, 2026 at 06:27:20PM -0500, Brian Masney wrote: >>>> On Wed, Mar 4, 2026 at 10:08 AM Pengyu Luo wrote: >>>>> On Wed, Mar 4, 2026 at 10:50 PM Brian Masney wrote: >>>>>> On Tue, Mar 03, 2026 at 01:10:43PM +0100, Konrad Dybcio wrote: >>>>>>> On 3/3/26 12:55 PM, Pengyu Luo wrote: >> >> [...] >> >>> Ignore my previous patch set. In my v6 that I just posted, I updated >>> clk-divider.c to support the new v2 clk negotiation logic. The >>> clk_regmap_div_ops uses this driver, so you shouldn't have to make any >>> code changes. >>> >>> Anyways, would someone from Qualcomm be willing to test this? The >>> procedure is fairly simple: >> >> Unfortunately, I don't think it's easy to get your hands on a 8280 >> device with DSI.. maybe Pengyu could test that on his tablet/laptop. > > It doesn't have to be an 8280 SoC. It could be any device that has the > issue where the parent rate change screws up that portion of the clock > tree, and crashes the device. This has been a long-standing issue in > the clk framework. I know you recently posted a series for 5 other > SoCs with a similar change [1], so any of those other devices should > work as well. > > [1] https://lore.kernel.org/linux-arm-msm/20260304-topic-dsi_byte_fixup-v1-0-b79b29f83176@oss.qualcomm.com/ > > The kunit tests in my clk scaling patch set demonstrate the issues > that I have worked on. For example, in my test scenario, I start with > a parent, and two children. The parent can do any rate. The two > children are simple dividers. This is the current behavior today: > > KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->parent_clk), 24 * HZ_PER_MHZ); > KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child1_clk), 24 * HZ_PER_MHZ); > KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ); > > ret = clk_set_rate(ctx->child1_clk, 32 * HZ_PER_MHZ); > > /* > * The last sibling rate change is the one that was successful, and > * wins. The parent, and two children are all changed to 32 MHz. > */ > KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->parent_clk), 32 * HZ_PER_MHZ); > KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child1_clk), 32 * HZ_PER_MHZ); > KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child2_clk), 32 * HZ_PER_MHZ); > > With my changes, the clk framework will land on 96 MHz for the parent, > and 24 MHz and 32 MHz for the two children. > > Anyways, it would be great if someone from Qualcomm would be willing > to help me test my changes on real hardware. If it requires code > changes to a specific clk provider, then I'm willing to also do that > work if someone can test for me. Getting confirmation that this is > fixed on real hardware will help to land my series that will provide a > solution to this problem that has existing in the clk framework since > it was introduced over 12 years ago. Was going through my inbox - do you still need the testing? I see that the last revision of the series (v6) is from march Do I need anything other than just the series itself? Konrad