From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753554AbdKIIox (ORCPT ); Thu, 9 Nov 2017 03:44:53 -0500 Received: from dispatch1-us1.ppe-hosted.com ([148.163.129.52]:48884 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753360AbdKIIov (ORCPT ); Thu, 9 Nov 2017 03:44:51 -0500 X-Greylist: delayed 304 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 Nov 2017 03:44:51 EST Subject: Re: [PATCH] net: sfc: remove redundant variable start To: Colin King , Solarflare linux maintainers , Edward Cree , CC: , References: <20171109080122.3254-1-colin.king@canonical.com> From: Bert Kenward Message-ID: <7992c6f6-f847-95b5-b16f-cbecdb05d439@solarflare.com> Date: Thu, 9 Nov 2017 08:39:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171109080122.3254-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.20.82] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23448.003 X-TM-AS-Result: No--8.967300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1510216787-fnxU6A0o0vBt Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/17 08:01, Colin King wrote: > From: Colin Ian King > > Variable start is assigned but never read hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/ethernet/sfc/ptp.c:655:2: warning: Value stored to 'start' > is never read > > Signed-off-by: Colin Ian King Acked-by: Bert Kenward Thanks Colin. > --- > drivers/net/ethernet/sfc/ptp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c > index 56c2db398def..caa89bf7603e 100644 > --- a/drivers/net/ethernet/sfc/ptp.c > +++ b/drivers/net/ethernet/sfc/ptp.c > @@ -648,11 +648,9 @@ static void efx_ptp_send_times(struct efx_nic *efx, > struct pps_event_time now; > struct timespec64 limit; > struct efx_ptp_data *ptp = efx->ptp_data; > - struct timespec64 start; > int *mc_running = ptp->start.addr; > > pps_get_ts(&now); > - start = now.ts_real; > limit = now.ts_real; > timespec64_add_ns(&limit, SYNCHRONISE_PERIOD_NS); > >