From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender3-pp-f112.zoho.com (sender3-pp-f112.zoho.com [136.143.184.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B9A3164A6; Mon, 24 Nov 2025 15:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.184.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763997957; cv=pass; b=AgkZT3ELQSWlKFG2hi2g+i3hrdDcHoqFU86IdmPxjmQ3SB7mn5M+Hgr2z25Ae1e0dMRm52qS7vqI9Ql0AKKiTy0BoMwfaYrNrDocqKjxwswHKZ+XRksn3P/pfxyOyeh7t1xzANkmW+PmNquooZbbIG7FUCEjPiqp1Sv2zq0yvBY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763997957; c=relaxed/simple; bh=xkNDproYaK80tjx8HPwuSyMiamVxnC9H4y5bQ+7aft8=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=OeBVqvciGNmkh5RrJbFgdgSIGz4C+2VaMZg1t8VgZNGu+ZsT4Bj4QZVYTj72PlVcU6uXWz+CgjXxj0eckdaiN2k+bfYl7R9qkQ/oW7eFc3hrRAaYCSnN7/PLYbEAO3PD1sYayidnWV+aMhUFCyx5HR0x7GXTtHf54tQkVBAfojQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=Cu2ATwBE; arc=pass smtp.client-ip=136.143.184.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="Cu2ATwBE" ARC-Seal: i=1; a=rsa-sha256; t=1763997941; cv=none; d=zohomail.com; s=zohoarc; b=UI1hfli3Q69C3/K6yBopCQ7ESXI2e2Nd7mDdMIRqXoDT5+UJdqOt1EljS9gT6wGIcGNsSUN6j5YpJRlRPw4Cbcccvs7aEfZjRpy8hUxTNGS6rv8tCoiwZ0P5uKsZhgd2kcOJsTK4XCJ5Pm2mpWJkSiwWeDisG2LweuEpRukD5Ts= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763997941; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=zvAP0rCzyafXkjCBmJbox5x2Ji8oWWUm5n8q37B7Clk=; b=TvehLIeBHZVDTbd+PHqKKfR3oxPO18QbGPVBH8AgQPgAH5HA4z/DGFFH1+9AyRax7ZkSUhHeVZAwM4JDChUzox/GMpv04VjKelzV7LV5hyip3MQuFoOJgB0akjV7n/iLhqY3VEJgJAA18waXkOloUCToFeT+rEu9nWngQ/a0tXk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763997941; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=zvAP0rCzyafXkjCBmJbox5x2Ji8oWWUm5n8q37B7Clk=; b=Cu2ATwBEL/ND0jjLi5JELDGDQ54hE8CdVQxodV1a8MfUsXE/Fo2e7g0YEtNrZF/A gbf1+zwdZHCQDh3xULF1XutbbaHKbcYeeRt92x5J0tY1syNIP3K3jHmiwr3HYltBW7k W2PCzjV9gfLEYSywB+cU8D2UlNN/X7owyxmXD+bA= Received: by mx.zohomail.com with SMTPS id 1763997939655515.524856708236; Mon, 24 Nov 2025 07:25:39 -0800 (PST) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH v5 4/8] rust: gem: Introduce DriverObject::Args From: Daniel Almeida In-Reply-To: <20251023212540.1141999-5-lyude@redhat.com> Date: Mon, 24 Nov 2025 12:25:23 -0300 Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Alice Ryhl , Danilo Krummrich , linux-kernel@vger.kernel.org, David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Asahi Lina , Shankari Anand , "open list:DRM DRIVER FOR NVIDIA GPUS [RUST]" Content-Transfer-Encoding: quoted-printable Message-Id: <799528A2-B13E-4F32-9EDE-504CE5D97E63@collabora.com> References: <20251023212540.1141999-1-lyude@redhat.com> <20251023212540.1141999-5-lyude@redhat.com> To: Lyude Paul X-Mailer: Apple Mail (2.3826.700.81) X-ZohoMailClient: External > On 23 Oct 2025, at 18:22, Lyude Paul wrote: >=20 > This is an associated type that may be used in order to specify a = data-type > to pass to gem objects when construction them, allowing for drivers to = more > easily initialize their private-data for gem objects. >=20 > Signed-off-by: Lyude Paul > Reviewed-by: Alice Ryhl >=20 > --- > V3: > * s/BaseDriverObject/DriverObject/ > V4: > * Fix leftover reference to BaseObjectDriver in rustdoc for > DriverObject::Args >=20 > drivers/gpu/drm/nova/gem.rs | 5 +++-- > rust/kernel/drm/gem/mod.rs | 13 ++++++++++--- > 2 files changed, 13 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/nova/gem.rs b/drivers/gpu/drm/nova/gem.rs > index 2760ba4f3450b..173077eeb2def 100644 > --- a/drivers/gpu/drm/nova/gem.rs > +++ b/drivers/gpu/drm/nova/gem.rs > @@ -18,8 +18,9 @@ pub(crate) struct NovaObject {} >=20 > impl gem::DriverObject for NovaObject { > type Driver =3D NovaDriver; > + type Args =3D (); >=20 > - fn new(_dev: &NovaDevice, _size: usize) -> impl PinInit { > + fn new(_dev: &NovaDevice, _size: usize, _args: Self::Args) -> = impl PinInit { > try_pin_init!(NovaObject {}) > } > } > @@ -33,7 +34,7 @@ pub(crate) fn new(dev: &NovaDevice, size: usize) -> = Result return Err(EINVAL); > } >=20 > - gem::Object::new(dev, aligned_size) > + gem::Object::new(dev, aligned_size, ()) > } >=20 > /// Look up a GEM object handle for a `File` and return an = `ObjectRef` for it. > diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs > index 67813cfb0db42..d448c65fe5e13 100644 > --- a/rust/kernel/drm/gem/mod.rs > +++ b/rust/kernel/drm/gem/mod.rs > @@ -65,8 +65,15 @@ pub trait DriverObject: Sync + Send + Sized { > /// Parent `Driver` for this object. > type Driver: drm::Driver; >=20 > + /// The data type to use for passing arguments to = [`DriverObject::new`]. > + type Args; > + > /// Create a new driver data object for a GEM object of a given = size. > - fn new(dev: &drm::Device, size: usize) -> impl = PinInit; > + fn new( > + dev: &drm::Device, > + size: usize, > + args: Self::Args, > + ) -> impl PinInit; >=20 > /// Open a new handle to an existing object, associated with a = File. > fn open(_obj: &::Object, _file: = &DriverFile) -> Result { > @@ -247,11 +254,11 @@ impl Object { > }; >=20 > /// Create a new GEM object. > - pub fn new(dev: &drm::Device, size: usize) -> = Result> { > + pub fn new(dev: &drm::Device, size: usize, args: = T::Args) -> Result> { > let obj: Pin> =3D KBox::pin_init( > try_pin_init!(Self { > obj: Opaque::new(bindings::drm_gem_object::default()), > - data <- T::new(dev, size), > + data <- T::new(dev, size, args), > // INVARIANT: The drm subsystem guarantees that the = `struct drm_device` will live > // as long as the GEM object lives. > dev: dev.into(), > --=20 > 2.51.0 >=20 >=20 Reviewed-by: Daniel Almeida =