Re: [PATCH] xen: Fix the issue of resource not being properly released in xenbus_dev_probe()

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1629 bytes --]

On 05.11.24 14:09, Qiu-ji Chen wrote:
> This patch fixes an issue in the function xenbus_dev_probe(). In the
> xenbus_dev_probe() function, within the if (err) branch at line 313, the
> program incorrectly returns err directly without releasing the resources
> allocated by err = drv->probe(dev, id). As the return value is non-zero,
> the upper layers assume the processing logic has failed. However, the probe
> operation was performed earlier without a corresponding remove operation.
> Since the probe actually allocates resources, failing to perform the remove
> operation could lead to problems.
> 
> To fix this issue, we followed the resource release logic of the
> xenbus_dev_remove() function by adding a new block fail_remove before the
> fail_put block. After entering the branch if (err) at line 313, the
> function will use a goto statement to jump to the fail_remove block,
> ensuring that the previously acquired resources are correctly released,
> thus preventing the reference count leak.
> 
> This bug was identified by an experimental static analysis tool developed
> by our team. The tool specializes in analyzing reference count operations
> and detecting potential issues where resources are not properly managed.
> In this case, the tool flagged the missing release operation as a
> potential problem, which led to the development of this patch.
> 
> Fixes: 4bac07c993d0 ("xen: add the Xenbus sysfs and virtual device hotplug driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]