From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753237AbbCZP0R (ORCPT ); Thu, 26 Mar 2015 11:26:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53981 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbbCZP0P convert rfc822-to-8bit (ORCPT ); Thu, 26 Mar 2015 11:26:15 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH V5 0/2] add support for pmic_arb v2 and correct framework From: Kumar Gala In-Reply-To: <1427363493.7093.4.camel@mm-sol.com> Date: Thu, 26 Mar 2015 10:26:09 -0500 Cc: Gilad Avidov , sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, svarbanov@mm-sol.com, linux-kernel@vger.kernel.org, agross@codeaurora.org Content-Transfer-Encoding: 8BIT Message-Id: <79F9F7D5-8426-46DD-831B-08A0AD0FD6A7@codeaurora.org> References: <1427305052-1284-1-git-send-email-gavidov@codeaurora.org> <1427363493.7093.4.camel@mm-sol.com> To: "Ivan T. Ivanov" X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 26, 2015, at 4:51 AM, Ivan T. Ivanov wrote: > > On Wed, 2015-03-25 at 11:37 -0600, Gilad Avidov wrote: >> pmic_arb v2 has no support for spmi non-data commands and thus >> returns -EOPNOTSUPP on .cmd callback. This causes a failure in >> spmi_drv_probe() which sends a wakeup command to the slave before >> probing its driver. This patchset removes the wakeup from >> spmi_drv_probe() since the spmi spec stipulates that a slaves >> default state is active and doesn't need a wakeup. >> >> Changes from v3 to v4: >> * Remove the claim that this is a bug fix off the commit text >> * Unmap the core register space as soon as we know that it will not be used >> * Assign the core reg space to a local until we know if it appropriate to use >> it to configure the controller fields (on v1) or unmap it (on v2). >> >> Changes from v4 to v5: >> * remove the unmap added in v4 since it is used again and the mapping is managed. >> * correct printf formatting for 64bit compilers. >> * correct base address for reading the channel table. >> >> Gilad Avidov (2): >> spmi: remove wakeup command before slave probe >> spmi: pmic_arb: add support for hw version 2 > > Thank you Gilad. This is fine now. Tested on APQ8084 > (controller v1) and MSM8916 (controller v2). > > I am wandering which is the appropriate tree to merge this? > > Kumar? We’ve been asking Greg to pick up SPMI patches. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project