From: Unnathi Chalicheemala <quic_uchalich@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>
Subject: Re: [PATCH v2 2/5] arm64: dts: qcom: sm8450: Add mapping to llcc Broadcast_AND region
Date: Tue, 6 Feb 2024 12:06:31 -0800 [thread overview]
Message-ID: <79a01e7c-3a88-49cf-b227-804155a65a4b@quicinc.com> (raw)
In-Reply-To: <1e26c5b3-716b-4f16-bae4-2682667550a5@linaro.org>
On 2/6/2024 12:35 AM, Krzysztof Kozlowski wrote:
> On 06/02/2024 08:15, Unnathi Chalicheemala wrote:
>> Mapping Broadcast_AND region for LLCC in SM8450.
>
> Why?
>
> And why your DTS is in the middle of driver changes? Driver cannot
> depend on DTS - you are now breaking all existing boards and users.
>
I was following a similar patch which has DT and driver changes in the
same patchset:
https://lore.kernel.org/all/20230314080443.64635-1-manivannan.sadhasivam@linaro.org/
The AND region was added in the IP block in SM8450, but was not added to the DT or
driver. That is why I included both in the same patchset - if you think the DT
changes should be separate I can correct it in the next version.
Thanks a lot for taking the time to review Krzysztof.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-02-06 20:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 7:15 [PATCH v2 0/5] LLCC: Support for " Unnathi Chalicheemala
2024-02-06 7:15 ` [PATCH v2 1/5] dt-bindings: arm: msm: Add llcc Broadcast_AND register region Unnathi Chalicheemala
2024-02-06 18:23 ` Rob Herring
2024-02-06 7:15 ` [PATCH v2 2/5] arm64: dts: qcom: sm8450: Add mapping to llcc Broadcast_AND region Unnathi Chalicheemala
2024-02-06 8:35 ` Krzysztof Kozlowski
2024-02-06 20:06 ` Unnathi Chalicheemala [this message]
2024-02-06 23:56 ` Dmitry Baryshkov
2024-02-06 7:15 ` [PATCH v2 3/5] arm64: dts: qcom: sm8550: " Unnathi Chalicheemala
2024-02-06 7:15 ` [PATCH v2 4/5] arm64: dts: qcom: sm8650: " Unnathi Chalicheemala
2024-02-06 7:15 ` [PATCH v2 5/5] soc: qcom: llcc: Add regmap for " Unnathi Chalicheemala
2024-02-06 8:40 ` Krzysztof Kozlowski
2024-02-06 18:42 ` Konrad Dybcio
2024-02-06 21:45 ` Unnathi Chalicheemala
2024-02-06 8:34 ` [PATCH v2 0/5] LLCC: Support " Krzysztof Kozlowski
2024-02-06 19:41 ` Unnathi Chalicheemala
2024-02-06 19:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a01e7c-3a88-49cf-b227-804155a65a4b@quicinc.com \
--to=quic_uchalich@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®