From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751338AbeBRDkw (ORCPT ); Sat, 17 Feb 2018 22:40:52 -0500 Received: from vern.gendns.com ([206.190.152.46]:56017 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbeBRDku (ORCPT ); Sat, 17 Feb 2018 22:40:50 -0500 Subject: Re: [PATCH 0/7] ARM: davinci: add genpd support To: Sekhar Nori , Bartosz Golaszewski , Rob Herring , Mark Rutland , Kevin Hilman , Russell King Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski References: <20180207134553.13510-1-brgl@bgdev.pl> <4dbc57ec-3506-eb1d-e00d-adfe75c3b39b@lechnology.com> From: David Lechner Message-ID: <79a981ae-881f-b358-629c-0b64e48f192d@lechnology.com> Date: Sat, 17 Feb 2018 21:41:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2018 06:42 AM, Sekhar Nori wrote: > Hi David, > > On Thursday 08 February 2018 04:13 AM, David Lechner wrote: >> On 02/07/2018 07:45 AM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Hi Sekhar et al, >>> >>> please take a look at the following patches. They add a simple genpd >>> driver and use it in DT mode on da850 boards. >>> >>> I was trying to use genpd in legacy mode too, but couldn't find neither >>> any interfaces nor users that would do that. For now I added a check in >>> arch/arm/mach-davinci/pm_domain.c that disables the clock pm setup if >>> we're using genpd. >>> >>> This series applies on top of and has been tested with David Lechner's >>> for-bartosz branch. It fixes the clock look-up issues we faced with >>> lcdc and emac. >> >> I'm starting to think that it makes more sense to just make the PSC driver >> a power-domain and reset provider rather than a clock provider. It is >> unfortunate that genpd is DT only. > > This will mean that the only way to enable clocks on DaVinci is to use > pm_runtime() calls. We do still have drivers which depend on clk api for > enabling clocks, so I am not sure its feasible just yet. > > I think a question like this can arise for any gate clock. > I've incorporated parts of this series into my v7 work in progress using the suggestions I made about using the existing PSC device as the power domain provider.