mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Saravanan D <saravanand@crusoe.ai>,
	linux-nvme@lists.infradead.org,  kbusch@kernel.org, hch@lst.de,
	sagi@grimberg.me, axboe@kernel.dk,  nilay@linux.ibm.com,
	sgogte@purestorage.com, hare@kernel.org,
	 linux-kernel@vger.kernel.org, iyamahata@crusoe.ai,
	kiyer@crusoe.ai, ganbalagane@crusoe.ai,  sjpark@crusoe.ai
Subject: Re: [PATCH v5 2/2] nvme-tcp: allow setting per-queue io_cpu through sysfs
Date: Wed, 21 Oct 2026 10:19:37 +0200	[thread overview]
Message-ID: <79b5a23a-5ecf-4e96-85c8-031b5eca2867@flourine.local> (raw)
In-Reply-To: <72fce5bb-b256-42aa-8844-f970c4480ad3@suse.de>

On Wed, Oct 21, 2026 at 09:21:09AM +0200, Hannes Reinecke wrote:
> > I think it make sense to allow that the user can change queue CPU
> > pinning during runtime even with isolcpu enabled. And then the question
> > is should this be connected to cgroups?
> 
> Not sure if cgroups is the right concept here; cgroups are user/
> application centric whereas nvme-tcp is pretty much queue/cpu centric.
> IE after all the cgroup calculations are done.
> Don't think cgroups are a good fit here.

There was a lot of discussion during Linux Plumbers on how to configure
a system for the isolcpus case at runtime. From what I understand, the
preferred interface for this is cgroups. Hence, pinning the CPU for this
work is likely a target for it, though I don't think there is a need to
figure it out right now. I just wanted to highlight this point.

However, to make this truly user-friendly, I think nvme-cli should be
extended so it is aware of this and can configure it directly. I've
merged Nilay's --nr-io-queues patches, so this is the natural next
feature nvme-cli should support; see commit:

e170d6985797 ("news: document the use of --nr-io-queues during nvme connect")

I would also really like to have a blktest for this as well.

  reply	other threads:[~2026-10-21  8:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18  1:00 [PATCH v5 0/2] " Saravanan D
2026-10-18  1:00 ` [PATCH v5 1/2] nvme: add per-queue sysfs directories Saravanan D
2026-10-18  1:00 ` [PATCH v5 2/2] nvme-tcp: allow setting per-queue io_cpu through sysfs Saravanan D
2026-10-20 15:28   ` Daniel Wagner
2026-10-21  7:21     ` Hannes Reinecke
2026-10-21  8:19       ` Daniel Wagner [this message]
2026-10-21 10:00         ` Saravanan D
2026-10-21  7:28   ` Hannes Reinecke
2026-10-21  9:53     ` Saravanan D
     [not found]   ` <sashiko-outbox-175868@kernel.org>
2026-10-21  9:45     ` Saravanan D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79b5a23a-5ecf-4e96-85c8-031b5eca2867@flourine.local \
    --to=dwagner@suse.de \
    --cc=axboe@kernel.dk \
    --cc=ganbalagane@crusoe.ai \
    --cc=hare@kernel.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=iyamahata@crusoe.ai \
    --cc=kbusch@kernel.org \
    --cc=kiyer@crusoe.ai \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    --cc=saravanand@crusoe.ai \
    --cc=sgogte@purestorage.com \
    --cc=sjpark@crusoe.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®