mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: "Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Rik van Riel" <riel@redhat.com>,
	"Oleg Nesterov" <oleg@redhat.com>,
	"Denys Vlasenko" <vda.linux@googlemail.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Kees Cook" <keescook@chromium.org>,
	"Brian Gerst" <brgerst@gmail.com>,
	paulmck@linux.vnet.ibm.com, "Andy Lutomirski" <luto@kernel.org>
Subject: [PATCH v3 11/15] x86/asm/entry/64: Simplify irq stack pt_regs handling
Date: Tue, 23 Jun 2015 19:46:14 -0700	[thread overview]
Message-ID: <79b6a6554e6befe737089f1a3ea6a99bda949516.1435113808.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1435113808.git.luto@kernel.org>
In-Reply-To: <cover.1435113808.git.luto@kernel.org>

There's no need for both rsi and rdi to point to the original stack.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 arch/x86/entry/entry_64.S | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 3fdfd3e27918..ce2d10933c11 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -505,8 +505,6 @@ END(irq_entries_start)
 	SAVE_C_REGS
 	SAVE_EXTRA_REGS
 
-	movq	%rsp,%rdi	/* arg1 for \func (pointer to pt_regs) */
-
 	testb	$3, CS(%rsp)
 	jz	1f
 	SWAPGS
@@ -518,14 +516,14 @@ END(irq_entries_start)
 	 * a little cheaper to use a separate counter in the PDA (short of
 	 * moving irq_enter into assembly, which would be too much work)
 	 */
-	movq	%rsp, %rsi
+	movq	%rsp, %rdi
 	incl	PER_CPU_VAR(irq_count)
 	cmovzq	PER_CPU_VAR(irq_stack_ptr), %rsp
-	pushq	%rsi
+	pushq	%rdi
 	/* We entered an interrupt context - irqs are off: */
 	TRACE_IRQS_OFF
 
-	call	\func
+	call	\func	/* rdi points to pt_regs */
 	.endm
 
 	/*
-- 
2.4.3


  parent reply	other threads:[~2015-06-24  2:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  2:46 [PATCH v3 00/15] x86: Rewrite exit-to-userspace code Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 01/15] uml: Fix do_signal() prototype Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 02/15] context_tracking: Add ct_state and CT_WARN_ON Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 03/15] notifiers: Assert that RCU is watching in notify_die Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 04/15] x86: Move C entry and exit code to arch/x86/entry/common.c Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 05/15] x86/traps: Assert that we're in CONTEXT_KERNEL in exception entries Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 06/15] x86/entry: Add enter_from_user_mode and use it in syscalls Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 07/15] x86/entry: Add new, comprehensible entry and exit hooks Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 08/15] x86/entry/64: Really create an error-entry-from-usermode code path Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 09/15] x86/entry/64: Migrate 64-bit and compat syscalls to new exit hooks Andy Lutomirski
2015-06-24 21:18   ` Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 10/15] x86/asm/entry/64: Save all regs on interrupt entry Andy Lutomirski
2015-06-24  2:46 ` Andy Lutomirski [this message]
2015-06-24  2:46 ` [PATCH v3 12/15] x86/asm/entry/64: Migrate error and interrupt exit work to C Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 13/15] x86/entry: Remove exception_enter from trap handlers Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 14/15] x86/entry: Remove SCHEDULE_USER and asm/context-tracking.h Andy Lutomirski
2015-06-24  2:46 ` [PATCH v3 15/15] x86/irq: Document how IRQ context tracking works and add an assertion Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79b6a6554e6befe737089f1a3ea6a99bda949516.1435113808.git.luto@kernel.org \
    --to=luto@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    --cc=vda.linux@googlemail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®