mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Hendrik Noack" <hendrik-noack@gmx.de>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Ferass El Hafidi" <funderscore@postmarketos.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Oleh Kuzhylnyi" <kuzhylol@gmail.com>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Chad Monroe" <chad@monroe.io>,
	"John Crispin" <john@phrozen.org>
Subject: Re: [PATCH v2 1/5] dt-bindings: input: touchscreen: hynitron,cst816x: axes and panel
Date: Sun, 4 Oct 2026 09:33:34 +0200	[thread overview]
Message-ID: <79b7910f-ece2-487c-bdbb-cc5d736056a7@kernel.org> (raw)
In-Reply-To: <asIAQMF57X2-YZKi@makrotopia.org>

On 04/10/2026 09:29, Daniel Golle wrote:
> On Sun, Oct 04, 2026 at 09:24:26AM +0200, Krzysztof Kozlowski wrote:
>> On Fri, Oct 02, 2026 at 01:47:21PM +0100, Daniel Golle wrote:
>>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
>>> index 72d4da636881e..027a2b3dcf2e8 100644
>>> --- a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
>>> +++ b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
>>> @@ -36,6 +36,18 @@ properties:
>>>        - description: Slide right gesture
>>>        - description: Long press gesture
>>>  
>>> +  panel: true
>>> +
>>> +  touchscreen-min-x: true
>>> +  touchscreen-min-y: true
>>> +  touchscreen-size-x: true
>>> +  touchscreen-size-y: true
>>> +  touchscreen-fuzz-x: true
>>> +  touchscreen-fuzz-y: true
>>> +  touchscreen-inverted-x: true
>>> +  touchscreen-inverted-y: true
>>> +  touchscreen-swapped-x-y: true
>>> +
>>>  required:
>>>    - compatible
>>>    - reg
>>> @@ -43,6 +55,9 @@ required:
>>>  
>>>  additionalProperties: false
>>
>> So just use unevaluatedProperties instead of listing almost entire
>> contents of touchscreen.yaml.
>>
> 
> "almost" is the keyword here. If it is acceptable to include properties
> the driver doesn't (and will never) parse, I'll do that instead.

And if you add them to the driver, you would be changing the binding? We
ask instead to post complete binding (see also writing-bindings).

Best regards,
Krzysztof

  reply	other threads:[~2026-10-04  7:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 12:47 [PATCH v2 0/5] Input: hynitron-cst816x: axes, gesture keys and panel power Daniel Golle
2026-10-02 12:47 ` [PATCH v2 1/5] dt-bindings: input: touchscreen: hynitron,cst816x: axes and panel Daniel Golle
2026-10-04  7:24   ` Krzysztof Kozlowski
2026-10-04  7:29     ` Daniel Golle
2026-10-04  7:33       ` Krzysztof Kozlowski [this message]
2026-10-02 12:47 ` [PATCH v2 2/5] Input: hynitron-cst816x: respect touchscreen DT properties Daniel Golle
2026-10-02 12:47 ` [PATCH v2 3/5] Input: hynitron-cst816x: release gesture keys Daniel Golle
2026-10-02 12:48 ` [PATCH v2 4/5] Input: hynitron-cst816x: time out gesture key release Daniel Golle
2026-10-02 12:48 ` [PATCH v2 5/5] Input: hynitron-cst816x: power sequence with the panel Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79b7910f-ece2-487c-bdbb-cc5d736056a7@kernel.org \
    --to=krzk@kernel.org \
    --cc=arnd@arndb.de \
    --cc=chad@monroe.io \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=funderscore@postmarketos.org \
    --cc=hendrik-noack@gmx.de \
    --cc=john@phrozen.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuzhylol@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®