mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Buday Csaba <buday.csaba@prolan.hu>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/1] net: mdio: reset PHY before attempting to access ID register
Date: Tue, 2 Dec 2025 14:46:42 +0100	[thread overview]
Message-ID: <79c050e9-83e7-4cc5-979e-457f098024bf@lunn.ch> (raw)
In-Reply-To: <5701a9faafd1769b650b79c2d0c72cc10b5bdbc8.1764337894.git.buday.csaba@prolan.hu>

> @@ -13,9 +13,12 @@
>  #include <linux/phy.h>
>  #include <linux/pse-pd/pse.h>
>  
> +#include "../phy/mdio-private.h"

Relative imports are generally not allowed. It sometimes suggests
layering violations.

I'm not convinced the complexity and ugliness of partially registering
a device in order to be able to reset it, is worth the effort when we
have a simpler solution of just using the ID values in DT.

Give the merge window, i will mark this as change request for the
moment.

    Andrew

---
pw-bot: cr

  parent reply	other threads:[~2025-12-02 13:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 13:53 Buday Csaba
2025-12-02 12:38 ` Paolo Abeni
2025-12-02 12:48   ` Russell King (Oracle)
2025-12-02 13:46 ` Andrew Lunn [this message]
2025-12-03 15:59   ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79c050e9-83e7-4cc5-979e-457f098024bf@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=buday.csaba@prolan.hu \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®