From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B2EB3905E0 for ; Thu, 18 Jun 2026 13:24:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781789063; cv=none; b=Fid08Kmc2Bgp6sb3MjRKue4q5I0+o0xvx8Ri6H/8CXc2Vf13JXho+9vfLH032uYYvRPYn7JPgBK1wWNytB6dU18fO5gFpH7p6bvahdU8vq+6kvuODVG+ujy6VQdap08hqERhnZztcEYovZFtfQ4n6oMe7yh9XruHRyriVNHvKg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781789063; c=relaxed/simple; bh=EjfJ/ixJ35QHyIg50lTriMaQBVhrwn33zrAlbnoCLoA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RhpvFdRFyZdv3G1JAaGJ8Qz7fV5lRiAA29hYahaygfj8RtZ7/Crmq0ZtFi6gpbdnpAXUJzQR/9whZFSu1sncNkm3clOPiFjfRfxB1ZHx6wcJPUAc+xLXlkwQ4OuN10R/Avv7Im1+no60AuBw4yuEHkJ2Yhg5kuksS81RqRcgP8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Di+XqVZ8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KJe8KD2t; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Di+XqVZ8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KJe8KD2t" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65ICuHi71638257 for ; Thu, 18 Jun 2026 13:24:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J3iEw7Y8XK5/7tKSn+yPX4FO3YXCdVSFl2Te6p2Xagk=; b=Di+XqVZ8b8ncmrev XmwFtP1sVz6e5zBdLBnGBVuIZV6DNCOAq4vUIhCRQQ58Iy6AtNYyOiIksOVGGHpD pV+FXivTZYh936bDt0LwvagaM22T40J25XzE/PK45B/7PgVy1d20oJ2grWxnE0yc ZwqpvZoL1A2s5K1kaMN6vt4vdHE2gUAmuge6j4bMkpZrZaHNQisuCIWCWpSjlaSk bec0VFW3761AhMd/TstjA74qSSADSvNKj9SMLjuaclwywidXiw77AbhV2cDX55Rk F+tNiTJuezsVd4r7sL+x8IzT2LI9ePBe8yzjtKRu0jQg2b1JDgjlivrM7cnEwqCu wYLHvA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ev1rtucr0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 13:24:21 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-7265c1b71f6so52682137.0 for ; Thu, 18 Jun 2026 06:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781789060; x=1782393860; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J3iEw7Y8XK5/7tKSn+yPX4FO3YXCdVSFl2Te6p2Xagk=; b=KJe8KD2tpD5qchD3cLpa9M0AZGhnGr9mHJbaReuvBFxr31g+wPIaC/AB7G8dn+tKue UAt3l7BUNBm/FGKcxytSiWLeadU/+6lxT/6jaNMpqujag7SzYD8aw2ZQpsZIQ2nOjLbR pt75/B1RtVPVYySxwHq5DPdPEnp35TdE6z1SIHaKYSeE8Ua1R8x3OmHZsKfhUw9DcQxn TiGhQXelAE8X7CmaKYTFDacpZEMHK/V5iEEkJR1mtlZEqOXyVWMmzsdnrXQzHEPuqhnJ fdr+9q+b/h4eB9wQDhxUEtWZt/4Fao1VshvXg4Rx49QhDEjqeWHYsI5qDpHVeCekybAW KzQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781789060; x=1782393860; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J3iEw7Y8XK5/7tKSn+yPX4FO3YXCdVSFl2Te6p2Xagk=; b=m1QJdHrS15PscEQq80BNJdWqCbU2KgQBH9Ll9hebCj4rUIx2zYf/i0ZLnhBSteZkv0 dPo2dnbBEFYZQ4ZAn8tp2+0AjxLVLlZd3m0ApNLIGV8QqWdjpU7AGslQDdpqd+iTOkTC aj8uAX2eu6g94jjv2cCsZinX9z0Z3tRTlgoZJqxM9vuWoFeV6OARIp44vUGcP5kR53Mk laMY8+MvELAueNs0hPC/e6PM6PCXBYCnLUiRkY2ASm+hhaG85+on/oPDmX/30t/yOOB/ Pj4+I8/L4CuhK690ZH5xIvgpSsBn0kdHm52519VLszx1Rm+I289d3neKVQvCrcpN9I/G ReIw== X-Forwarded-Encrypted: i=1; AFNElJ+8ydf+mBApqRrpMOa9pRXnknrqhoIgH5KAQZiLNG2RKjpzjAfzjbtRNsKBw7WOujuA0Xz0BEHiO4UM3lA=@vger.kernel.org X-Gm-Message-State: AOJu0YxGl9YkF8hn/zwmDzABIQv4lm//m5g/wat7L/yHZecbbWqS39cQ UaElhL3GJPAkw1iGFQRkUF8Xxk90vp9f/AFXRx7g3dwtfccBahqVuOmd/B4Ja9Q0EeLHkjCYdJf AqomFS3vPb33UwMGbgEirPiOaYkkH2NnTjZb+X+ew3bS2jHAMQNh3yfsvPx/gVlsq3/U= X-Gm-Gg: AfdE7clSZ5lcQz2bipxy+BW7kpqJrMhk4a8uI02YrSo/kcFlGOML5P2f3yopRhiAdsq CLerLyrC7rWhenmVzR0T/PFXvIsWQIQWsxuj/98IP0EPBPSGRw4JU3tJllm1CPnlmH+kcibeXxZ oUslqveyBbJiqZUs9Ek8v4nS2shSINWrMs3USqJok6kMIm8JsZYmuPIHe2hqqB4xHBOqPVcx1ye 7Jljmb3JKW8M07V2Pnvo9JjO1ZSnkyrp43yuuM8+kOlRcPCneRfrgiBE9StBH2pDvtMJwXFdegy ZThrDkBKGRDOSuoi2SIlZyISaqfp+USkjCEbIrM0jZi8Le37vInBU6HrtS8LgaH0Y7vDk+m/VOJ AWJSp4OHLUJS/9Q329HXN/mfPoAvOBESLDjs= X-Received: by 2002:a05:6102:334e:b0:631:bcfa:39d2 with SMTP id ada2fe7eead31-727d735f873mr567432137.6.1781789060423; Thu, 18 Jun 2026 06:24:20 -0700 (PDT) X-Received: by 2002:a05:6102:334e:b0:631:bcfa:39d2 with SMTP id ada2fe7eead31-727d735f873mr567417137.6.1781789060032; Thu, 18 Jun 2026 06:24:20 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c07a48c7931sm90091466b.21.2026.06.18.06.24.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 06:24:19 -0700 (PDT) Message-ID: <79c1dda2-153e-4b7a-ad18-c72db1cf4a00@oss.qualcomm.com> Date: Thu, 18 Jun 2026 15:24:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] drivers/rpmsg: Fix copy of channel->name into open request To: david.laight.linux@gmail.com, Kees Cook , linux-hardening@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: Arnd Bergmann , Bjorn Andersson , Mathieu Poirier References: <20260608095523.2606-33-david.laight.linux@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260608095523.2606-33-david.laight.linux@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=MNpQXsZl c=1 sm=1 tr=0 ts=6a33f185 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=pGLkceISAAAA:8 a=1-iA5IryhlbGIAVKO8AA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDEyNSBTYWx0ZWRfXyLrRbrWiqOt3 rw7lDrr2H7yR3FP4FUQJS49F8ApTlMnNtDcj98mOqLYozBoZ9z5Yt5Dqd4N9ehTlAGsh2bTv3AT eRgvrYkeeOvJmTwt3mpa/P0vfJ3vqNCHXqgvASwA6BBbJSuFH0nv7E04lmV0FGhygH3EOl6vUHl VRSHesFkFkdbKUyNWR4WDv4L3TBzwscdChf+Z/XlmjEb3fpSfaiLjNV5fio9CHunFubZcGk/0Yy WM9C2hhxb7SyeWeiTKhJBSquNLzN5JpabLlWaS1YrQFrapYgS+UUThJC23zUddyXR6yCbBK+8MY XGYpKNUufpo9dg/viZ1BgUf++twTpq2XuNXasmRRr847z37PUTleHH1BqnVjwu0xEVImFZ5Rm3P QJF/nI91SPNy54mJVq0HttsFaLfMwjCUtTuerC8uSv4Uti/1+PuEJG9uGjWR9O+3DtuhNyvMGOs 2ZHvL9bc+HyMykSIRfw== X-Proofpoint-ORIG-GUID: 7zhCQ1GveG-Q2vQ7WrKMr43eNdKpqBiM X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDEyNSBTYWx0ZWRfX7Ry2GK9OzZAp 0in9y1wDTY9630SQjYorFULt7tIAZN11bm9p/xFQJLRJtWcfOiudPZF4ySaPjBWmNVpPUwpQui4 y/alJLRT7fke5JkQjyzE+1aDOA8PGFk= X-Proofpoint-GUID: 7zhCQ1GveG-Q2vQ7WrKMr43eNdKpqBiM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180125 On 6/8/26 11:55 AM, david.laight.linux@gmail.com wrote: > From: David Laight > > Nothing obvious ensures that the name is less than GLINK_CMD_OPEN (32) ^ GLINK_NAME_SIZE [...] > @@ -481,8 +481,7 @@ static int qcom_glink_send_open_req(struct qcom_glink *glink, > struct glink_channel *channel) > { > DEFINE_RAW_FLEX(struct glink_msg, req, data, GLINK_NAME_SIZE); > - int name_len = strlen(channel->name) + 1; > - int req_len = ALIGN(sizeof(*req) + name_len, 8); > + int name_len, req_len; > int ret; > unsigned long flags; > > @@ -498,14 +497,20 @@ static int qcom_glink_send_open_req(struct qcom_glink *glink, > > channel->lcid = ret; > > + name_len = strscpy_pad(req->data, channel->name, GLINK_NAME_SIZE); > + if (name_len < 0) > + name_len = GLINK_NAME_SIZE; > + else > + name_len++; Should we perhaps do something along the lines of: WARN_ON(strlen(name) > GLINK_NAME_SIZE) to prevent silent clipping? Konrad