From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4BEC00A89 for ; Fri, 30 Oct 2020 21:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C31ED221FA for ; Fri, 30 Oct 2020 21:18:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727774AbgJ3VSY (ORCPT ); Fri, 30 Oct 2020 17:18:24 -0400 Received: from mga18.intel.com ([134.134.136.126]:43848 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727727AbgJ3VSY (ORCPT ); Fri, 30 Oct 2020 17:18:24 -0400 IronPort-SDR: g9UNoPbOUyipBQQMHaNvd8vF39IXkL4YPoNb0O0ykwX2B0UDGyeGmpmGhg93CtO4vaWiaDdjfs sjP7hMz9qzAg== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="156441123" X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="156441123" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 14:18:18 -0700 IronPort-SDR: x1CMf7tda0CkhegdditzFojF91wvC2FBMxdyEDmtdBF0cJVR+gTa+ewQy/QhXol8SvwpeoMFhP aQmQRwyv4kfw== X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="526009529" Received: from rchatre-mobl3.amr.corp.intel.com (HELO [10.212.87.224]) ([10.212.87.224]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 14:18:18 -0700 Subject: Re: [PATCH 0/3] Fix kernfs node reference count leak issues To: Xiaochen Shen , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tony.luck@intel.com, fenghua.yu@intel.com, willemb@google.com Cc: x86@kernel.org, linux-kernel@vger.kernel.org, pei.p.jia@intel.com References: <1604084530-31048-1-git-send-email-xiaochen.shen@intel.com> From: Reinette Chatre Message-ID: <79ccbc0b-32b4-2d02-2790-62350c917d67@intel.com> Date: Fri, 30 Oct 2020 14:18:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1604084530-31048-1-git-send-email-xiaochen.shen@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Apologies, the Subject intended to have a "x86/resctrl:" prefix. On 10/30/2020 12:02 PM, Xiaochen Shen wrote: > Fix several kernfs node reference count leak issues: > (1) Remove superfluous kernfs_get() calls to prevent refcount leak > (2) Add necessary kernfs_put() calls to prevent refcount leak > (3) Follow-up cleanup for the change in previous patch. > > Xiaochen Shen (3): > x86/resctrl: Remove superfluous kernfs_get() calls to prevent refcount > leak > x86/resctrl: Add necessary kernfs_put() calls to prevent refcount leak > x86/resctrl: Clean up unused function parameter in rmdir path > > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 82 ++++++++++++++-------------------- > 1 file changed, 33 insertions(+), 49 deletions(-) >