From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932587AbdEDTqz (ORCPT ); Thu, 4 May 2017 15:46:55 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43188 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbdEDTqx (ORCPT ); Thu, 4 May 2017 15:46:53 -0400 Subject: Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero To: Colin King , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org References: <20170503162901.3623-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Tyrel Datwyler Date: Thu, 4 May 2017 12:46:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170503162901.3623-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17050419-0040-0000-0000-00000332482E X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007022; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000209; SDB=6.00856257; UDB=6.00423870; IPR=6.00635434; BA=6.00005326; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015308; XFM=3.00000014; UTC=2017-05-04 19:46:50 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17050419-0041-0000-0000-000007266A88 Message-Id: <79da6ab7-da2c-c1fc-e384-92d68028d091@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-04_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705040286 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2017 09:29 AM, Colin King wrote: > From: Colin Ian King > > The 2nd check to see if request_size is less than zero is redundant > because the first check takes error exit path on this condition. So, > since it is redundant, remove it. > > Detected by CoverityScan, CID#146149 ("Logically Dead Code") > > Signed-off-by: Colin Ian King Reviewed-by: Tyrel Datwyler