From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92454C28CC6 for ; Tue, 4 Jun 2019 19:24:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77F5E20851 for ; Tue, 4 Jun 2019 19:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726528AbfFDTYW (ORCPT ); Tue, 4 Jun 2019 15:24:22 -0400 Received: from mga18.intel.com ([134.134.136.126]:7030 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfFDTYW (ORCPT ); Tue, 4 Jun 2019 15:24:22 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 12:24:21 -0700 X-ExtLoop1: 1 Received: from rbhardw1-mobl.gar.corp.intel.com (HELO [10.252.76.77]) ([10.252.76.77]) by orsmga008.jf.intel.com with ESMTP; 04 Jun 2019 12:24:13 -0700 Subject: Re: [PATCH] x86/cpu: Add Icelake-NNPI to Intel family To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, x86@kernel.org, bp@suse.de, Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Kan Liang , Peter Zijlstra , platform-driver-x86@vger.kernel.org, Qiuxu Zhuo , Srinivas Pandruvada , Len Brown , Thomas Gleixner , Linux PM References: <20190530123827.8218-1-rajneesh.bhardwaj@linux.intel.com> <20190604160914.GN9224@smile.fi.intel.com> From: "Bhardwaj, Rajneesh" Message-ID: <79e33a93-6180-5a58-0d8c-b34276e710f3@linux.intel.com> Date: Wed, 5 Jun 2019 00:54:12 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190604160914.GN9224@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy On 04-Jun-19 9:39 PM, Andy Shevchenko wrote: > On Thu, May 30, 2019 at 06:08:27PM +0530, Rajneesh Bhardwaj wrote: >> Add the CPUID model number of Icelake Neural Network Processor for Deep > I believe we spell "Ice Lake". I referred to https://patchwork.kernel.org/patch/10812551/ , https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e394376ee89233508fa21d006546357f8efee31 and many others where it mentioned Icelake. I am fine to change it the way you are suggesting, please confirm if its still needed and i will send a v2. Thank you. > >> Learning Inference (ICL-NNPI) to the Intel family list. Icelake NNPI uses > Ditto. > >> model number 0x9D and this will be documented in a future version of Intel >> Software Development Manual. >> >> Cc: Borislav Petkov >> Cc: Dave Hansen >> Cc: Andy Shevchenko >> Cc: "H. Peter Anvin" >> Cc: Ingo Molnar >> Cc: Kan Liang >> Cc: Peter Zijlstra >> Cc: platform-driver-x86@vger.kernel.org >> Cc: Qiuxu Zhuo >> Cc: Srinivas Pandruvada >> Cc: Len Brown >> Cc: Thomas Gleixner >> Cc: x86-ml >> Cc: Linux PM >> Signed-off-by: Rajneesh Bhardwaj >> --- >> arch/x86/include/asm/intel-family.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h >> index 9f15384c504a..087de5d3b93a 100644 >> --- a/arch/x86/include/asm/intel-family.h >> +++ b/arch/x86/include/asm/intel-family.h >> @@ -53,6 +53,7 @@ >> #define INTEL_FAM6_CANNONLAKE_MOBILE 0x66 >> >> #define INTEL_FAM6_ICELAKE_MOBILE 0x7E >> +#define INTEL_FAM6_ICELAKE_NNPI 0x9D >> >> /* "Small Core" Processors (Atom) */ >> >> -- >> 2.17.1 >>