From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbdEPNCA (ORCPT ); Tue, 16 May 2017 09:02:00 -0400 Received: from mout.web.de ([212.227.17.12]:63852 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbdEPNB6 (ORCPT ); Tue, 16 May 2017 09:01:58 -0400 To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , Chao Xie , Vaibhav Hiremath Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: SF Markus Elfring Subject: [PATCH] rtc-88pm80x: Delete an error message for a failed memory allocation in pm80x_rtc_probe() Message-ID: <79e5d766-2e58-4cea-7812-ea45995873ac@users.sourceforge.net> Date: Tue, 16 May 2017 15:01:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Lc1tiIsl2BkShiNkocA5B/a+KXFT5eR+vS6+qG9JUHvcbUbMXRp IbxydSaTMgVhPc9lTlMy7oz/xLaeqOT65/dLpi54sc/kfqk0wT8DIuBFcBK9TYXUG/VaAnz xr7Z6vEEG4QDPRG7dtL3cfFDB/mZ5IQFTu2iJ8hBvUvlaNHE3/tnOWiFI4DbsQAhF+tjEqj oaQr+xJDBcCpjcBJB3jxw== X-UI-Out-Filterresults: notjunk:1;V01:K0:AA/YlVkU31o=:FSr03YYuru27def2kV6FCM 6O9eMrmNRU9pqn8rXXkmx4hbmS1wZI+wosYDJGPPDtel/J8s9IkI34t4B5Nf0kBGUW+6kW8rg JPmr/vyQKgts8zijZzeo9nxBP0KU6K4vVasc4AkcaSn+avgJXlDi/OTyoGJ4YXFek8pVjcW2i tynd5LFgOkYJ1sxqX8JBTOy+aJWNn3BYcqGukpZBCN3g0tufc4mj1B6yRNuJ4pZTzv2h33IOi NR0DbMyoS6AxDlXNfmCryey1RDa66SJhgLVYX0Jg1ptWZT99lQtPg3mKOTLYh52qcAKcNDU+X JcN+04w2IAYRVAqu2x5VMwWb6PmCT/g3CHvE311jIqwbUolptwVe9VLZ3ZC7WSjNmiXecm1L3 ms9IZ1KhkQgHBCfBBMyt9bHJINa4FlULBa39vjEW8KcOpOIJJlr2KMnVVVx0Uh9vgD91MdVoa jbgWRj1UuWhMRIRHhGxP6Tl//h0HHfojpQrWYQ4RA+AoNvHvI5Af5iBIcPduEfhuwgctREvSM WJSMyQhng88oAU0WonHGm3uh3feHd+0SRVAXUr3vn5/YHJDL2uyFEPG/ll9slmBddRouS0+Pl YrfaxMBRd0EvpUA1PK2nn+s1NP6zhgGK29wKEJQ5+/3j2AHM4hHgmD14P5F6QC0ZPfpwi5ZwX Q6gKwy5s1lVld5EG+2g3PlKMgQJbLgL2U5b2AdyffCfY3XPwYPRjn5lqeU0s9Ho1T98i3Wj5L t8w/Ru5dGfIsC1XBhi2xvywjO6UFpVQpWrkbZc9lF1hEpymIXQyMpB31JwEpisrpvyqvoVGrI Z4RwFQ6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 16 May 2017 14:54:13 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/rtc/rtc-88pm80x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c index 466bf7f9a285..ae0e2561ecfa 100644 --- a/drivers/rtc/rtc-88pm80x.c +++ b/drivers/rtc/rtc-88pm80x.c @@ -266,10 +266,8 @@ static int pm80x_rtc_probe(struct platform_device *pdev) if (!pdata) { pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); - if (!pdata) { - dev_err(&pdev->dev, "failed to allocate memory\n"); + if (!pdata) return -ENOMEM; - } } info = -- 2.13.0