From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E990E370AEB for ; Mon, 8 Jun 2026 11:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780919120; cv=none; b=fAj1R1dHIUgJX59Y0N7ODggNwys1guYuKY2Wj+8ea1+DrfCdZsAmSN2NZp2YOFWYfBkLNtTnzEQEJL9fmaCtV4BCKtt6nU56IbCbBEC/eHLDUN9W0Hb0Tc5kyNVI/NaefWSPG5cOWDPoj/z32aNC9sEd1/+xzZjzyIVvA766LDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780919120; c=relaxed/simple; bh=S/5uyfhhCgsSjb9t77M59co6shwLNaNk5RDo3PmKTLc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LlwshCpCyLO7KT9hV5k16jb8NnnZw6DkgUMtIuiL7zEGSJtrawCmIf3jVH1W8Rhupv9fpsMf5cBUn9TPtxfjxCheaSUugbc9evvqIWRjRQFTXF0M0oCkjRDok8JC3sMl+fH6pzXlwPp9vLCGTRGwCXVM72pIS/OUlSnIn4fUfVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ebrGdBFf; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ebrGdBFf" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-84232e83ca9so1749327b3a.2 for ; Mon, 08 Jun 2026 04:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780919118; x=1781523918; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3RBJSxqfT0copcCoPASu9D+tQdpKRcrHjtldnEnz33U=; b=ebrGdBFfJsflAknKx+DaZVXgwHue21UNE00fNRvNyA1Q0WQBN56vAB1N8KlgphqxbE y6k/usViD+QyzgWzM6+qAGyqODV6TC0zhgHAA0Q3xO2d6AuDgl2IFH9Ciw1nZdrVohxV w0+NhVN/oYcCngKbBJ+4rqhec754R2a4TcS9zEZvZJgIj1hH67+iqpgD7CHPrpH1rdjr aPQjUIW2R5FfCRYSuheBdKdUE9R5BStcDpOqplw3/GPtqbQSdhwcj81vLQ6phIZMeEGp /bTAV9Mu5ROAoHn8AX3ZU/xY5PHyv1rXhQoF8USahn+UmCLC5Lu0IYvaBqGhQ7cVNCgE uzjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780919118; x=1781523918; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3RBJSxqfT0copcCoPASu9D+tQdpKRcrHjtldnEnz33U=; b=po0BgBJmZCnsMVm6NshP4pOdg0ETiNgRnxLGjwF629Ja7xylYILoqS/HT00QOyk/Q/ qDkEiAzJptS/RPRzLWkuJ18PStRBlkpYg3QLP0StYu51+xzOwBcn+LE7QhKBeIyk7PJs e/mUVREmItOrUtgv6R91T0BmkLmaXhXFcDvryYfrO8mx1thIq0J+1wkHKU0g7cuH4yUy f5T4pNeH3bT6hLqBMIMtwbncvyQKY7snRi9KSTWIMQcg6B0pagEI62q6mrR8K//i8gAm vSirrWZKZ1fsSSSVDyuhlopw6KK615y7gSVNgN20CFDeckcOBh/YuirvTrFCNQ/y6Kun iUMw== X-Forwarded-Encrypted: i=1; AFNElJ/Mp4SXuewz7Dtl0HQeQJ62uC/pODEuIS1bAkATUbgYB3+M8YeTQm8QLyEx3CHKoK8kbIW7KS/E/sxIECc=@vger.kernel.org X-Gm-Message-State: AOJu0YyWkaZHiFmlILZ3eLloqOvLbcP3s/550vKghXBOUu6ij0lz++CR YUd4qBuvoqg5yfMyLyops0rjW9+MMtjanOlaq6HnZDupXH8FoRIGLrXF X-Gm-Gg: Acq92OFtMe0/B5zUJMcd2q60pyAhOdsWGVVOUWHQksZYgu2br1MswzQgup59w5CvJZ9 462ftqutTbWW/lJP7XRchbJs6Ee5xveBfM4b6HtpBZIvxAy/Fb24DmUdamVjO+RfcFS6yjmDyIr GAgommzqLJObyf3xVOoMv+i9cjQA3a9PjNub4kqIAMicO9Pvz6/HvMgU4rVY48PVLzPCghypv21 nRaFpKMJQF1HOirLLr7yYldb3rQ28294bQqs9DyoR0fHqzCb27SpSArKjwATsyvpybvCGVS1qBe H9nAKTIlTMYtrDP9g7EUtxXilvfDFSOxEpuxkiYTFdg8WFjYE4LsDCOXMTGY9lngM5GXCwnNH9z FcPrjeoaWbEAb3Lqc1Ls//8kC/mWPKlyj+1PlXWKDDyN1V+0t36qUNStvNOlBVFQ77v0WFleqUE 5yrPgxh0zmg8a3BBTeYQdUyxFfS/DiWfDyfzhcQ9m2RV/74gQiIFoby56iqpsxAPtCaGSCqCl15 its7CEocieDqg== X-Received: by 2002:a05:6a00:1996:b0:842:2f28:4e36 with SMTP id d2e1a72fcca58-842b0f90897mr15772480b3a.17.1780919118219; Mon, 08 Jun 2026 04:45:18 -0700 (PDT) Received: from [172.19.1.42] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828836efsm17689182b3a.38.2026.06.08.04.45.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 04:45:14 -0700 (PDT) Message-ID: <79e704ef-bcaa-456c-9d0a-0680bd885563@gmail.com> Date: Mon, 8 Jun 2026 19:45:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] spi: ma35d1-qspi: Add Nuvoton MA35D1 QSPI controller support To: Mark Brown Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cwweng@nuvoton.com References: <20260608025009.1504971-1-cwweng@nuvoton.com> <20260608025009.1504971-3-cwweng@nuvoton.com> <8e751df3-6237-4c8e-9c87-34bb67e435f7@sirena.org.uk> Content-Language: en-US From: Chi-Wen Weng In-Reply-To: <8e751df3-6237-4c8e-9c87-34bb67e435f7@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Mark, Thanks for the review. I will add mem_caps in v3 and set per_op_freq for the spi-mem path. I will keep the direct CS polarity handling for now, and also add SPI_CS_HIGH to mode_bits. I understand that moving this handling into the core would be a separate issue. Best regards, Chi-Wen Mark Brown 於 2026/6/8 下午 06:53 寫道: > On Mon, Jun 08, 2026 at 10:50:09AM +0800, Chi-Wen Weng wrote: >> Add SPI controller driver support for the Nuvoton MA35D1 Quad SPI >> controller. >> +static void nuvoton_qspi_mem_set_cs(struct spi_device *spi, bool enable) >> +{ >> + struct nuvoton_qspi *qspi = spi_controller_get_devdata(spi->controller); >> + bool assert = enable; >> + >> + if (spi->mode & SPI_CS_HIGH) >> + assert = !assert; > Hrm, we should have the core deal with this. Separate issue though. > >> + ctlr->num_chipselect = NUVOTON_QSPI_DEFAULT_NUM_CS; >> + ctlr->mem_ops = &nuvoton_qspi_mem_ops; > We don't specify mem_caps, I'm vaugely surprised nothing trips over that > when testing.