From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F1A430E82E for ; Thu, 20 Aug 2026 08:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787213834; cv=none; b=LIJqD7zrFOGBFCo3u7B5STyZANV0lgaN5CzMaUTlRSjPQfxrcmVhAt53xGg2NhsxjN0EXJYdcHJ/y2mx7BrmLH4GWq/SyCsERD86WY/aHSqV2qysiDUL7HbzxZ9x4cePtb5plWRO5VunM4KvHbHzILl5KLe43nkzxaiKulDs51s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787213834; c=relaxed/simple; bh=azdjVMN3GQau7neihQ/6K+zOum2258xhwA7RSd6+FXg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MnfL16AsMfuiI59iS5HFPj0wKHQLwy6bZebIhg/7uK3flAD+IfV4tcOOcxdR23luydgwRzv+sVml1me4Afcs/UDykRo1aMVDy+6mLqRMlnsNiZPIQ9JySm+pfCXoeKdJLcHydKFk1NHXMEESk2XZw8HC3+WKFO6LUcQiN4LtBrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lScmViJZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QvnIo7gH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lScmViJZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QvnIo7gH" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67K6NHEQ490435 for ; Thu, 20 Aug 2026 08:17:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6kOKQx9GSDpN8SDqnvj/Olccsae+NtZfsVGGwbJTEyI=; b=lScmViJZvfvcDB5j iXaxpckD4fHZ8OeUNmwNYINlb9Q4vcB4yRa8dJuVLDOkLrmhbn+4CZqMNmoeQHCv z/MYpXV/1Zt8WEqOGaip83lFyzWmLFt2+jH5mrj6KSL2qa+G94jRuYDRc+kYau9G D4rHa94eYPbV5c3c1qeAmkkoKTS76KtzdBfVY4k6D2u+joovijf8gRRItm7X9yF+ 5WcdlApr9hlr3rVyidwFMYXPNuPCtWar/ZLHQxZmpr8+31veQYxdrNTsGAdxXYJP JGI/Lz1HBHBnjTMRiFPKgdKmZhgpBA8ttC1W58Y+SSHCxamgo3JaoxRhX2KE8h+6 hroTjg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5ervkxaj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 08:17:10 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e661ce1dcso8654185a.0 for ; Thu, 20 Aug 2026 01:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787213829; x=1787818629; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6kOKQx9GSDpN8SDqnvj/Olccsae+NtZfsVGGwbJTEyI=; b=QvnIo7gH6mE16+N6EbmWzgHIyDaQME4Vkd/KSvxilUtVtXX7B1YW5CH3XSdGuvHqre iki1U2/Rd1m943NgyF1RNNzi9zSvGlS4yUzaDXNEZ8ESILz9gU65rm6Tmw9AwPNhZEis Jw4NXvqZD/VN22/7ahL1rKrrgBqvXNiBbcYOxwWPD7NcoEYa8bkOCU6TVEpOkEwiUn7f IXW16q0eb2jvIFrVFo2hmsxplLnv0ETy/Va5vnrZqlOkFrFNeKHwx2P975vmY2uxlUyL ojFNFWDNiJUNeWPVW8E0GQfCGTF2FkyufjcNDJ2hw+UfnkRU7LRYNh8qlZ9UjfF65sjs pgjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787213829; x=1787818629; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6kOKQx9GSDpN8SDqnvj/Olccsae+NtZfsVGGwbJTEyI=; b=PQKcb+SBh5Si97Wq5Ijphuetd2vIDTM+NvvT94uZ1FS1Ud1Xj85Vbglmr6DMfFbmcD aAJtoZ0EWZ6hKlt3R/n19C2XMVwYMY7IY7dDViN7l6jVHSVdsN2UUlyybBZibjE25yVy G1UYB0aDPgA6HTu/vS7NozPb6Y5d9pR6bYxowkj87pkG3/h38SrQdKkCd+kPkazfWb5W iMVCzRcqFEeDnFSbO1ZPOk4GZ+le4B+0hGyI17aBD3lLoqWILdE2u/vhuYqr59kt5F4X Z5QD7GumwmWtuYXOMT6jsZSHZzHYJi6FOyy4bd+1NnNLKezktOEWYgfaywP+fnwvk0GU 7vpw== X-Forwarded-Encrypted: i=1; AHgh+Rp4YG73CPGRx+3estJgWJ8T2lPrFtMbjcSeCT0HTcD3pQ1mSaIO3hw8jlu2RoSFZaZJi8i5+IKox1U4HCY=@vger.kernel.org X-Gm-Message-State: AOJu0YwhInOvk7nTJ7KnguFU0UFVpQySRtF4e9FPvaMXKDVuDoaiVd7U vgJdSeS9avQCa7QwhtsHqd9OCpYFUKhr555YZccQsCuTtovnOA5oMT/f1ZsbkWGlyYOEXWMRRx7 lGYqW17QN1OSrlaIz2FXzle3xVlt6olx3CYx8Xd+FFD7el0wPcSSXHIlPTyCGBSj6kzM= X-Gm-Gg: AR+sD121y44dA6IfJVWTz61Rep21Yf4kEVkjQvDMEVidBU1I/le9s6TDbNeP+Zr16Qp HvZxcXwsBC25cjwHorfn6npN8tBg9bZIEf+lvksID8Tln0nv0nfCbTkVQCe7UkzOYhAUEziRFvl vTu8o6ycm8xvIDxMtmOveHTsaTIcTRf80MI5hMaAe2ZgROx8xNuRT6H2FjECLGENGOF8WQieRNU PrfL4tfVif2HEqYwMveHXN5WFDk3B1oUanzTL+EnivsxDYT8LgJ6RvGsJCnh5WdJRfG5ZokxWlk nxNv8FIZiwX8icTzhs6ij8MIDVEpvWMeOk8yc0ltJ5Jmr22rqBftJG6y7SoT+qRSPqEMsf+IMsC wEdlofedct9DtA+J5s+FMn5uf X-Received: by 2002:a05:622a:588:b0:51b:f9e0:87b0 with SMTP id d75a77b69052e-52dd579195emr73714271cf.2.1787213829287; Thu, 20 Aug 2026 01:17:09 -0700 (PDT) X-Received: by 2002:a05:622a:588:b0:51b:f9e0:87b0 with SMTP id d75a77b69052e-52dd579195emr73714011cf.2.1787213828773; Thu, 20 Aug 2026 01:17:08 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2458b094c4sm41825266b.22.2026.08.20.01.17.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 01:17:08 -0700 (PDT) Message-ID: <79fa9d60-f8e9-4e5b-8c01-9ddb3a86e3fd@oss.qualcomm.com> Date: Thu, 20 Aug 2026 10:17:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop To: Fan Wu , linux-usb@vger.kernel.org Cc: bryan.odonoghue@linaro.org, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260819161448.76597-1-fanwu01@zju.edu.cn> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260819161448.76597-1-fanwu01@zju.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 1FePWdPGSUPJsN1mAZiLmWHqduVK2MjD X-Authority-Analysis: v=2.4 cv=VZ3H+lp9 c=1 sm=1 tr=0 ts=6a86b806 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=EsPibtQv_QutKtu_k7wA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDA1OSBTYWx0ZWRfXwvzmQbM0mU2H bpHJngDtEvoIhGLa4/7PngzemXUplj5CdznaCJmUM0bdgF5kRUiQBvp5C5IVZ3TfSg08VwkrSkD EERquKdPj2Vk6vDzIS9Vxai1EJcSKOAdqWYsqHdRD53XP5Xm0zZDTb/3efdh6F23sGtSM6UhpnJ l5yQmn2ZxUvAeWDtd3/gRTRh1YGtA0k1erFLH9wCbtqjk09OlXa4BJOrNP2Cx+494/szva2e25J 8Z7om2qekoy9jjx82KTPBoXMQXK/AsB6oDubDTgr8d/Zw8W2nUVnlciZZ9rzfkWSiCScfh9EvcJ 2uhr+H2MRXd59RY1YQtzYt+met2nPM3pNc0Gi3FIE2rSb60LmZzZV2iJmqLCaIKNM4sTfIoMt2Y tfWZoXDRmDTyp4kGfeFFVm5KUc+TvF8f7rIqBijSYpwpn/aLnt+4khIpC/XszPCq9rnGToOw33a tBbpeZfUybeTdK++cxQ== X-Proofpoint-ORIG-GUID: 1FePWdPGSUPJsN1mAZiLmWHqduVK2MjD X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDA1OSBTYWx0ZWRfXxdud3gwqcqHb fycBjRVhfGQUeEPa8qpnLQ6f0/TJCEK16qPCbwL8m9TEUwmqLwkQzgVy8mJrW+rslMmIl/bFmlL ioWQuTAIOlH6GX37tdzfm2b7dGRr+SE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200059 On 8/19/26 6:14 PM, Fan Wu wrote: > pdphy_stop() disables IRQs but leaves reset_work pending. If the IRQ > handler schedules it just before disable_irq(), the work runs after > remove() frees the struct via devm. > > Call cancel_work_sync() after disabling IRQs to close the window. > > This issue was found by an in-house static analysis tool. > > Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") > Cc: stable@vger.kernel.org > Assisted-by: Codex:gpt-5.6 > Signed-off-by: Fan Wu > --- Reviewed-by: Konrad Dybcio Konrad